* [PATCH] block: force select mq-deadline for zoned block devices
@ 2019-06-04 7:23 Damien Le Moal
2019-06-11 9:31 ` Damien Le Moal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Damien Le Moal @ 2019-06-04 7:23 UTC (permalink / raw)
To: linux-block, Jens Axboe; +Cc: Matias Bjorling, Chaitanya Kulkarni
In most use cases of zoned block devices (aka SMR disks), the
mq-deadline scheduler is mandatory as it implements sequential write
command processing guarantees with zone write locking. So make sure that
this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected.
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
block/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/Kconfig b/block/Kconfig
index 1b220101a9cb..2466dcc3ef1d 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY
config BLK_DEV_ZONED
bool "Zoned block device support"
+ select MQ_IOSCHED_DEADLINE
---help---
Block layer zoned block device support. This option enables
support for ZAC/ZBC host-managed and host-aware zoned block devices.
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] block: force select mq-deadline for zoned block devices
2019-06-04 7:23 [PATCH] block: force select mq-deadline for zoned block devices Damien Le Moal
@ 2019-06-11 9:31 ` Damien Le Moal
2019-06-11 16:48 ` Chaitanya Kulkarni
2019-06-12 1:42 ` Ming Lei
2019-06-13 8:35 ` Jens Axboe
2 siblings, 1 reply; 5+ messages in thread
From: Damien Le Moal @ 2019-06-11 9:31 UTC (permalink / raw)
To: linux-block, Jens Axboe; +Cc: Matias Bjorling, Chaitanya Kulkarni
On 2019/06/04 16:23, Damien Le Moal wrote:
> In most use cases of zoned block devices (aka SMR disks), the
> mq-deadline scheduler is mandatory as it implements sequential write
> command processing guarantees with zone write locking. So make sure that
> this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> block/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 1b220101a9cb..2466dcc3ef1d 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY
>
> config BLK_DEV_ZONED
> bool "Zoned block device support"
> + select MQ_IOSCHED_DEADLINE
> ---help---
> Block layer zoned block device support. This option enables
> support for ZAC/ZBC host-managed and host-aware zoned block devices.
>
Ping... Any comment on this one ?
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: force select mq-deadline for zoned block devices
2019-06-11 9:31 ` Damien Le Moal
@ 2019-06-11 16:48 ` Chaitanya Kulkarni
0 siblings, 0 replies; 5+ messages in thread
From: Chaitanya Kulkarni @ 2019-06-11 16:48 UTC (permalink / raw)
To: Damien Le Moal, linux-block, Jens Axboe; +Cc: Matias Bjorling
Looks good to me, I did make sure that when selecting ZBD option
from menuconfig MQ gets selected automatically, from make menuconfig
command.
Tested-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 06/11/2019 02:31 AM, Damien Le Moal wrote:
> On 2019/06/04 16:23, Damien Le Moal wrote:
>> In most use cases of zoned block devices (aka SMR disks), the
>> mq-deadline scheduler is mandatory as it implements sequential write
>> command processing guarantees with zone write locking. So make sure that
>> this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected.
>>
>> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
>> ---
>> block/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/block/Kconfig b/block/Kconfig
>> index 1b220101a9cb..2466dcc3ef1d 100644
>> --- a/block/Kconfig
>> +++ b/block/Kconfig
>> @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY
>>
>> config BLK_DEV_ZONED
>> bool "Zoned block device support"
>> + select MQ_IOSCHED_DEADLINE
>> ---help---
>> Block layer zoned block device support. This option enables
>> support for ZAC/ZBC host-managed and host-aware zoned block devices.
>>
>
> Ping... Any comment on this one ?
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: force select mq-deadline for zoned block devices
2019-06-04 7:23 [PATCH] block: force select mq-deadline for zoned block devices Damien Le Moal
2019-06-11 9:31 ` Damien Le Moal
@ 2019-06-12 1:42 ` Ming Lei
2019-06-13 8:35 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Ming Lei @ 2019-06-12 1:42 UTC (permalink / raw)
To: Damien Le Moal
Cc: linux-block, Jens Axboe, Matias Bjorling, Chaitanya Kulkarni
On Tue, Jun 4, 2019 at 3:24 PM Damien Le Moal <damien.lemoal@wdc.com> wrote:
>
> In most use cases of zoned block devices (aka SMR disks), the
> mq-deadline scheduler is mandatory as it implements sequential write
> command processing guarantees with zone write locking. So make sure that
> this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> block/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 1b220101a9cb..2466dcc3ef1d 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -73,6 +73,7 @@ config BLK_DEV_INTEGRITY
>
> config BLK_DEV_ZONED
> bool "Zoned block device support"
> + select MQ_IOSCHED_DEADLINE
> ---help---
> Block layer zoned block device support. This option enables
> support for ZAC/ZBC host-managed and host-aware zoned block devices.
> --
> 2.21.0
>
Looks fine:
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming Lei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block: force select mq-deadline for zoned block devices
2019-06-04 7:23 [PATCH] block: force select mq-deadline for zoned block devices Damien Le Moal
2019-06-11 9:31 ` Damien Le Moal
2019-06-12 1:42 ` Ming Lei
@ 2019-06-13 8:35 ` Jens Axboe
2 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2019-06-13 8:35 UTC (permalink / raw)
To: Damien Le Moal, linux-block; +Cc: Matias Bjorling, Chaitanya Kulkarni
On 6/4/19 1:23 AM, Damien Le Moal wrote:
> In most use cases of zoned block devices (aka SMR disks), the
> mq-deadline scheduler is mandatory as it implements sequential write
> command processing guarantees with zone write locking. So make sure that
> this scheduler is always enabled if CONFIG_BLK_DEV_ZONED is selected.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-13 16:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 7:23 [PATCH] block: force select mq-deadline for zoned block devices Damien Le Moal
2019-06-11 9:31 ` Damien Le Moal
2019-06-11 16:48 ` Chaitanya Kulkarni
2019-06-12 1:42 ` Ming Lei
2019-06-13 8:35 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).