From: Casey Chen <cachen@purestorage.com>
To: kbusch@kernel.org
Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org, sagi@grimberg.me,
yzhong@purestorage.com
Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq()
Date: Fri, 16 Apr 2021 19:04:34 -0700 [thread overview]
Message-ID: <CALCePG0y1REA8xXX1ymTwAZhrbSyUh41zfpOmFQViuyPGf5ePg@mail.gmail.com> (raw)
> On Fri, Apr 16, 2021 at 10:12:11AM -0700, Yuanyuan Zhong wrote:
> > > if (poll)
> > > nvme_execute_rq_polled(req->q, NULL, req, at_head);
> > You may need to audit other completion handlers for blk_execute_rq_nowait().
>
> Why? Those callers already provide their own callback that directly get
> the error.
We should make sure all callbacks provided to blk_execute_rq_nowait()
carry error back. i.e. by reusing rq->end_io_data.
>
> > How to get error ret from polled rq?
>
> Please see nvme_end_sync_rq() for that driver's polled handler callback.
> It already has the error.
nvme_end_sync_rq() currently doesn't store error in rq->end_io_data as
you proposed in patch 1.
- Casey
next reply other threads:[~2021-04-17 2:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 2:04 Casey Chen [this message]
2021-04-17 2:39 ` [PATCH 2/2] nvme: use return value from blk_execute_rq() Keith Busch
-- strict thread matches above, loose matches on Subject: below --
2021-04-23 21:57 [PATCH 1/2] block: return errors " Keith Busch
2021-04-23 21:58 ` [PATCH 2/2] nvme: use return value " Keith Busch
2021-04-16 16:53 [PATCH 1/2] block: return errors " Keith Busch
2021-04-16 16:53 ` [PATCH 2/2] nvme: use return value " Keith Busch
2021-04-16 17:12 ` Yuanyuan Zhong
2021-04-16 17:17 ` Keith Busch
2021-04-19 7:16 ` Christoph Hellwig
2021-04-19 15:14 ` Keith Busch
2021-04-19 17:27 ` Yuanyuan Zhong
2021-04-19 17:48 ` Keith Busch
2021-04-19 18:20 ` Yuanyuan Zhong
2021-04-18 4:17 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCePG0y1REA8xXX1ymTwAZhrbSyUh41zfpOmFQViuyPGf5ePg@mail.gmail.com \
--to=cachen@purestorage.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).