* [PATCH] dm zoned: remove duplicated nr_rnd_zones increasement
@ 2020-03-22 9:29 Bob Liu
2020-03-23 2:34 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Bob Liu @ 2020-03-22 9:29 UTC (permalink / raw)
To: dm-devel; +Cc: Damien.LeMoal, linux-block, Dmitry.Fomichev, Bob Liu
zmd->nr_rnd_zones was increased twice by mistake.
The other place:
1131 zmd->nr_useable_zones++;
1132 if (dmz_is_rnd(zone)) {
1133 zmd->nr_rnd_zones++;
^^^
Signed-off-by: Bob Liu <bob.liu@oracle.com>
---
drivers/md/dm-zoned-metadata.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index 516c7b6..369de15 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b/drivers/md/dm-zoned-metadata.c
@@ -1109,7 +1109,6 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
switch (blkz->type) {
case BLK_ZONE_TYPE_CONVENTIONAL:
set_bit(DMZ_RND, &zone->flags);
- zmd->nr_rnd_zones++;
break;
case BLK_ZONE_TYPE_SEQWRITE_REQ:
case BLK_ZONE_TYPE_SEQWRITE_PREF:
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dm zoned: remove duplicated nr_rnd_zones increasement
2020-03-22 9:29 [PATCH] dm zoned: remove duplicated nr_rnd_zones increasement Bob Liu
@ 2020-03-23 2:34 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2020-03-23 2:34 UTC (permalink / raw)
To: Bob Liu, dm-devel; +Cc: linux-block, Dmitry Fomichev
On 2020/03/22 18:30, Bob Liu wrote:
> zmd->nr_rnd_zones was increased twice by mistake.
> The other place:
> 1131 zmd->nr_useable_zones++;
> 1132 if (dmz_is_rnd(zone)) {
> 1133 zmd->nr_rnd_zones++;
> ^^^
>
> Signed-off-by: Bob Liu <bob.liu@oracle.com>
Good catch ! But you need to add a Fixes tag and CC stable.
Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
Cc: stable@vger.kernel.org
Other than that, looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/md/dm-zoned-metadata.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
> index 516c7b6..369de15 100644
> --- a/drivers/md/dm-zoned-metadata.c
> +++ b/drivers/md/dm-zoned-metadata.c
> @@ -1109,7 +1109,6 @@ static int dmz_init_zone(struct blk_zone *blkz, unsigned int idx, void *data)
> switch (blkz->type) {
> case BLK_ZONE_TYPE_CONVENTIONAL:
> set_bit(DMZ_RND, &zone->flags);
> - zmd->nr_rnd_zones++;
> break;
> case BLK_ZONE_TYPE_SEQWRITE_REQ:
> case BLK_ZONE_TYPE_SEQWRITE_PREF:
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-23 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 9:29 [PATCH] dm zoned: remove duplicated nr_rnd_zones increasement Bob Liu
2020-03-23 2:34 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).