[PATCH blktests v2] tests/srp/rc, tests/nvmeof-mp/rc: add fio check to group_requires

[PATCH blktests v2] tests/srp/rc, tests/nvmeof-mp/rc: add fio check to group_requires

[Yi Zhang]

Most of the srp and nvmeof-mp tests need fio, we need add fio
check before running the tests

Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
---
v2: update to based on Bart's patch
[PATCH blktests v2] rdma: Use rdma link instead of
/sys/class/infiniband/*/parent
---
 tests/nvmeof-mp/rc | 2 +-
 tests/srp/rc       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/nvmeof-mp/rc b/tests/nvmeof-mp/rc
index 0a12825..dcb2e3c 100755
--- a/tests/nvmeof-mp/rc
+++ b/tests/nvmeof-mp/rc
@@ -42,7 +42,7 @@ and multipathing has been enabled in the nvme_core kernel module"
 	)
 	_have_modules "${required_modules[@]}" || return
 
-	for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof rdma; do
+	for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof rdma fio; do
 		_have_program "$p" || return
 	done
 
diff --git a/tests/srp/rc b/tests/srp/rc
index 2986bfd..586f007 100755
--- a/tests/srp/rc
+++ b/tests/srp/rc
@@ -60,7 +60,7 @@ group_requires() {
 	_have_modules "${required_modules[@]}" || return
 
 	for p in mkfs.ext4 mkfs.xfs multipath multipathd pidof rdma \
-		 sg_reset; do
+		 sg_reset fio; do
 		_have_program "$p" || return
 	done
 
-- 
2.21.0

Re: [PATCH blktests v2] tests/srp/rc, tests/nvmeof-mp/rc: add fio check to group_requires

[Bart Van Assche]

On 3/7/21 8:31 AM, Yi Zhang wrote:
> Most of the srp and nvmeof-mp tests need fio, we need add fio
> check before running the tests

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH blktests v2] tests/srp/rc, tests/nvmeof-mp/rc: add fio check to group_requires

[Omar Sandoval]

On Mon, Mar 08, 2021 at 12:31:42AM +0800, Yi Zhang wrote:
> Most of the srp and nvmeof-mp tests need fio, we need add fio
> check before running the tests
> 
> Signed-off-by: Yi Zhang <yi.zhang@redhat.com>
> ---
> v2: update to based on Bart's patch
> [PATCH blktests v2] rdma: Use rdma link instead of
> /sys/class/infiniband/*/parent
> ---
>  tests/nvmeof-mp/rc | 2 +-
>  tests/srp/rc       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied.