archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <>
To: Zheyu Ma <>
Subject: Re: [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning
Date: Mon, 21 Jun 2021 07:16:07 +0100	[thread overview]
Message-ID: <YNAupxssJ/> (raw)
In-Reply-To: <>

On Sun, Jun 20, 2021 at 12:19:17PM +0000, Zheyu Ma wrote:
> When 'mtip_block_initialize' fails at 'mtip_hw_get_identify', a series
> of cleanup operations will be performed. But when the execution reaches
> 'put_disk', it will cause refcount underflow. The reason for this error
> is that after cleaning 'dd->queue', 'dd->disk->queue' was not set to
> null at the same time, which caused repeated cleanup work.
> Fix this by set 'dd->disk->queue' to null after cleaning

This should all be fixed by the switch to blk_cleanup_disk and the
preparation for it in linux-next.

  reply	other threads:[~2021-06-21  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 12:19 [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning Zheyu Ma
2021-06-21  6:16 ` Christoph Hellwig [this message]
2021-06-21  7:50   ` Zheyu Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNAupxssJ/ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).