* [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument @ 2021-10-20 19:08 Jens Axboe 2021-10-21 8:06 ` Greg KH 2021-10-21 8:32 ` Christoph Hellwig 0 siblings, 2 replies; 17+ messages in thread From: Jens Axboe @ 2021-10-20 19:08 UTC (permalink / raw) To: linux-fsdevel, linux-block, linux-aio, linux-usb The second argument is only used by the USB gadget code, yet everyone pays the overhead of passing a zero to be passed into aio, where it ends up being part of the aio res2 value. Since we pass this value around as long, there's only 32-bits of information in each of these. Linux IO transfers are capped at INT_MAX anyway, so could not be any larger return value. For the one cases where we care about this second result, mask it into the upper bits of the value passed in. aio can then simply shift to get it. For everyone else, just pass in res as an argument like before. Update all ki_complete handlers to conform to the new prototype. On 64-bit, this avoids an extra register allocation and clear for the the fast path (non-USB gadget...). Signed-off-by: Jens Axboe <axboe@kernel.dk> --- diff --git a/block/fops.c b/block/fops.c index d7eff331a07c..53408271771a 100644 --- a/block/fops.c +++ b/block/fops.c @@ -164,7 +164,7 @@ static void blkdev_bio_end_io(struct bio *bio) ret = blk_status_to_errno(dio->bio.bi_status); } - iocb->ki_complete(iocb, ret, 0); + iocb->ki_complete(iocb, ret); if (flags & DIO_MULTI_BIO) bio_put(&dio->bio); } else { @@ -318,7 +318,7 @@ static void blkdev_bio_end_io_async(struct bio *bio) ret = blk_status_to_errno(bio->bi_status); } - iocb->ki_complete(iocb, ret, 0); + iocb->ki_complete(iocb, ret); if (dio->flags & DIO_SHOULD_DIRTY) { bio_check_pages_dirty(bio); diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 8bd288d2b089..3dd5a773c320 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -1076,7 +1076,7 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) af_alg_free_resources(areq); sock_put(sk); - iocb->ki_complete(iocb, err ? err : (int)resultlen, 0); + iocb->ki_complete(iocb, err ? err : (int)resultlen); } EXPORT_SYMBOL_GPL(af_alg_async_cb); diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 397bfafc4c25..66c6e0c5d638 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -550,7 +550,7 @@ static void lo_rw_aio_do_completion(struct loop_cmd *cmd) blk_mq_complete_request(rq); } -static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) +static void lo_rw_aio_complete(struct kiocb *iocb, u64 ret) { struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); @@ -623,7 +623,7 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, lo_rw_aio_do_completion(cmd); if (ret != -EIOCBQUEUED) - cmd->iocb.ki_complete(&cmd->iocb, ret, 0); + lo_rw_aio_complete(&cmd->iocb, ret); return 0; } diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c index 7a249b752f3c..83a2f5b0a3a0 100644 --- a/drivers/nvme/target/io-cmd-file.c +++ b/drivers/nvme/target/io-cmd-file.c @@ -123,7 +123,7 @@ static ssize_t nvmet_file_submit_bvec(struct nvmet_req *req, loff_t pos, return call_iter(iocb, &iter); } -static void nvmet_file_io_done(struct kiocb *iocb, long ret, long ret2) +static void nvmet_file_io_done(struct kiocb *iocb, u64 ret) { struct nvmet_req *req = container_of(iocb, struct nvmet_req, f.iocb); u16 status = NVME_SC_SUCCESS; @@ -220,7 +220,7 @@ static bool nvmet_file_execute_io(struct nvmet_req *req, int ki_flags) } complete: - nvmet_file_io_done(&req->f.iocb, ret, 0); + nvmet_file_io_done(&req->f.iocb, ret); return true; } diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index b471e726bb3d..c4ca7fa18e61 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -245,7 +245,7 @@ struct target_core_file_cmd { struct bio_vec bvecs[]; }; -static void cmd_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) +static void cmd_rw_aio_complete(struct kiocb *iocb, u64 ret) { struct target_core_file_cmd *cmd; @@ -301,7 +301,7 @@ fd_execute_rw_aio(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, ret = call_read_iter(file, &aio_cmd->iocb, &iter); if (ret != -EIOCBQUEUED) - cmd_rw_aio_complete(&aio_cmd->iocb, ret, 0); + cmd_rw_aio_complete(&aio_cmd->iocb, ret); return 0; } diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 8260f38025b7..8536f19d3c9a 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) kthread_unuse_mm(io_data->mm); } - io_data->kiocb->ki_complete(io_data->kiocb, ret, ret); + io_data->kiocb->ki_complete(io_data->kiocb, ((u64) ret << 32) | ret); if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) eventfd_signal(io_data->ffs->ffs_eventfd, 1); diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 539220d7f5b6..d3deb23eb2ab 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -469,7 +469,7 @@ static void ep_user_copy_worker(struct work_struct *work) ret = -EFAULT; /* completing the iocb can drop the ctx and mm, don't touch mm after */ - iocb->ki_complete(iocb, ret, ret); + iocb->ki_complete(iocb, ((u64) ret << 32) | ret); kfree(priv->buf); kfree(priv->to_free); @@ -492,15 +492,16 @@ static void ep_aio_complete(struct usb_ep *ep, struct usb_request *req) * complete the aio request immediately. */ if (priv->to_free == NULL || unlikely(req->actual == 0)) { + u64 aio_ret; + kfree(req->buf); kfree(priv->to_free); kfree(priv); iocb->private = NULL; /* aio_complete() reports bytes-transferred _and_ faults */ - - iocb->ki_complete(iocb, - req->actual ? req->actual : (long)req->status, - req->status); + aio_ret = req->actual ? req->actual : (long)req->status; + aio_ret |= (u64) req->status << 32; + iocb->ki_complete(iocb, aio_ret); } else { /* ep_copy_to_user() won't report both; we hide some faults */ if (unlikely(0 != req->status)) diff --git a/fs/aio.c b/fs/aio.c index 51b08ab01dff..e39c61dccf37 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1417,7 +1417,7 @@ static void aio_remove_iocb(struct aio_kiocb *iocb) spin_unlock_irqrestore(&ctx->ctx_lock, flags); } -static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) +static void aio_complete_rw(struct kiocb *kiocb, u64 res) { struct aio_kiocb *iocb = container_of(kiocb, struct aio_kiocb, rw); @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) file_end_write(kiocb->ki_filp); } - iocb->ki_res.res = res; - iocb->ki_res.res2 = res2; + iocb->ki_res.res = res & 0xffffffff; + iocb->ki_res.res2 = res >> 32; iocb_put(iocb); } @@ -1508,7 +1508,7 @@ static inline void aio_rw_done(struct kiocb *req, ssize_t ret) ret = -EINTR; fallthrough; default: - req->ki_complete(req, ret, 0); + req->ki_complete(req, ret); } } diff --git a/fs/cachefiles/io.c b/fs/cachefiles/io.c index fac2e8e7b533..b2f44ff8eae2 100644 --- a/fs/cachefiles/io.c +++ b/fs/cachefiles/io.c @@ -37,11 +37,11 @@ static inline void cachefiles_put_kiocb(struct cachefiles_kiocb *ki) /* * Handle completion of a read from the cache. */ -static void cachefiles_read_complete(struct kiocb *iocb, long ret, long ret2) +static void cachefiles_read_complete(struct kiocb *iocb, u64 ret) { struct cachefiles_kiocb *ki = container_of(iocb, struct cachefiles_kiocb, iocb); - _enter("%ld,%ld", ret, ret2); + _enter("%llu", (unsigned long long) ret); if (ki->term_func) { if (ret >= 0) @@ -139,7 +139,7 @@ static int cachefiles_read(struct netfs_cache_resources *cres, fallthrough; default: ki->was_async = false; - cachefiles_read_complete(&ki->iocb, ret, 0); + cachefiles_read_complete(&ki->iocb, ret); if (ret > 0) ret = 0; break; @@ -159,12 +159,12 @@ static int cachefiles_read(struct netfs_cache_resources *cres, /* * Handle completion of a write to the cache. */ -static void cachefiles_write_complete(struct kiocb *iocb, long ret, long ret2) +static void cachefiles_write_complete(struct kiocb *iocb, u64 ret) { struct cachefiles_kiocb *ki = container_of(iocb, struct cachefiles_kiocb, iocb); struct inode *inode = file_inode(ki->iocb.ki_filp); - _enter("%ld,%ld", ret, ret2); + _enter("%llu", (unsigned long long) ret); /* Tell lockdep we inherited freeze protection from submission thread */ __sb_writers_acquired(inode->i_sb, SB_FREEZE_WRITE); @@ -244,7 +244,7 @@ static int cachefiles_write(struct netfs_cache_resources *cres, fallthrough; default: ki->was_async = false; - cachefiles_write_complete(&ki->iocb, ret, 0); + cachefiles_write_complete(&ki->iocb, ret); if (ret > 0) ret = 0; break; diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 5c1954ff3a82..41f4ca038191 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1022,7 +1022,7 @@ static void ceph_aio_complete(struct inode *inode, ceph_put_cap_refs(ci, (aio_req->write ? CEPH_CAP_FILE_WR : CEPH_CAP_FILE_RD)); - aio_req->iocb->ki_complete(aio_req->iocb, ret, 0); + aio_req->iocb->ki_complete(aio_req->iocb, ret); ceph_free_cap_flush(aio_req->prealloc_cf); kfree(aio_req); diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 13f3182cf796..1b855fcb179e 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -3184,7 +3184,7 @@ static void collect_uncached_write_data(struct cifs_aio_ctx *ctx) mutex_unlock(&ctx->aio_mutex); if (ctx->iocb && ctx->iocb->ki_complete) - ctx->iocb->ki_complete(ctx->iocb, ctx->rc, 0); + ctx->iocb->ki_complete(ctx->iocb, ctx->rc); else complete(&ctx->done); } @@ -3917,7 +3917,7 @@ collect_uncached_read_data(struct cifs_aio_ctx *ctx) mutex_unlock(&ctx->aio_mutex); if (ctx->iocb && ctx->iocb->ki_complete) - ctx->iocb->ki_complete(ctx->iocb, ctx->rc, 0); + ctx->iocb->ki_complete(ctx->iocb, ctx->rc); else complete(&ctx->done); } diff --git a/fs/direct-io.c b/fs/direct-io.c index 453dcff0e7f5..654443558047 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -307,7 +307,7 @@ static ssize_t dio_complete(struct dio *dio, ssize_t ret, unsigned int flags) if (ret > 0 && dio->op == REQ_OP_WRITE) ret = generic_write_sync(dio->iocb, ret); - dio->iocb->ki_complete(dio->iocb, ret, 0); + dio->iocb->ki_complete(dio->iocb, ret); } kmem_cache_free(dio_cache, dio); diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 11404f8c21c7..e6039f22311b 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -687,7 +687,7 @@ static void fuse_aio_complete(struct fuse_io_priv *io, int err, ssize_t pos) spin_unlock(&fi->lock); } - io->iocb->ki_complete(io->iocb, res, 0); + io->iocb->ki_complete(io->iocb, res); } kref_put(&io->refcnt, fuse_io_release); diff --git a/fs/io_uring.c b/fs/io_uring.c index 5edde3b2f72d..0ed6c199f394 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2672,7 +2672,7 @@ static void __io_complete_rw(struct io_kiocb *req, long res, long res2, __io_req_complete(req, issue_flags, req->result, io_put_rw_kbuf(req)); } -static void io_complete_rw(struct kiocb *kiocb, long res, long res2) +static void io_complete_rw(struct kiocb *kiocb, u64 res) { struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb); @@ -2683,7 +2683,7 @@ static void io_complete_rw(struct kiocb *kiocb, long res, long res2) io_req_task_work_add(req); } -static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2) +static void io_complete_rw_iopoll(struct kiocb *kiocb, u64 res) { struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb); @@ -2891,7 +2891,7 @@ static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret) ret = -EINTR; fallthrough; default: - kiocb->ki_complete(kiocb, ret, 0); + kiocb->ki_complete(kiocb, ret); } } diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 83ecfba53abe..811c898125a5 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -125,7 +125,7 @@ static void iomap_dio_complete_work(struct work_struct *work) struct iomap_dio *dio = container_of(work, struct iomap_dio, aio.work); struct kiocb *iocb = dio->iocb; - iocb->ki_complete(iocb, iomap_dio_complete(dio), 0); + iocb->ki_complete(iocb, iomap_dio_complete(dio)); } /* diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 2e894fec036b..7a5f287c5391 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c @@ -275,7 +275,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) res = (long) dreq->count; WARN_ON_ONCE(dreq->count < 0); } - dreq->iocb->ki_complete(dreq->iocb, res, 0); + dreq->iocb->ki_complete(dreq->iocb, res); } complete(&dreq->completion); diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index c88ac571593d..ff7db16aea2e 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -272,14 +272,14 @@ static void ovl_aio_cleanup_handler(struct ovl_aio_req *aio_req) kmem_cache_free(ovl_aio_request_cachep, aio_req); } -static void ovl_aio_rw_complete(struct kiocb *iocb, long res, long res2) +static void ovl_aio_rw_complete(struct kiocb *iocb, u64 res) { struct ovl_aio_req *aio_req = container_of(iocb, struct ovl_aio_req, iocb); struct kiocb *orig_iocb = aio_req->orig_iocb; ovl_aio_cleanup_handler(aio_req); - orig_iocb->ki_complete(orig_iocb, res, res2); + orig_iocb->ki_complete(orig_iocb, res); } static ssize_t ovl_read_iter(struct kiocb *iocb, struct iov_iter *iter) diff --git a/include/linux/fs.h b/include/linux/fs.h index 31029a91f440..3c809ce2518c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -330,7 +330,7 @@ struct kiocb { randomized_struct_fields_start loff_t ki_pos; - void (*ki_complete)(struct kiocb *iocb, long ret, long ret2); + void (*ki_complete)(struct kiocb *iocb, u64 ret); void *private; int ki_flags; u16 ki_hint; -- Jens Axboe ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-20 19:08 [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument Jens Axboe @ 2021-10-21 8:06 ` Greg KH 2021-10-21 8:32 ` Christoph Hellwig 1 sibling, 0 replies; 17+ messages in thread From: Greg KH @ 2021-10-21 8:06 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-fsdevel, linux-block, linux-aio, linux-usb On Wed, Oct 20, 2021 at 01:08:17PM -0600, Jens Axboe wrote: > The second argument is only used by the USB gadget code, yet everyone > pays the overhead of passing a zero to be passed into aio, where it > ends up being part of the aio res2 value. > > Since we pass this value around as long, there's only 32-bits of > information in each of these. Linux IO transfers are capped at INT_MAX > anyway, so could not be any larger return value. For the one cases where > we care about this second result, mask it into the upper bits of the > value passed in. aio can then simply shift to get it. > > For everyone else, just pass in res as an argument like before. Update > all ki_complete handlers to conform to the new prototype. > > On 64-bit, this avoids an extra register allocation and clear for the > the fast path (non-USB gadget...). > > Signed-off-by: Jens Axboe <axboe@kernel.dk> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-20 19:08 [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument Jens Axboe 2021-10-21 8:06 ` Greg KH @ 2021-10-21 8:32 ` Christoph Hellwig 2021-10-21 10:57 ` Christoph Hellwig 1 sibling, 1 reply; 17+ messages in thread From: Christoph Hellwig @ 2021-10-21 8:32 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-fsdevel, linux-block, linux-aio, linux-usb > @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) > file_end_write(kiocb->ki_filp); > } > > - iocb->ki_res.res = res; > - iocb->ki_res.res2 = res2; > + iocb->ki_res.res = res & 0xffffffff; > + iocb->ki_res.res2 = res >> 32; This needs a big fat comments explaining the historic context. Otherwise this looks fine to me. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 8:32 ` Christoph Hellwig @ 2021-10-21 10:57 ` Christoph Hellwig 2021-10-21 14:34 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Christoph Hellwig @ 2021-10-21 10:57 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-fsdevel, linux-block, linux-aio, linux-usb On Thu, Oct 21, 2021 at 01:32:19AM -0700, Christoph Hellwig wrote: > > @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) > > file_end_write(kiocb->ki_filp); > > } > > > > - iocb->ki_res.res = res; > > - iocb->ki_res.res2 = res2; > > + iocb->ki_res.res = res & 0xffffffff; > > + iocb->ki_res.res2 = res >> 32; > > This needs a big fat comments explaining the historic context. Oh, and please use the upper_32_bits / lower_32_bits helpers. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 10:57 ` Christoph Hellwig @ 2021-10-21 14:34 ` Jens Axboe 2021-10-21 14:42 ` Christoph Hellwig 0 siblings, 1 reply; 17+ messages in thread From: Jens Axboe @ 2021-10-21 14:34 UTC (permalink / raw) To: Christoph Hellwig; +Cc: linux-fsdevel, linux-block, linux-aio, linux-usb On 10/21/21 4:57 AM, Christoph Hellwig wrote: > On Thu, Oct 21, 2021 at 01:32:19AM -0700, Christoph Hellwig wrote: >>> @@ -1436,8 +1436,8 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) >>> file_end_write(kiocb->ki_filp); >>> } >>> >>> - iocb->ki_res.res = res; >>> - iocb->ki_res.res2 = res2; >>> + iocb->ki_res.res = res & 0xffffffff; >>> + iocb->ki_res.res2 = res >> 32; >> >> This needs a big fat comments explaining the historic context. > > Oh, and please use the upper_32_bits / lower_32_bits helpers. Incremental, are you happy with that comment? diff --git a/fs/aio.c b/fs/aio.c index e39c61dccf37..3674abc43788 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1436,8 +1436,14 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) file_end_write(kiocb->ki_filp); } - iocb->ki_res.res = res & 0xffffffff; - iocb->ki_res.res2 = res >> 32; + /* + * Historically we've only had one real user of res2, the USB + * gadget code, everybody else just passes back zero. As we pass + * 32-bits of value at most for either value, bundle these up and + * pass them in one u64 value. + */ + iocb->ki_res.res = lower_32_bits(res); + iocb->ki_res.res2 = upper_32_bits(res); iocb_put(iocb); } -- Jens Axboe ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 14:34 ` Jens Axboe @ 2021-10-21 14:42 ` Christoph Hellwig 2021-10-21 14:44 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Christoph Hellwig @ 2021-10-21 14:42 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On Thu, Oct 21, 2021 at 08:34:38AM -0600, Jens Axboe wrote: > Incremental, are you happy with that comment? Looks fine to me. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 14:42 ` Christoph Hellwig @ 2021-10-21 14:44 ` Jens Axboe 2021-10-21 14:47 ` Christoph Hellwig 2021-10-21 15:18 ` Jeff Moyer 0 siblings, 2 replies; 17+ messages in thread From: Jens Axboe @ 2021-10-21 14:44 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-fsdevel, linux-block, linux-aio, linux-usb, Jeff Moyer On 10/21/21 8:42 AM, Christoph Hellwig wrote: > On Thu, Oct 21, 2021 at 08:34:38AM -0600, Jens Axboe wrote: >> Incremental, are you happy with that comment? > > Looks fine to me. OK good, can I add your ack/review? I can send out a v3 if needed, but seems a bit pointless for that small change. Jeff, are you happy with this one too? commit b676e2079074b06f362a33c1942977fa1b741fcd Author: Jens Axboe <axboe@kernel.dk> Date: Wed Oct 20 10:35:50 2021 -0600 fs: replace the ki_complete two integer arguments with a single argument The second argument is only used by the USB gadget code, yet everyone pays the overhead of passing a zero to be passed into aio, where it ends up being part of the aio res2 value. Since we pass this value around as long, there's only 32-bits of information in each of these. Linux IO transfers are capped at INT_MAX anyway, so could not be any larger return value. For the one cases where we care about this second result, mask it into the upper bits of the value passed in. aio can then simply shift to get it. For everyone else, just pass in res as an argument like before. Update all ki_complete handlers to conform to the new prototype. Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> diff --git a/block/fops.c b/block/fops.c index 49c7fc0085f7..1732617adbf5 100644 --- a/block/fops.c +++ b/block/fops.c @@ -164,7 +164,7 @@ static void blkdev_bio_end_io(struct bio *bio) ret = blk_status_to_errno(dio->bio.bi_status); } - iocb->ki_complete(iocb, ret, 0); + iocb->ki_complete(iocb, ret); if (flags & DIO_MULTI_BIO) bio_put(&dio->bio); } else { @@ -318,7 +318,7 @@ static void blkdev_bio_end_io_async(struct bio *bio) ret = blk_status_to_errno(bio->bi_status); } - iocb->ki_complete(iocb, ret, 0); + iocb->ki_complete(iocb, ret); if (dio->flags & DIO_SHOULD_DIRTY) { bio_check_pages_dirty(bio); diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 8bd288d2b089..3dd5a773c320 100644 --- a/crypto/af_alg.c +++ b/crypto/af_alg.c @@ -1076,7 +1076,7 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) af_alg_free_resources(areq); sock_put(sk); - iocb->ki_complete(iocb, err ? err : (int)resultlen, 0); + iocb->ki_complete(iocb, err ? err : (int)resultlen); } EXPORT_SYMBOL_GPL(af_alg_async_cb); diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 397bfafc4c25..66c6e0c5d638 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -550,7 +550,7 @@ static void lo_rw_aio_do_completion(struct loop_cmd *cmd) blk_mq_complete_request(rq); } -static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) +static void lo_rw_aio_complete(struct kiocb *iocb, u64 ret) { struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); @@ -623,7 +623,7 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, lo_rw_aio_do_completion(cmd); if (ret != -EIOCBQUEUED) - cmd->iocb.ki_complete(&cmd->iocb, ret, 0); + lo_rw_aio_complete(&cmd->iocb, ret); return 0; } diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c index 7a249b752f3c..83a2f5b0a3a0 100644 --- a/drivers/nvme/target/io-cmd-file.c +++ b/drivers/nvme/target/io-cmd-file.c @@ -123,7 +123,7 @@ static ssize_t nvmet_file_submit_bvec(struct nvmet_req *req, loff_t pos, return call_iter(iocb, &iter); } -static void nvmet_file_io_done(struct kiocb *iocb, long ret, long ret2) +static void nvmet_file_io_done(struct kiocb *iocb, u64 ret) { struct nvmet_req *req = container_of(iocb, struct nvmet_req, f.iocb); u16 status = NVME_SC_SUCCESS; @@ -220,7 +220,7 @@ static bool nvmet_file_execute_io(struct nvmet_req *req, int ki_flags) } complete: - nvmet_file_io_done(&req->f.iocb, ret, 0); + nvmet_file_io_done(&req->f.iocb, ret); return true; } diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index b471e726bb3d..c4ca7fa18e61 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c @@ -245,7 +245,7 @@ struct target_core_file_cmd { struct bio_vec bvecs[]; }; -static void cmd_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) +static void cmd_rw_aio_complete(struct kiocb *iocb, u64 ret) { struct target_core_file_cmd *cmd; @@ -301,7 +301,7 @@ fd_execute_rw_aio(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, ret = call_read_iter(file, &aio_cmd->iocb, &iter); if (ret != -EIOCBQUEUED) - cmd_rw_aio_complete(&aio_cmd->iocb, ret, 0); + cmd_rw_aio_complete(&aio_cmd->iocb, ret); return 0; } diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 8260f38025b7..8536f19d3c9a 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) kthread_unuse_mm(io_data->mm); } - io_data->kiocb->ki_complete(io_data->kiocb, ret, ret); + io_data->kiocb->ki_complete(io_data->kiocb, ((u64) ret << 32) | ret); if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) eventfd_signal(io_data->ffs->ffs_eventfd, 1); diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 539220d7f5b6..d3deb23eb2ab 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -469,7 +469,7 @@ static void ep_user_copy_worker(struct work_struct *work) ret = -EFAULT; /* completing the iocb can drop the ctx and mm, don't touch mm after */ - iocb->ki_complete(iocb, ret, ret); + iocb->ki_complete(iocb, ((u64) ret << 32) | ret); kfree(priv->buf); kfree(priv->to_free); @@ -492,15 +492,16 @@ static void ep_aio_complete(struct usb_ep *ep, struct usb_request *req) * complete the aio request immediately. */ if (priv->to_free == NULL || unlikely(req->actual == 0)) { + u64 aio_ret; + kfree(req->buf); kfree(priv->to_free); kfree(priv); iocb->private = NULL; /* aio_complete() reports bytes-transferred _and_ faults */ - - iocb->ki_complete(iocb, - req->actual ? req->actual : (long)req->status, - req->status); + aio_ret = req->actual ? req->actual : (long)req->status; + aio_ret |= (u64) req->status << 32; + iocb->ki_complete(iocb, aio_ret); } else { /* ep_copy_to_user() won't report both; we hide some faults */ if (unlikely(0 != req->status)) diff --git a/fs/aio.c b/fs/aio.c index 51b08ab01dff..3674abc43788 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1417,7 +1417,7 @@ static void aio_remove_iocb(struct aio_kiocb *iocb) spin_unlock_irqrestore(&ctx->ctx_lock, flags); } -static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) +static void aio_complete_rw(struct kiocb *kiocb, u64 res) { struct aio_kiocb *iocb = container_of(kiocb, struct aio_kiocb, rw); @@ -1436,8 +1436,14 @@ static void aio_complete_rw(struct kiocb *kiocb, long res, long res2) file_end_write(kiocb->ki_filp); } - iocb->ki_res.res = res; - iocb->ki_res.res2 = res2; + /* + * Historically we've only had one real user of res2, the USB + * gadget code, everybody else just passes back zero. As we pass + * 32-bits of value at most for either value, bundle these up and + * pass them in one u64 value. + */ + iocb->ki_res.res = lower_32_bits(res); + iocb->ki_res.res2 = upper_32_bits(res); iocb_put(iocb); } @@ -1508,7 +1514,7 @@ static inline void aio_rw_done(struct kiocb *req, ssize_t ret) ret = -EINTR; fallthrough; default: - req->ki_complete(req, ret, 0); + req->ki_complete(req, ret); } } diff --git a/fs/cachefiles/io.c b/fs/cachefiles/io.c index fac2e8e7b533..b2f44ff8eae2 100644 --- a/fs/cachefiles/io.c +++ b/fs/cachefiles/io.c @@ -37,11 +37,11 @@ static inline void cachefiles_put_kiocb(struct cachefiles_kiocb *ki) /* * Handle completion of a read from the cache. */ -static void cachefiles_read_complete(struct kiocb *iocb, long ret, long ret2) +static void cachefiles_read_complete(struct kiocb *iocb, u64 ret) { struct cachefiles_kiocb *ki = container_of(iocb, struct cachefiles_kiocb, iocb); - _enter("%ld,%ld", ret, ret2); + _enter("%llu", (unsigned long long) ret); if (ki->term_func) { if (ret >= 0) @@ -139,7 +139,7 @@ static int cachefiles_read(struct netfs_cache_resources *cres, fallthrough; default: ki->was_async = false; - cachefiles_read_complete(&ki->iocb, ret, 0); + cachefiles_read_complete(&ki->iocb, ret); if (ret > 0) ret = 0; break; @@ -159,12 +159,12 @@ static int cachefiles_read(struct netfs_cache_resources *cres, /* * Handle completion of a write to the cache. */ -static void cachefiles_write_complete(struct kiocb *iocb, long ret, long ret2) +static void cachefiles_write_complete(struct kiocb *iocb, u64 ret) { struct cachefiles_kiocb *ki = container_of(iocb, struct cachefiles_kiocb, iocb); struct inode *inode = file_inode(ki->iocb.ki_filp); - _enter("%ld,%ld", ret, ret2); + _enter("%llu", (unsigned long long) ret); /* Tell lockdep we inherited freeze protection from submission thread */ __sb_writers_acquired(inode->i_sb, SB_FREEZE_WRITE); @@ -244,7 +244,7 @@ static int cachefiles_write(struct netfs_cache_resources *cres, fallthrough; default: ki->was_async = false; - cachefiles_write_complete(&ki->iocb, ret, 0); + cachefiles_write_complete(&ki->iocb, ret); if (ret > 0) ret = 0; break; diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 5c1954ff3a82..41f4ca038191 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1022,7 +1022,7 @@ static void ceph_aio_complete(struct inode *inode, ceph_put_cap_refs(ci, (aio_req->write ? CEPH_CAP_FILE_WR : CEPH_CAP_FILE_RD)); - aio_req->iocb->ki_complete(aio_req->iocb, ret, 0); + aio_req->iocb->ki_complete(aio_req->iocb, ret); ceph_free_cap_flush(aio_req->prealloc_cf); kfree(aio_req); diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 13f3182cf796..1b855fcb179e 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -3184,7 +3184,7 @@ static void collect_uncached_write_data(struct cifs_aio_ctx *ctx) mutex_unlock(&ctx->aio_mutex); if (ctx->iocb && ctx->iocb->ki_complete) - ctx->iocb->ki_complete(ctx->iocb, ctx->rc, 0); + ctx->iocb->ki_complete(ctx->iocb, ctx->rc); else complete(&ctx->done); } @@ -3917,7 +3917,7 @@ collect_uncached_read_data(struct cifs_aio_ctx *ctx) mutex_unlock(&ctx->aio_mutex); if (ctx->iocb && ctx->iocb->ki_complete) - ctx->iocb->ki_complete(ctx->iocb, ctx->rc, 0); + ctx->iocb->ki_complete(ctx->iocb, ctx->rc); else complete(&ctx->done); } diff --git a/fs/direct-io.c b/fs/direct-io.c index 453dcff0e7f5..654443558047 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -307,7 +307,7 @@ static ssize_t dio_complete(struct dio *dio, ssize_t ret, unsigned int flags) if (ret > 0 && dio->op == REQ_OP_WRITE) ret = generic_write_sync(dio->iocb, ret); - dio->iocb->ki_complete(dio->iocb, ret, 0); + dio->iocb->ki_complete(dio->iocb, ret); } kmem_cache_free(dio_cache, dio); diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 11404f8c21c7..e6039f22311b 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -687,7 +687,7 @@ static void fuse_aio_complete(struct fuse_io_priv *io, int err, ssize_t pos) spin_unlock(&fi->lock); } - io->iocb->ki_complete(io->iocb, res, 0); + io->iocb->ki_complete(io->iocb, res); } kref_put(&io->refcnt, fuse_io_release); diff --git a/fs/io_uring.c b/fs/io_uring.c index 5edde3b2f72d..0ed6c199f394 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2672,7 +2672,7 @@ static void __io_complete_rw(struct io_kiocb *req, long res, long res2, __io_req_complete(req, issue_flags, req->result, io_put_rw_kbuf(req)); } -static void io_complete_rw(struct kiocb *kiocb, long res, long res2) +static void io_complete_rw(struct kiocb *kiocb, u64 res) { struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb); @@ -2683,7 +2683,7 @@ static void io_complete_rw(struct kiocb *kiocb, long res, long res2) io_req_task_work_add(req); } -static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2) +static void io_complete_rw_iopoll(struct kiocb *kiocb, u64 res) { struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb); @@ -2891,7 +2891,7 @@ static inline void io_rw_done(struct kiocb *kiocb, ssize_t ret) ret = -EINTR; fallthrough; default: - kiocb->ki_complete(kiocb, ret, 0); + kiocb->ki_complete(kiocb, ret); } } diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index 83ecfba53abe..811c898125a5 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -125,7 +125,7 @@ static void iomap_dio_complete_work(struct work_struct *work) struct iomap_dio *dio = container_of(work, struct iomap_dio, aio.work); struct kiocb *iocb = dio->iocb; - iocb->ki_complete(iocb, iomap_dio_complete(dio), 0); + iocb->ki_complete(iocb, iomap_dio_complete(dio)); } /* diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 2e894fec036b..7a5f287c5391 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c @@ -275,7 +275,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) res = (long) dreq->count; WARN_ON_ONCE(dreq->count < 0); } - dreq->iocb->ki_complete(dreq->iocb, res, 0); + dreq->iocb->ki_complete(dreq->iocb, res); } complete(&dreq->completion); diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index c88ac571593d..ff7db16aea2e 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -272,14 +272,14 @@ static void ovl_aio_cleanup_handler(struct ovl_aio_req *aio_req) kmem_cache_free(ovl_aio_request_cachep, aio_req); } -static void ovl_aio_rw_complete(struct kiocb *iocb, long res, long res2) +static void ovl_aio_rw_complete(struct kiocb *iocb, u64 res) { struct ovl_aio_req *aio_req = container_of(iocb, struct ovl_aio_req, iocb); struct kiocb *orig_iocb = aio_req->orig_iocb; ovl_aio_cleanup_handler(aio_req); - orig_iocb->ki_complete(orig_iocb, res, res2); + orig_iocb->ki_complete(orig_iocb, res); } static ssize_t ovl_read_iter(struct kiocb *iocb, struct iov_iter *iter) diff --git a/include/linux/fs.h b/include/linux/fs.h index 31029a91f440..3c809ce2518c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -330,7 +330,7 @@ struct kiocb { randomized_struct_fields_start loff_t ki_pos; - void (*ki_complete)(struct kiocb *iocb, long ret, long ret2); + void (*ki_complete)(struct kiocb *iocb, u64 ret); void *private; int ki_flags; u16 ki_hint; -- Jens Axboe ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 14:44 ` Jens Axboe @ 2021-10-21 14:47 ` Christoph Hellwig 2021-10-21 15:18 ` Jeff Moyer 1 sibling, 0 replies; 17+ messages in thread From: Christoph Hellwig @ 2021-10-21 14:47 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb, Jeff Moyer On Thu, Oct 21, 2021 at 08:44:16AM -0600, Jens Axboe wrote: > On 10/21/21 8:42 AM, Christoph Hellwig wrote: > > On Thu, Oct 21, 2021 at 08:34:38AM -0600, Jens Axboe wrote: > >> Incremental, are you happy with that comment? > > > > Looks fine to me. > > OK good, can I add your ack/review? I can send out a v3 if needed, but > seems a bit pointless for that small change. Reviewed-by: Christoph Hellwig <hch@lst.de> ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 14:44 ` Jens Axboe 2021-10-21 14:47 ` Christoph Hellwig @ 2021-10-21 15:18 ` Jeff Moyer 2021-10-21 15:19 ` Jens Axboe 1 sibling, 1 reply; 17+ messages in thread From: Jeff Moyer @ 2021-10-21 15:18 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb Jens Axboe <axboe@kernel.dk> writes: > On 10/21/21 8:42 AM, Christoph Hellwig wrote: >> On Thu, Oct 21, 2021 at 08:34:38AM -0600, Jens Axboe wrote: >>> Incremental, are you happy with that comment? >> >> Looks fine to me. > > OK good, can I add your ack/review? I can send out a v3 if needed, but > seems a bit pointless for that small change. > > Jeff, are you happy with this one too? > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > index 397bfafc4c25..66c6e0c5d638 100644 > --- a/drivers/block/loop.c > +++ b/drivers/block/loop.c > @@ -550,7 +550,7 @@ static void lo_rw_aio_do_completion(struct loop_cmd *cmd) > blk_mq_complete_request(rq); > } > > -static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) > +static void lo_rw_aio_complete(struct kiocb *iocb, u64 ret) > { > struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); > > @@ -623,7 +623,7 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, > lo_rw_aio_do_completion(cmd); > > if (ret != -EIOCBQUEUED) > - cmd->iocb.ki_complete(&cmd->iocb, ret, 0); > + lo_rw_aio_complete(&cmd->iocb, ret); > return 0; I'm not sure why that was part of this patch, but I think it's fine. I've still got more testing to do, but you can add: Reviewed-by: Jeff Moyer <jmoyer@redhat.com> I'll follow up if there are issues. Cheers, Jeff ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 15:18 ` Jeff Moyer @ 2021-10-21 15:19 ` Jens Axboe 2021-10-21 18:05 ` Jeff Moyer 0 siblings, 1 reply; 17+ messages in thread From: Jens Axboe @ 2021-10-21 15:19 UTC (permalink / raw) To: Jeff Moyer Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On 10/21/21 9:18 AM, Jeff Moyer wrote: > Jens Axboe <axboe@kernel.dk> writes: > >> On 10/21/21 8:42 AM, Christoph Hellwig wrote: >>> On Thu, Oct 21, 2021 at 08:34:38AM -0600, Jens Axboe wrote: >>>> Incremental, are you happy with that comment? >>> >>> Looks fine to me. >> >> OK good, can I add your ack/review? I can send out a v3 if needed, but >> seems a bit pointless for that small change. >> >> Jeff, are you happy with this one too? > >> diff --git a/drivers/block/loop.c b/drivers/block/loop.c >> index 397bfafc4c25..66c6e0c5d638 100644 >> --- a/drivers/block/loop.c >> +++ b/drivers/block/loop.c >> @@ -550,7 +550,7 @@ static void lo_rw_aio_do_completion(struct loop_cmd *cmd) >> blk_mq_complete_request(rq); >> } >> >> -static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2) >> +static void lo_rw_aio_complete(struct kiocb *iocb, u64 ret) >> { >> struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb); >> >> @@ -623,7 +623,7 @@ static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, >> lo_rw_aio_do_completion(cmd); >> >> if (ret != -EIOCBQUEUED) >> - cmd->iocb.ki_complete(&cmd->iocb, ret, 0); >> + lo_rw_aio_complete(&cmd->iocb, ret); >> return 0; > > I'm not sure why that was part of this patch, but I think it's fine. Yeah, just came across that one, I can drop this part and make it a separate patch. Just a bit dumb to not use the function rather than the indirect call, though maybe the compiler figures it out. > I've still got more testing to do, but you can add: > > Reviewed-by: Jeff Moyer <jmoyer@redhat.com> > > I'll follow up if there are issues. Thanks! -- Jens Axboe ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 15:19 ` Jens Axboe @ 2021-10-21 18:05 ` Jeff Moyer 2021-10-21 20:41 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Jeff Moyer @ 2021-10-21 18:05 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb >> I'll follow up if there are issues. s390 (big endian, 64 bit) is failing libaio test 21: # harness/cases/21.p Expected -EAGAIN, got 4294967285 If I print out both res and res2 using %lx, you'll see what happened: Expected -EAGAIN, got fffffff5,ffffffff The sign extension is being split up. -Jeff ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 18:05 ` Jeff Moyer @ 2021-10-21 20:41 ` Jens Axboe 2021-10-21 20:58 ` Jeff Moyer 0 siblings, 1 reply; 17+ messages in thread From: Jens Axboe @ 2021-10-21 20:41 UTC (permalink / raw) To: Jeff Moyer Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On 10/21/21 12:05 PM, Jeff Moyer wrote: > >>> I'll follow up if there are issues. > > s390 (big endian, 64 bit) is failing libaio test 21: > > # harness/cases/21.p > Expected -EAGAIN, got 4294967285 > > If I print out both res and res2 using %lx, you'll see what happened: > > Expected -EAGAIN, got fffffff5,ffffffff > > The sign extension is being split up. Funky, does it work if you apply this on top? diff --git a/fs/aio.c b/fs/aio.c index 3674abc43788..c56437908339 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) * 32-bits of value at most for either value, bundle these up and * pass them in one u64 value. */ - iocb->ki_res.res = lower_32_bits(res); - iocb->ki_res.res2 = upper_32_bits(res); + iocb->ki_res.res = (long) (res & 0xffffffff); + iocb->ki_res.res2 = (long) (res >> 32); iocb_put(iocb); } -- Jens Axboe ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 20:41 ` Jens Axboe @ 2021-10-21 20:58 ` Jeff Moyer 2021-10-21 21:03 ` Jeff Moyer 0 siblings, 1 reply; 17+ messages in thread From: Jeff Moyer @ 2021-10-21 20:58 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb Jens Axboe <axboe@kernel.dk> writes: > On 10/21/21 12:05 PM, Jeff Moyer wrote: >> >>>> I'll follow up if there are issues. >> >> s390 (big endian, 64 bit) is failing libaio test 21: >> >> # harness/cases/21.p >> Expected -EAGAIN, got 4294967285 >> >> If I print out both res and res2 using %lx, you'll see what happened: >> >> Expected -EAGAIN, got fffffff5,ffffffff >> >> The sign extension is being split up. > > Funky, does it work if you apply this on top? > > diff --git a/fs/aio.c b/fs/aio.c > index 3674abc43788..c56437908339 100644 > --- a/fs/aio.c > +++ b/fs/aio.c > @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) > * 32-bits of value at most for either value, bundle these up and > * pass them in one u64 value. > */ > - iocb->ki_res.res = lower_32_bits(res); > - iocb->ki_res.res2 = upper_32_bits(res); > + iocb->ki_res.res = (long) (res & 0xffffffff); > + iocb->ki_res.res2 = (long) (res >> 32); > iocb_put(iocb); > } I think you'll also need to clamp any ki_complete() call sites to 32 bits (cast to int, or what have you). Otherwise that sign extension will spill over into res2. fwiw, I tested with this: iocb->ki_res.res = (long)(int)lower_32_bits(res); iocb->ki_res.res2 = (long)(int)upper_32_bits(res); Coupled with the call site changes, that made things work for me. -Jeff ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 20:58 ` Jeff Moyer @ 2021-10-21 21:03 ` Jeff Moyer 2021-10-22 14:19 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Jeff Moyer @ 2021-10-21 21:03 UTC (permalink / raw) To: Jens Axboe Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb Jeff Moyer <jmoyer@redhat.com> writes: > Jens Axboe <axboe@kernel.dk> writes: > >> On 10/21/21 12:05 PM, Jeff Moyer wrote: >>> >>>>> I'll follow up if there are issues. >>> >>> s390 (big endian, 64 bit) is failing libaio test 21: >>> >>> # harness/cases/21.p >>> Expected -EAGAIN, got 4294967285 >>> >>> If I print out both res and res2 using %lx, you'll see what happened: >>> >>> Expected -EAGAIN, got fffffff5,ffffffff >>> >>> The sign extension is being split up. >> >> Funky, does it work if you apply this on top? >> >> diff --git a/fs/aio.c b/fs/aio.c >> index 3674abc43788..c56437908339 100644 >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) >> * 32-bits of value at most for either value, bundle these up and >> * pass them in one u64 value. >> */ >> - iocb->ki_res.res = lower_32_bits(res); >> - iocb->ki_res.res2 = upper_32_bits(res); >> + iocb->ki_res.res = (long) (res & 0xffffffff); >> + iocb->ki_res.res2 = (long) (res >> 32); >> iocb_put(iocb); >> } > > I think you'll also need to clamp any ki_complete() call sites to 32 > bits (cast to int, or what have you). Otherwise that sign extension > will spill over into res2. > > fwiw, I tested with this: > > iocb->ki_res.res = (long)(int)lower_32_bits(res); > iocb->ki_res.res2 = (long)(int)upper_32_bits(res); > > Coupled with the call site changes, that made things work for me. This is all starting to feel like a minefield. If you don't have any concrete numbers to show that there is a speedup, I think we should shelf this change. -Jeff ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-21 21:03 ` Jeff Moyer @ 2021-10-22 14:19 ` Jens Axboe 2021-10-22 15:29 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Jens Axboe @ 2021-10-22 14:19 UTC (permalink / raw) To: Jeff Moyer Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On 10/21/21 3:03 PM, Jeff Moyer wrote: > Jeff Moyer <jmoyer@redhat.com> writes: > >> Jens Axboe <axboe@kernel.dk> writes: >> >>> On 10/21/21 12:05 PM, Jeff Moyer wrote: >>>> >>>>>> I'll follow up if there are issues. >>>> >>>> s390 (big endian, 64 bit) is failing libaio test 21: >>>> >>>> # harness/cases/21.p >>>> Expected -EAGAIN, got 4294967285 >>>> >>>> If I print out both res and res2 using %lx, you'll see what happened: >>>> >>>> Expected -EAGAIN, got fffffff5,ffffffff >>>> >>>> The sign extension is being split up. >>> >>> Funky, does it work if you apply this on top? >>> >>> diff --git a/fs/aio.c b/fs/aio.c >>> index 3674abc43788..c56437908339 100644 >>> --- a/fs/aio.c >>> +++ b/fs/aio.c >>> @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) >>> * 32-bits of value at most for either value, bundle these up and >>> * pass them in one u64 value. >>> */ >>> - iocb->ki_res.res = lower_32_bits(res); >>> - iocb->ki_res.res2 = upper_32_bits(res); >>> + iocb->ki_res.res = (long) (res & 0xffffffff); >>> + iocb->ki_res.res2 = (long) (res >> 32); >>> iocb_put(iocb); >>> } >> >> I think you'll also need to clamp any ki_complete() call sites to 32 >> bits (cast to int, or what have you). Otherwise that sign extension >> will spill over into res2. >> >> fwiw, I tested with this: >> >> iocb->ki_res.res = (long)(int)lower_32_bits(res); >> iocb->ki_res.res2 = (long)(int)upper_32_bits(res); >> >> Coupled with the call site changes, that made things work for me. > > This is all starting to feel like a minefield. If you don't have any > concrete numbers to show that there is a speedup, I think we should > shelf this change. It's really not a minefield at all, we just need a proper help to encode the value. I'm out until Tuesday, but I'll sort it out when I get back. Can also provide some numbers on this. -- Jens Axboe ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-22 14:19 ` Jens Axboe @ 2021-10-22 15:29 ` Jens Axboe 2021-10-22 15:47 ` Jens Axboe 0 siblings, 1 reply; 17+ messages in thread From: Jens Axboe @ 2021-10-22 15:29 UTC (permalink / raw) To: Jeff Moyer Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On 10/22/21 8:19 AM, Jens Axboe wrote: > On 10/21/21 3:03 PM, Jeff Moyer wrote: >> Jeff Moyer <jmoyer@redhat.com> writes: >> >>> Jens Axboe <axboe@kernel.dk> writes: >>> >>>> On 10/21/21 12:05 PM, Jeff Moyer wrote: >>>>> >>>>>>> I'll follow up if there are issues. >>>>> >>>>> s390 (big endian, 64 bit) is failing libaio test 21: >>>>> >>>>> # harness/cases/21.p >>>>> Expected -EAGAIN, got 4294967285 >>>>> >>>>> If I print out both res and res2 using %lx, you'll see what happened: >>>>> >>>>> Expected -EAGAIN, got fffffff5,ffffffff >>>>> >>>>> The sign extension is being split up. >>>> >>>> Funky, does it work if you apply this on top? >>>> >>>> diff --git a/fs/aio.c b/fs/aio.c >>>> index 3674abc43788..c56437908339 100644 >>>> --- a/fs/aio.c >>>> +++ b/fs/aio.c >>>> @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) >>>> * 32-bits of value at most for either value, bundle these up and >>>> * pass them in one u64 value. >>>> */ >>>> - iocb->ki_res.res = lower_32_bits(res); >>>> - iocb->ki_res.res2 = upper_32_bits(res); >>>> + iocb->ki_res.res = (long) (res & 0xffffffff); >>>> + iocb->ki_res.res2 = (long) (res >> 32); >>>> iocb_put(iocb); >>>> } >>> >>> I think you'll also need to clamp any ki_complete() call sites to 32 >>> bits (cast to int, or what have you). Otherwise that sign extension >>> will spill over into res2. >>> >>> fwiw, I tested with this: >>> >>> iocb->ki_res.res = (long)(int)lower_32_bits(res); >>> iocb->ki_res.res2 = (long)(int)upper_32_bits(res); >>> >>> Coupled with the call site changes, that made things work for me. >> >> This is all starting to feel like a minefield. If you don't have any >> concrete numbers to show that there is a speedup, I think we should >> shelf this change. > > It's really not a minefield at all, we just need a proper help to encode > the value. I'm out until Tuesday, but I'll sort it out when I get back. > Can also provide some numbers on this. I think this incremental should fix it, also providing a helper to properly pack these. The more I look at the gadget stuff the more I also get the feeling that it really is wonky and nobody uses res2, which would be a nice cleanup to continue. But I think it should be separate. diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 8536f19d3c9a..9c5372229714 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -831,7 +831,7 @@ static void ffs_user_copy_worker(struct work_struct *work) kthread_unuse_mm(io_data->mm); } - io_data->kiocb->ki_complete(io_data->kiocb, ((u64) ret << 32) | ret); + io_data->kiocb->ki_complete(io_data->kiocb, aio_res_pack(ret, ret)); if (io_data->ffs->ffs_eventfd && !kiocb_has_eventfd) eventfd_signal(io_data->ffs->ffs_eventfd, 1); diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index d3deb23eb2ab..15dff219b483 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c @@ -469,7 +469,7 @@ static void ep_user_copy_worker(struct work_struct *work) ret = -EFAULT; /* completing the iocb can drop the ctx and mm, don't touch mm after */ - iocb->ki_complete(iocb, ((u64) ret << 32) | ret); + iocb->ki_complete(iocb, aio_res_pack(ret, ret)); kfree(priv->buf); kfree(priv->to_free); @@ -499,8 +499,10 @@ static void ep_aio_complete(struct usb_ep *ep, struct usb_request *req) kfree(priv); iocb->private = NULL; /* aio_complete() reports bytes-transferred _and_ faults */ - aio_ret = req->actual ? req->actual : (long)req->status; - aio_ret |= (u64) req->status << 32; + if (req->actual) + aio_ret = aio_res_pack(req->actual, req->status); + else + aio_ret = aio_res_pack(req->status, req->status); iocb->ki_complete(iocb, aio_ret); } else { /* ep_copy_to_user() won't report both; we hide some faults */ diff --git a/fs/aio.c b/fs/aio.c index 3674abc43788..cd43a26b2aa2 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) * 32-bits of value at most for either value, bundle these up and * pass them in one u64 value. */ - iocb->ki_res.res = lower_32_bits(res); - iocb->ki_res.res2 = upper_32_bits(res); + iocb->ki_res.res = (long) lower_32_bits(res); + iocb->ki_res.res2 = (long) upper_32_bits(res); iocb_put(iocb); } diff --git a/include/linux/aio.h b/include/linux/aio.h index b83e68dd006f..50a6c7da27ec 100644 --- a/include/linux/aio.h +++ b/include/linux/aio.h @@ -24,4 +24,18 @@ static inline void kiocb_set_cancel_fn(struct kiocb *req, extern unsigned long aio_nr; extern unsigned long aio_max_nr; +/* + * Take some care packing two 32-bit quantities into a 64-bit, so we don't + * get sign extensions ruining the result. aio uses long, but it's really + * just 32-bit values. + */ +static inline u64 aio_res_pack(long res, long res2) +{ + u64 ret; + + ret = (u64) res2 << 32; + ret |= (u32) res; + return ret; +} + #endif /* __LINUX__AIO_H */ -- Jens Axboe ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument 2021-10-22 15:29 ` Jens Axboe @ 2021-10-22 15:47 ` Jens Axboe 0 siblings, 0 replies; 17+ messages in thread From: Jens Axboe @ 2021-10-22 15:47 UTC (permalink / raw) To: Jeff Moyer Cc: Christoph Hellwig, linux-fsdevel, linux-block, linux-aio, linux-usb On 10/22/21 9:29 AM, Jens Axboe wrote: > On 10/22/21 8:19 AM, Jens Axboe wrote: >> On 10/21/21 3:03 PM, Jeff Moyer wrote: >>> Jeff Moyer <jmoyer@redhat.com> writes: >>> >>>> Jens Axboe <axboe@kernel.dk> writes: >>>> >>>>> On 10/21/21 12:05 PM, Jeff Moyer wrote: >>>>>> >>>>>>>> I'll follow up if there are issues. >>>>>> >>>>>> s390 (big endian, 64 bit) is failing libaio test 21: >>>>>> >>>>>> # harness/cases/21.p >>>>>> Expected -EAGAIN, got 4294967285 >>>>>> >>>>>> If I print out both res and res2 using %lx, you'll see what happened: >>>>>> >>>>>> Expected -EAGAIN, got fffffff5,ffffffff >>>>>> >>>>>> The sign extension is being split up. >>>>> >>>>> Funky, does it work if you apply this on top? >>>>> >>>>> diff --git a/fs/aio.c b/fs/aio.c >>>>> index 3674abc43788..c56437908339 100644 >>>>> --- a/fs/aio.c >>>>> +++ b/fs/aio.c >>>>> @@ -1442,8 +1442,8 @@ static void aio_complete_rw(struct kiocb *kiocb, u64 res) >>>>> * 32-bits of value at most for either value, bundle these up and >>>>> * pass them in one u64 value. >>>>> */ >>>>> - iocb->ki_res.res = lower_32_bits(res); >>>>> - iocb->ki_res.res2 = upper_32_bits(res); >>>>> + iocb->ki_res.res = (long) (res & 0xffffffff); >>>>> + iocb->ki_res.res2 = (long) (res >> 32); >>>>> iocb_put(iocb); >>>>> } >>>> >>>> I think you'll also need to clamp any ki_complete() call sites to 32 >>>> bits (cast to int, or what have you). Otherwise that sign extension >>>> will spill over into res2. >>>> >>>> fwiw, I tested with this: >>>> >>>> iocb->ki_res.res = (long)(int)lower_32_bits(res); >>>> iocb->ki_res.res2 = (long)(int)upper_32_bits(res); >>>> >>>> Coupled with the call site changes, that made things work for me. >>> >>> This is all starting to feel like a minefield. If you don't have any >>> concrete numbers to show that there is a speedup, I think we should >>> shelf this change. >> >> It's really not a minefield at all, we just need a proper help to encode >> the value. I'm out until Tuesday, but I'll sort it out when I get back. >> Can also provide some numbers on this. > > I think this incremental should fix it, also providing a helper to > properly pack these. The more I look at the gadget stuff the more I also > get the feeling that it really is wonky and nobody uses res2, which > would be a nice cleanup to continue. But I think it should be separate. For the record, deferring all of this until next week when I'm back. I'll pick it back up then, obviously this isn't an urgent thing at all, would just love to sort out the useless argument going down the line. We'd need to pack all of them, not just the odd ones out. -- Jens Axboe ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-10-22 15:47 UTC | newest] Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-10-20 19:08 [PATCH v2] fs: replace the ki_complete two integer arguments with a single argument Jens Axboe 2021-10-21 8:06 ` Greg KH 2021-10-21 8:32 ` Christoph Hellwig 2021-10-21 10:57 ` Christoph Hellwig 2021-10-21 14:34 ` Jens Axboe 2021-10-21 14:42 ` Christoph Hellwig 2021-10-21 14:44 ` Jens Axboe 2021-10-21 14:47 ` Christoph Hellwig 2021-10-21 15:18 ` Jeff Moyer 2021-10-21 15:19 ` Jens Axboe 2021-10-21 18:05 ` Jeff Moyer 2021-10-21 20:41 ` Jens Axboe 2021-10-21 20:58 ` Jeff Moyer 2021-10-21 21:03 ` Jeff Moyer 2021-10-22 14:19 ` Jens Axboe 2021-10-22 15:29 ` Jens Axboe 2021-10-22 15:47 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).