* [PATCH] block: replace always false argument with 'false'
@ 2021-11-01 19:42 Jens Axboe
2021-11-02 0:26 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2021-11-01 19:42 UTC (permalink / raw)
To: linux-block; +Cc: Ming Lei
A previous commit fixed up the condition for doing direct issue, but that
left the 'from_schedule' argument dead inside the branch. Replace it with
'false'.
Fixes: ff1552232b36 ("blk-mq: don't issue request directly in case that current is to be blocked")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4787d5b74aa3..8aed6cea3a34 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -2227,7 +2227,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
plug->rq_count = 0;
if (!plug->multiple_queues && !plug->has_elevator && !from_schedule) {
- blk_mq_plug_issue_direct(plug, from_schedule);
+ blk_mq_plug_issue_direct(plug, false);
if (rq_list_empty(plug->mq_list))
return;
}
--
Jens Axboe
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: replace always false argument with 'false'
2021-11-01 19:42 [PATCH] block: replace always false argument with 'false' Jens Axboe
@ 2021-11-02 0:26 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2021-11-02 0:26 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block
On Mon, Nov 01, 2021 at 01:42:16PM -0600, Jens Axboe wrote:
> A previous commit fixed up the condition for doing direct issue, but that
> left the 'from_schedule' argument dead inside the branch. Replace it with
> 'false'.
>
> Fixes: ff1552232b36 ("blk-mq: don't issue request directly in case that current is to be blocked")
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 4787d5b74aa3..8aed6cea3a34 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -2227,7 +2227,7 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule)
> plug->rq_count = 0;
>
> if (!plug->multiple_queues && !plug->has_elevator && !from_schedule) {
> - blk_mq_plug_issue_direct(plug, from_schedule);
> + blk_mq_plug_issue_direct(plug, false);
> if (rq_list_empty(plug->mq_list))
> return;
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-02 0:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-01 19:42 [PATCH] block: replace always false argument with 'false' Jens Axboe
2021-11-02 0:26 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).