Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] floppy: remove redundant assignment to variable st
       [not found] <20210415130020.1959951-1-colin.king@canonical.com>
@ 2021-04-16 12:29 ` Denis Efremov
  2021-04-16 12:30   ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2021-04-16 12:29 UTC (permalink / raw)
  To: Jens Axboe
  Cc: kernel-janitors, linux-kernel, Colin King, Willy Tarreau,
	linux-block, Linux Kernel Mailing List

Jens, could you please take this one? I thought to send it to you with other
cleanup patches in a merge request, but you already applied rest of the
patches. If you prefer to take it as merge request, it's ok I'll send it
based on your branch for-5.13/drivers.

On 4/15/21 4:00 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable st is being assigned a value that is never read and
> it is being updated later with a new value. The initialization is
> redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Denis Efremov <efremov@linux.com>

Thanks,
Denis

> ---
>  arch/x86/include/asm/floppy.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
> index d43717b423cb..6ec3fc969ad5 100644
> --- a/arch/x86/include/asm/floppy.h
> +++ b/arch/x86/include/asm/floppy.h
> @@ -74,7 +74,6 @@ static irqreturn_t floppy_hardint(int irq, void *dev_id)
>  		int lcount;
>  		char *lptr;
>  
> -		st = 1;
>  		for (lcount = virtual_dma_count, lptr = virtual_dma_addr;
>  		     lcount; lcount--, lptr++) {
>  			st = inb(virtual_dma_port + FD_STATUS);
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] floppy: remove redundant assignment to variable st
  2021-04-16 12:29 ` [PATCH] floppy: remove redundant assignment to variable st Denis Efremov
@ 2021-04-16 12:30   ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-04-16 12:30 UTC (permalink / raw)
  To: Denis Efremov
  Cc: kernel-janitors, linux-kernel, Colin King, Willy Tarreau, linux-block

On 4/16/21 6:29 AM, Denis Efremov wrote:
> Jens, could you please take this one? I thought to send it to you with other
> cleanup patches in a merge request, but you already applied rest of the
> patches. If you prefer to take it as merge request, it's ok I'll send it
> based on your branch for-5.13/drivers.

I have applied it, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210415130020.1959951-1-colin.king@canonical.com>
2021-04-16 12:29 ` [PATCH] floppy: remove redundant assignment to variable st Denis Efremov
2021-04-16 12:30   ` Jens Axboe

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git