* Re:question about request merge
[not found] <tencent_2DB1C4E822C7BE2363B8A451@qq.com>
@ 2018-04-20 3:51 ` Zhengyuan Liu
2018-04-20 14:34 ` question " Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Zhengyuan Liu @ 2018-04-20 3:51 UTC (permalink / raw)
To: shli; +Cc: linux-block, axboe
SGksIFNoYW9odWENCg0KSSBmb3VuZCBpdCBpbmRlZWQgZG9lc24ndCBkbyBmcm9udCBtZXJn
ZSB3aGVuIHR3byB0aHJlYWRzIGZsdXNoIHBsdWcgbGlzdCAgY29uY3VycmVudGx5LiAgIFRv
IA0KcmVhcHBlYXIgLCBJIHByZXBhcmVkIHR3byBJTyB0aHJlYWRzICwgbmFtZWQgYTAuaW8g
YW5kIGExLmlvIC4NClRocmVhZCBhMS5pbyAgdXNlcyBsaWJhaW8gdG8gd3JpdGUgNSByZXF1
ZXN0cyA6IA0KICAgIHNlY3RvcnM6IDE2ICsgOCwgNDAgKyA4LCA2NCArIDgsIDg4ICsgOCwg
MTEyICsgOA0KVGhyZWFkIGEwLmlvICB1c2VzIGxpYmFpbyB0byB3cml0ZSBvdGhlciA1IHJl
cXVlc3RzIDogDQogICAgc2VjdG9yczogOCsgOCwgMzIgKyA4LCA1NiArIDgsIDgwICsgOCwg
MTA0ICsgOA0KDQpUbyBtZWV0IHRoZSBjb25kaXRpb24gdGhhdCB0aHJlYWQgYTEuaW8gZmx1
c2ggYWxsIGl0cyByZXF1ZXN0cyB0byBxdWV1ZWUgYmVmb3JlICB0aHJlYWQgYTAuaW8NCmRv
ZXMsIEkgZGVsYXkgdGhyZWFkIGExLmlvIHRvIHJ1biBxdWV1ZSBhZnRlciBpdCBhZGRzIGFs
bCBwbHVnZWQgcmVxdWVzdHMgdG8gcXVldWUsICBzZWVpbmcNCmJlbGxvdyBwYXRjaDoNCg0K
LS0tIGEvYmxvY2svYmxrLWNvcmUuYw0KKysrIGIvYmxvY2svYmxrLWNvcmUuYw0KQEAgLTMz
MjQsNiArMzMyNCwyMSBAQCB2b2lkIGJsa19mbHVzaF9wbHVnX2xpc3Qoc3RydWN0IGJsa19w
bHVnICpwbHVnLCBib29sIGZyb21fc2NoZWR1bGUpDQogICAgICAgIC8qDQogICAgICAgICAq
IFRoaXMgZHJvcHMgdGhlIHF1ZXVlIGxvY2sNCiAgICAgICAgICovDQorDQorICAgICAgICAg
ICBpZiAoc3RyY21wKGN1cnJlbnQtPmNvbW0sICJhMS5pbyIpID09IDApDQorICAgICAgICAg
ICB7DQorICAgICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycShxLT5xdWV1ZV9sb2Nr
KTsgDQorICAgICAgICAgICAgICAgICAgIG1kZWxheSgyMDAwKTsNCisgICAgICAgICAgICAg
ICAgICAgc3Bpbl9sb2NrX2lycShxLT5xdWV1ZV9sb2NrKTsgICANCisgICAgICAgICAgIH0N
CiANClRoZW4gSSB1c2VkICAgIiAuL2ExLmlvICYgc2xlZXAgMSAmJiAuL2EwLmlvICIgdG8g
ZGlzcGF0Y2ggdGhlIElPIG9wZXJhdGlvbiBhbmQgdXNlZCBibGt0cmFjZSB0bw0KdHJhY2Ug
dGhlIElPIHByb2Nlc3NpbmcsICB0aGUgdHJhY2UgcmVzdWx0IHdhcyBzaG93ZWQgYmVsbG93
Og0KDQogICAgICA4LDE2ICAgMSAgICAgIDE3NCAgIDE3Ni43MzM4ODAxNjAgIDEyMTcgIFEg
IFdTIDE2ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMSAgICAgIDE3NSAgIDE3Ni43MzM4
ODUzMDAgIDEyMTcgIEcgIFdTIDE2ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMSAgICAg
IDE3NyAgIDE3Ni43MzM4OTA4MjAgIDEyMTcgIFEgIFdTIDQwICsgOCBbYTEuaW9dDQogICAg
ICA4LDE2ICAgMSAgICAgIDE3OCAgIDE3Ni43MzM4OTI0NjAgIDEyMTcgIEcgIFdTIDQwICsg
OCBbYTEuaW9dDQogICAgICA4LDE2ICAgMSAgICAgIDE3OSAgIDE3Ni43MzM4OTYzODAgIDEy
MTcgIFEgIFdTIDY0ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMSAgICAgIDE4MCAgIDE3
Ni43MzM4OTc5MDAgIDEyMTcgIEcgIFdTIDY0ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAg
MSAgICAgIDE4MSAgIDE3Ni43MzM5MDEyNjAgIDEyMTcgIFEgIFdTIDg4ICsgOCBbYTEuaW9d
DQogICAgICA4LDE2ICAgMSAgICAgIDE4MiAgIDE3Ni43MzM5MDI3NjAgIDEyMTcgIEcgIFdT
IDg4ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMSAgICAgIDE4MyAgIDE3Ni43MzM5MDYy
MDAgIDEyMTcgIFEgIFdTIDExMiArIDggW2ExLmlvXQ0KICAgICAgOCwxNiAgIDEgICAgICAx
ODQgICAxNzYuNzMzOTA3NjQwICAxMjE3ICBHICBXUyAxMTIgKyA4IFthMS5pb10NCiAgICAg
IDgsMTYgICAxICAgICAgMTg1ICAgMTc2LjczMzkwOTU2MCAgMTIxNyAgSSAgV1MgMTYgKyA4
IFthMS5pb10NCiAgICAgIDgsMTYgICAxICAgICAgMTg2ICAgMTc2LjczMzkyNTQ4MCAgMTIx
NyAgSSAgV1MgNDAgKyA4IFthMS5pb10NCiAgICAgIDgsMTYgICAxICAgICAgMTg3ICAgMTc2
LjczMzkzNjU2MCAgMTIxNyAgSSAgV1MgNjQgKyA4IFthMS5pb10NCiAgICAgIDgsMTYgICAx
ICAgICAgMTg4ICAgMTc2LjczMzk0NTkyMCAgMTIxNyAgSSAgV1MgODggKyA4IFthMS5pb10N
CiAgICAgIDgsMTYgICAxICAgICAgMTg5ICAgMTc2LjczMzk1Mzg4MCAgMTIxNyAgSSAgV1Mg
MTEyICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDEwMyAgIDE3Ni43MzQzMTcw
ODAgIDEyMTggIFEgIFdTIDggKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAyICAgICAgMTA0
ICAgMTc2LjczNDMyMDYwMCAgMTIxOCAgRyAgV1MgOCArIDggW2EwLmlvXQ0KICAgICAgOCwx
NiAgIDIgICAgICAxMDYgICAxNzYuNzM0MzI1NTIwICAxMjE4ICBRICBXUyAzMiArIDggW2Ew
LmlvXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMDcgICAxNzYuNzM0MzI3MTQwICAxMjE4ICBH
ICBXUyAzMiArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMDggICAxNzYuNzM0
MzMwNjIwICAxMjE4ICBRICBXUyA1NiArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDIgICAg
ICAxMDkgICAxNzYuNzM0MzMyMTQwICAxMjE4ICBHICBXUyA1NiArIDggW2EwLmlvXQ0KICAg
ICAgOCwxNiAgIDIgICAgICAxMTAgICAxNzYuNzM0MzM1MzgwICAxMjE4ICBRICBXUyA4MCAr
IDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMTEgICAxNzYuNzM0MzM2NzYwICAx
MjE4ICBHICBXUyA4MCArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMTIgICAx
NzYuNzM0MzQwMzAwICAxMjE4ICBRICBXUyAxMDQgKyA4IFthMC5pb10NCiAgICAgIDgsMTYg
ICAyICAgICAgMTEzICAgMTc2LjczNDM0MTkwMCAgMTIxOCAgRyAgV1MgMTA0ICsgOCBbYTAu
aW9dDQogICAgICA4LDE2ICAgMiAgICAgIDExNCAgIDE3Ni43MzQzNDM1MjAgIDEyMTggIEkg
IFdTIDggKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAyICAgICAgMTE1ICAgMTc2LjczNDM1
NzI4MCAgMTIxOCAgSSAgV1MgMzIgKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAyICAgICAg
MTE2ICAgMTc2LjczNDM2NjU2MCAgMTIxOCAgSSAgV1MgNTYgKyA4IFthMC5pb10NCiAgICAg
IDgsMTYgICAyICAgICAgMTE3ICAgMTc2LjczNDM3NDgwMCAgMTIxOCAgSSAgV1MgODAgKyA4
IFthMC5pb10NCiAgICAgIDgsMTYgICAyICAgICAgMTE4ICAgMTc2LjczNDM4MjQ2MCAgMTIx
OCAgSSAgV1MgMTA0ICsgOCBbYTAuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDEyMCAgIDE3
Ni43MzgwMTI5NjAgIDEyMTggIEQgIFdTIDExMiArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAg
IDAgICAgICAxNTEgICAxNzYuNzQwOTIzMjAwICAgICAzICBDICBXUyAxMTIgKyA4IFswXQ0K
ICAgICAgOCwxNiAgIDIgICAgICAxMjEgICAxNzYuNzQxODA0OTYwICAxMjE4ICBEICBXUyA4
OCArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMjIgICAxNzYuNzQxODI2MDYw
ICAxMjE4ICBSICBXUyA4OCArIDggWzBdDQogICAgICA4LDE2ICAgMiAgICAgIDEyMyAgIDE3
Ni43NDE4Mjc3NDAgIDEyMTggIEkgIFdTIDg4ICsgOCBbYTAuaW9dDQogICAgICA4LDE2ICAg
MCAgICAgIDE1MiAgIDE3Ni43NDUyNTkwODAgICAgIDMgIEQgIFdTIDg4ICsgOCBba3NvZnRp
cnFkLzBdDQogICAgICA4LDE2ICAgMCAgICAgIDE1MyAgIDE3Ni43NDc4MjQzODAgICAgIDMg
IEQgIFdTIDY0ICsgOCBba3NvZnRpcnFkLzBdDQogICAgICA4LDE2ICAgMCAgICAgIDE1NCAg
IDE3Ni43NDg5MjEyMjAgICAgIDMgIEMgIFdTIDg4ICsgOCBbMF0NCiAgICAgIDgsMTYgICAw
ICAgICAgMTU1ICAgMTc2Ljc1MTQ3MjY0MCAgICAgMyAgRCAgV1MgNDAgKyA4IFtrc29mdGly
cWQvMF0NCiAgICAgIDgsMTYgICAwICAgICAgMTU2ICAgMTc2Ljc1MzE3MjUwMCAgICAgMyAg
QyAgV1MgNjQgKyA4IFswXQ0KICAgICAgOCwxNiAgIDAgICAgICAxNTcgICAxNzYuNzU1NzIw
NzQwICAgICAzICBEICBXUyAxNiArIDggW2tzb2Z0aXJxZC8wXQ0KICAgICAgOCwxNiAgIDAg
ICAgICAxNTggICAxNzYuNzU3OTIwNzgwICAgICAzICBDICBXUyA0MCArIDggWzBdDQogICAg
ICA4LDE2ICAgMCAgICAgIDE1OSAgIDE3Ni43NjA0NzEzMjAgICAgIDMgIEQgIFdTIDEwNCAr
IDggW2tzb2Z0aXJxZC8wXQ0KICAgICAgOCwxNiAgIDAgICAgICAxNjAgICAxNzYuNzYzMTcy
MTgwICAgICAzICBDICBXUyAxNiArIDggWzBdDQogICAgICA4LDE2ICAgMCAgICAgIDE2MSAg
IDE3Ni43NjU3MTc1NjAgICAgIDMgIEQgIFdTIDgwICsgOCBba3NvZnRpcnFkLzBdDQogICAg
ICA4LDE2ICAgMCAgICAgIDE2MiAgIDE3Ni43NjY3OTU0MDAgICAgIDMgIEMgIFdTIDEwNCAr
IDggWzBdDQogICAgICA4LDE2ICAgMCAgICAgIDE2MyAgIDE3Ni43NjkzNDEwMjAgICAgIDMg
IEQgIFdTIDU2ICsgOCBba3NvZnRpcnFkLzBdDQogICAgICA4LDE2ICAgMiAgICAgIDEyNCAg
IDE3Ni43NzA5MjYzODAgICAgMTggIEMgIFdTIDgwICsgOCBbMF0NCiAgICAgIDgsMTYgICAw
ICAgICAgMTY0ICAgMTc2Ljc3NDMzNTY0MCAgIDkyNCAgQyAgV1MgNTYgKyA4IFswXQ0KICAg
ICAgOCwxNiAgIDIgICAgICAxMjUgICAxNzYuNzc0NjQyMTQwICAgIDE4ICBEICBXUyAzMiAr
IDggW2tzb2Z0aXJxZC8yXQ0KICAgICAgOCwxNiAgIDIgICAgICAxMjYgICAxNzYuNzc0NjUx
MzAwICAgIDE4ICBSICBXUyAzMiArIDggWzBdDQogICAgICA4LDE2ICAgMiAgICAgIDEyNyAg
IDE3Ni43NzQ2NTI5MDAgICAgMTggIEkgIFdTIDMyICsgOCBba3NvZnRpcnFkLzJdDQogICAg
ICA4LDE2ICAgMCAgICAgIDE2NSAgIDE3Ni43Nzg1NDYzNjAgICA5MjQgIEQgIFdTIDMyICsg
OCBbc3NoZF0NCiAgICAgIDgsMTYgICAwICAgICAgMTY2ICAgMTc2Ljc4MjQ5ODEyMCAgIDky
NCAgRCAgV1MgOCArIDggW3NzaGRdDQogICAgICA4LDE2ICAgMCAgICAgIDE2NyAgIDE3Ni43
ODUyOTg5ODAgICAgIDMgIEMgIFdTIDMyICsgOCBbMF0NCiAgICAgIDgsMTYgICAwICAgICAg
MTY4ICAgMTc2Ljc4ODY3MTI0MCAgICAgMyAgQyAgV1MgOCArIDggWzBdDQoNCldlIGNhbiBz
ZWUgZnJvbSB0aGUgcmVzdWx0IHRoYXQgdGhlIGFkamFjZW50IHJlcXVlc3RzIGRpZG4ndCBn
ZXQgbWVyZ2VkLiANClRvIG1ha2UgdGhvc2UgYWRqYWNlbnQgcmVxdWVzdHMgdG8gZ2V0IG1l
cmdlZCwgSSB0cnkgdG8gd3JpdGUgYSBzaW1wbGUgcGF0Y2g6DQoNCmRpZmYgLS1naXQgYS9i
bG9jay9lbGV2YXRvci5jIGIvYmxvY2svZWxldmF0b3IuYw0KaW5kZXggYzM1NTVjOWM2Li40
MGFjZDBlODQgMTAwNjQ0DQotLS0gYS9ibG9jay9lbGV2YXRvci5jDQorKysgYi9ibG9jay9l
bGV2YXRvci5jDQpAQCAtMjQ1LDYgKzI0NSw3IEBAIEVYUE9SVF9TWU1CT0woZWxldmF0b3Jf
ZXhpdCk7DQogc3RhdGljIGlubGluZSB2b2lkIF9fZWx2X3JxaGFzaF9kZWwoc3RydWN0IHJl
cXVlc3QgKnJxKQ0KIHsNCiAgICAgICAgaGFzaF9kZWwoJnJxLT5oYXNoKTsNCisgICAgICAg
aGFzaF9kZWwoJnJxLT5mcm9udF9oYXNoKTsNCiAgICAgICAgcnEtPmNtZF9mbGFncyAmPSB+
UkVRX0hBU0hFRDsNCiB9DQogDQpAQCAtMjUyLDYgKzI1Myw3IEBAIHN0YXRpYyB2b2lkIGVs
dl9ycWhhc2hfZGVsKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxLCBzdHJ1Y3QgcmVxdWVzdCAq
cnEpDQogew0KICAgICAgICBpZiAoRUxWX09OX0hBU0gocnEpKQ0KICAgICAgICAgICAgICAg
IF9fZWx2X3JxaGFzaF9kZWwocnEpOw0KKw0KIH0NCiANCiBzdGF0aWMgdm9pZCBlbHZfcnFo
YXNoX2FkZChzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAqcSwgc3RydWN0IHJlcXVlc3QgKnJxKQ0K
QEAgLTI2MCw2ICsyNjIsNyBAQCBzdGF0aWMgdm9pZCBlbHZfcnFoYXNoX2FkZChzdHJ1Y3Qg
cmVxdWVzdF9xdWV1ZSAqcSwgc3RydWN0IHJlcXVlc3QgKnJxKQ0KIA0KICAgICAgICBCVUdf
T04oRUxWX09OX0hBU0gocnEpKTsNCiAgICAgICAgaGFzaF9hZGQoZS0+aGFzaCwgJnJxLT5o
YXNoLCBycV9oYXNoX2tleShycSkpOw0KKyAgICAgICBoYXNoX2FkZChlLT5mcm9udF9oYXNo
LCAmcnEtPmZyb250X2hhc2gsIGJsa19ycV9wb3MocnEpKTsNCiAgICAgICAgcnEtPmNtZF9m
bGFncyB8PSBSRVFfSEFTSEVEOw0KIH0NCiANCkBAIC0yOTAsNiArMjkzLDI4IEBAIHN0YXRp
YyBzdHJ1Y3QgcmVxdWVzdCAqZWx2X3JxaGFzaF9maW5kKHN0cnVjdCByZXF1ZXN0X3F1ZXVl
ICpxLCBzZWN0b3JfdCBvZmZzZXQpDQogICAgICAgIHJldHVybiBOVUxMOw0KIH0NCiANCitz
dGF0aWMgc3RydWN0IHJlcXVlc3QgKmVsdl9mcm9udGhhc2hfZmluZChzdHJ1Y3QgcmVxdWVz
dF9xdWV1ZSAqcSwgc2VjdG9yX3Qgb2Zmc2V0KQ0KK3sNCisgICAgICAgIHN0cnVjdCBlbGV2
YXRvcl9xdWV1ZSAqZSA9IHEtPmVsZXZhdG9yOw0KKyAgICAgICAgc3RydWN0IGhsaXN0X25v
ZGUgKm5leHQ7DQorICAgICAgICBzdHJ1Y3QgcmVxdWVzdCAqcnE7DQorDQorICAgICAgICBo
YXNoX2Zvcl9lYWNoX3Bvc3NpYmxlX3NhZmUoZS0+ZnJvbnRfaGFzaCwgcnEsIG5leHQsIGZy
b250X2hhc2gsIG9mZnNldCkgew0KKyAgICAgICAgICAgICAgICBCVUdfT04oIUVMVl9PTl9I
QVNIKHJxKSk7DQorDQorICAgICAgICAgICAgICAgIGlmICh1bmxpa2VseSghcnFfbWVyZ2Vh
YmxlKHJxKSkpIHsNCisgICAgICAgICAgICAgICAgICAgICAgICBfX2Vsdl9ycWhhc2hfZGVs
KHJxKTsNCisgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsNCisgICAgICAgICAg
ICAgICAgfQ0KKw0KKyAgICAgICAgICAgICAgICBpZiAoYmxrX3JxX3BvcyhycSkgPT0gb2Zm
c2V0KQ0KKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBycTsNCisgICAgICAgIH0N
CisNCisgICAgICAgIHJldHVybiBOVUxMOw0KK30NCisNCisNCiAvKg0KICAqIFJCLXRyZWUg
c3VwcG9ydCBmdW5jdGlvbnMgZm9yIGluc2VydGluZy9sb29rdXAvcmVtb3ZhbCBvZiByZXF1
ZXN0cw0KICAqIGluIGEgc29ydGVkIFJCIHRyZWUuDQpAQCAtNDkzLDYgKzUxOCwzOSBAQCBz
dGF0aWMgYm9vbCBlbHZfYXR0ZW1wdF9pbnNlcnRfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVl
dWUgKnEsDQogDQogICAgICAgIHJldHVybiByZXQ7DQogfQ0KKy8qDQorICogQXR0ZW1wdCB0
byBkbyBhbiBpbnNlcnRpb24gZnJvbnQgbWVyZ2UuDQorICogUmV0dXJucyB0cnVlIGlmIHdl
IG1lcmdlZCwgZmFsc2Ugb3RoZXJ3aXNlDQorICovDQorc3RhdGljIGJvb2wgZWx2X2F0dGVt
cHRfZnJvbnRfbWVyZ2Uoc3RydWN0IHJlcXVlc3RfcXVldWUgKnEsDQorICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHJlcXVlc3QgKnJxKQ0KK3sNCisgICAg
ICAgc3RydWN0IHJlcXVlc3QgKl9fcnE7DQorICAgICAgIGJvb2wgcmV0Ow0KKw0KKyAgICAg
ICBpZiAoYmxrX3F1ZXVlX25vbWVyZ2VzKHEpKQ0KKyAgICAgICAgICAgICAgIHJldHVybiBm
YWxzZTsNCisNCisgICAgICAgLyoNCisgICAgICAgICogRmlyc3QgdHJ5IG9uZS1oaXQgY2Fj
aGUuDQorICAgICAgICAqLw0KKyAgICAgICBpZiAocS0+bGFzdF9tZXJnZSAmJiBibGtfYXR0
ZW1wdF9yZXFfbWVyZ2UocSwgcnEsIHEtPmxhc3RfbWVyZ2UpKQ0KKyAgICAgICAgICAgICAg
IHJldHVybiB0cnVlOw0KKw0KKyAgICAgICBpZiAoYmxrX3F1ZXVlX25veG1lcmdlcyhxKSkN
CisgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7DQorDQorICAgICAgIHJldCA9IGZhbHNl
Ow0KKyAgICAgICAvKg0KKyAgICAgICAgKiBTZWUgaWYgb3VyIGhhc2ggbG9va3VwIGNhbiBm
aW5kIGEgcG90ZW50aWFsIGZyb250bWVyZ2UuDQorICAgICAgICAqLw0KKw0KKyAgICAgICBf
X3JxID0gZWx2X2Zyb250aGFzaF9maW5kKHEsIHJxX2hhc2hfa2V5KHJxKSk7DQorICAgICAg
IGlmIChfX3JxICYmIGJsa19hdHRlbXB0X3JlcV9tZXJnZShxLCBycSwgX19ycSkpIHsNCisg
ICAgICAgICAgICAgICByZXQgPSB0cnVlOw0KKyAgICAgICB9DQorICAgICAgIHJldHVybiBy
ZXQ7DQorfQ0KIA0KIHZvaWQgZWx2X21lcmdlZF9yZXF1ZXN0KHN0cnVjdCByZXF1ZXN0X3F1
ZXVlICpxLCBzdHJ1Y3QgcmVxdWVzdCAqcnEsIGludCB0eXBlKQ0KIHsNCkBAIC02NTcsNiAr
NzE1LDggQEAgdm9pZCBfX2Vsdl9hZGRfcmVxdWVzdChzdHJ1Y3QgcmVxdWVzdF9xdWV1ZSAq
cSwgc3RydWN0IHJlcXVlc3QgKnJxLCBpbnQgd2hlcmUpDQogICAgICAgICAgICAgICAgICog
ZWxldmF0b3JfYWRkX3JlcV9mbi4NCiAgICAgICAgICAgICAgICAgKi8NCiAgICAgICAgICAg
ICAgICBxLT5lbGV2YXRvci0+dHlwZS0+b3BzLmVsZXZhdG9yX2FkZF9yZXFfZm4ocSwgcnEp
Ow0KKyAgICAgICAgICAgICAgIC8qIGRvIGEgZnJvbnQgbWVyZ2UgYWZ0ZXIgd2UgYWRkZWQg
aXQgdG8gZWxldmF0b3IgKi8NCisgICAgICAgICAgICAgICBlbHZfYXR0ZW1wdF9mcm9udF9t
ZXJnZShxLCBycSk7DQogICAgICAgICAgICAgICAgYnJlYWs7DQogDQogICAgICAgIGNhc2Ug
RUxFVkFUT1JfSU5TRVJUX0ZMVVNIOg0KZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvYmxr
ZGV2LmggYi9pbmNsdWRlL2xpbnV4L2Jsa2Rldi5oDQppbmRleCAwODVhMDNmNjcuLjlmZTI1
YmUxYiAxMDA2NDQNCi0tLSBhL2luY2x1ZGUvbGludXgvYmxrZGV2LmgNCisrKyBiL2luY2x1
ZGUvbGludXgvYmxrZGV2LmgNCkBAIC0xMjAsNiArMTIwLDggQEAgc3RydWN0IHJlcXVlc3Qg
ew0KICAgICAgICAgICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgaXBpX2xpc3Q7DQogICAgICAg
IH07DQogDQorICAgICAgIHN0cnVjdCBobGlzdF9ub2RlIGZyb250X2hhc2g7IC8qIGZyb250
IG1lcmdlIGhhc2ggKi8NCisNCiAgICAgICAgLyoNCiAgICAgICAgICogVGhlIHJiX25vZGUg
aXMgb25seSB1c2VkIGluc2lkZSB0aGUgaW8gc2NoZWR1bGVyLCByZXF1ZXN0cw0KICAgICAg
ICAgKiBhcmUgcHJ1bmVkIHdoZW4gbW92ZWQgdG8gdGhlIGRpc3BhdGNoIHF1ZXVlLiBTbyBs
ZXQgdGhlDQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9lbGV2YXRvci5oIGIvaW5jbHVk
ZS9saW51eC9lbGV2YXRvci5oDQppbmRleCA2MzhiMzI0ZjAuLjE1NjdlNTQxMiAxMDA2NDQN
Ci0tLSBhL2luY2x1ZGUvbGludXgvZWxldmF0b3IuaA0KKysrIGIvaW5jbHVkZS9saW51eC9l
bGV2YXRvci5oDQpAQCAtMTE0LDYgKzExNCw3IEBAIHN0cnVjdCBlbGV2YXRvcl9xdWV1ZQ0K
ICAgICAgICBzdHJ1Y3QgbXV0ZXggc3lzZnNfbG9jazsNCiAgICAgICAgdW5zaWduZWQgaW50
IHJlZ2lzdGVyZWQ6MTsNCiAgICAgICAgREVDTEFSRV9IQVNIVEFCTEUoaGFzaCwgRUxWX0hB
U0hfQklUUyk7DQorICAgICAgIERFQ0xBUkVfSEFTSFRBQkxFKGZyb250X2hhc2gsIEVMVl9I
QVNIX0JJVFMpOw0KIH07DQogDQogLyoNCg0KV2l0aCB0aGUgcGF0Y2ggSSByZXN0YXJ0ICAi
Li9hMS5pbyAmIHNsZWVwIDEgJiYgLi9hMC5pbyIgYW5kIGJsa3RyYWNlIHJlc3VsdCBzaG93
ZWQgYmVsbG93Og0KDQogICAgICA4LDE2ICAgMiAgICAgIDI0OSAgIDQ3MS42MDg5MzAyNDAg
IDE0NzMgIFEgIFdTIDE2ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDI1MCAg
IDQ3MS42MDg5MzQ5NDAgIDE0NzMgIEcgIFdTIDE2ICsgOCBbYTEuaW9dDQogICAgICA4LDE2
ICAgMiAgICAgIDI1MiAgIDQ3MS42MDg5NDA2ODAgIDE0NzMgIFEgIFdTIDQwICsgOCBbYTEu
aW9dDQogICAgICA4LDE2ICAgMiAgICAgIDI1MyAgIDQ3MS42MDg5NDI4NDAgIDE0NzMgIEcg
IFdTIDQwICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDI1NCAgIDQ3MS42MDg5
NDY1MDAgIDE0NzMgIFEgIFdTIDY0ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAg
IDI1NSAgIDQ3MS42MDg5NDgwNDAgIDE0NzMgIEcgIFdTIDY0ICsgOCBbYTEuaW9dDQogICAg
ICA4LDE2ICAgMiAgICAgIDI1NiAgIDQ3MS42MDg5NTE0NjAgIDE0NzMgIFEgIFdTIDg4ICsg
OCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDI1NyAgIDQ3MS42MDg5NTI5NjAgIDE0
NzMgIEcgIFdTIDg4ICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMiAgICAgIDI1OCAgIDQ3
MS42MDg5NTYzNDAgIDE0NzMgIFEgIFdTIDExMiArIDggW2ExLmlvXQ0KICAgICAgOCwxNiAg
IDIgICAgICAyNTkgICA0NzEuNjA4OTU3NzgwICAxNDczICBHICBXUyAxMTIgKyA4IFthMS5p
b10NCiAgICAgIDgsMTYgICAyICAgICAgMjYwICAgNDcxLjYwODk1OTg4MCAgMTQ3MyAgSSAg
V1MgMTYgKyA4IFthMS5pb10NCiAgICAgIDgsMTYgICAyICAgICAgMjYxICAgNDcxLjYwODk3
NTg4MCAgMTQ3MyAgSSAgV1MgNDAgKyA4IFthMS5pb10NCiAgICAgIDgsMTYgICAyICAgICAg
MjYyICAgNDcxLjYwODk4NjQyMCAgMTQ3MyAgSSAgV1MgNjQgKyA4IFthMS5pb10NCiAgICAg
IDgsMTYgICAyICAgICAgMjYzICAgNDcxLjYwODk5NTQ4MCAgMTQ3MyAgSSAgV1MgODggKyA4
IFthMS5pb10NCiAgICAgIDgsMTYgICAyICAgICAgMjY0ICAgNDcxLjYwOTAwMzcyMCAgMTQ3
MyAgSSAgV1MgMTEyICsgOCBbYTEuaW9dDQogICAgICA4LDE2ICAgMyAgICAgIDI2NyAgIDQ3
MS42MTAyMDA2ODAgIDE0NzQgIFEgIFdTIDggKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAz
ICAgICAgMjY4ICAgNDcxLjYxMDIwNDcwMCAgMTQ3NCAgRyAgV1MgOCArIDggW2EwLmlvXQ0K
ICAgICAgOCwxNiAgIDMgICAgICAyNzAgICA0NzEuNjEwMjEwMjgwICAxNDc0ICBRICBXUyAz
MiArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDMgICAgICAyNzEgICA0NzEuNjEwMjExODQw
ICAxNDc0ICBHICBXUyAzMiArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDMgICAgICAyNzIg
ICA0NzEuNjEwMjE1NjYwICAxNDc0ICBRICBXUyA1NiArIDggW2EwLmlvXQ0KICAgICAgOCwx
NiAgIDMgICAgICAyNzMgICA0NzEuNjEwMjE3MjAwICAxNDc0ICBHICBXUyA1NiArIDggW2Ew
LmlvXQ0KICAgICAgOCwxNiAgIDMgICAgICAyNzQgICA0NzEuNjEwMjIwODYwICAxNDc0ICBR
ICBXUyA4MCArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDMgICAgICAyNzUgICA0NzEuNjEw
MjIyMzAwICAxNDc0ICBHICBXUyA4MCArIDggW2EwLmlvXQ0KICAgICAgOCwxNiAgIDMgICAg
ICAyNzYgICA0NzEuNjEwMjI1NzIwICAxNDc0ICBRICBXUyAxMDQgKyA4IFthMC5pb10NCiAg
ICAgIDgsMTYgICAzICAgICAgMjc3ICAgNDcxLjYxMDIyNzU0MCAgMTQ3NCAgRyAgV1MgMTA0
ICsgOCBbYTAuaW9dDQogICAgICA4LDE2ICAgMyAgICAgIDI3OCAgIDQ3MS42MTAyMjkxMDAg
IDE0NzQgIEkgIFdTIDggKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAzICAgICAgMjc5ICAg
NDcxLjYxNTI5MTQyMCAgMTQ3NCAgSSAgV1MgMzIgKyA4IFthMC5pb10NCiAgICAgIDgsMTYg
ICAzICAgICAgMjgwICAgNDcxLjYyMDMxMTIwMCAgMTQ3NCAgSSAgV1MgNTYgKyA4IFthMC5p
b10NCiAgICAgIDgsMTYgICAzICAgICAgMjgxICAgNDcxLjYyNTMyNzYyMCAgMTQ3NCAgSSAg
V1MgODAgKyA4IFthMC5pb10NCiAgICAgIDgsMTYgICAzICAgICAgMjgyICAgNDcxLjYzMDM0
MzA4MCAgMTQ3NCAgSSAgV1MgMTA0ICsgOCBbYTAuaW9dDQogICAgICA4LDE2ICAgMyAgICAg
IDI4NCAgIDQ3MS42Mzc4ODE2MDAgIDE0NzQgIEQgIFdTIDEwNCArIDE2IFthMC5pb10NCiAg
ICAgIDgsMTYgICAzICAgICAgMjg1ICAgNDcxLjY0MDQyOTEyMCAgMTQ3NCAgRCAgV1MgODAg
KyAxNiBbYTAuaW9dDQogICAgICA4LDE2ICAgMCAgICAgIDM5NyAgIDQ3MS42NDQ1NzMxMDAg
ICAgIDMgIEMgIFdTIDEwNCArIDE2IFswXQ0KICAgICAgOCwxNiAgIDAgICAgICAzOTggICA0
NzEuNjQ3MTU5NjQwICAgICAzICBEICBXUyA1NiArIDE2IFtrc29mdGlycWQvMF0NCiAgICAg
IDgsMTYgICAxICAgICAgIDQ5ICAgNDcxLjY0OTgyNTk0MCAgICAxMyAgQyAgV1MgODAgKyAx
NiBbMF0NCiAgICAgIDgsMTYgICAxICAgICAgIDUwICAgNDcxLjY1MjM5MTU0MCAgICAxMyAg
RCAgV1MgMzIgKyAxNiBba3NvZnRpcnFkLzFdDQogICAgICA4LDE2ICAgMCAgICAgIDM5OSAg
IDQ3MS42NTQ0NDY1ODAgICAgIDMgIEMgIFdTIDU2ICsgMTYgWzBdDQogICAgICA4LDE2ICAg
MCAgICAgIDQwMCAgIDQ3MS42NTcwMDA4MjAgICAgIDMgIEQgIFdTIDggKyAxNiBba3NvZnRp
cnFkLzBdDQogICAgICA4LDE2ICAgMCAgICAgIDQwMSAgIDQ3MS42NTk0NDUwMDAgICAgIDMg
IEMgIFdTIDMyICsgMTYgWzBdDQogICAgICA4LDE2ICAgMCAgICAgIDQwMiAgIDQ3MS42NjM5
NDYzNjAgICAgIDMgIEMgIFdTIDggKyAxNiBbMF0NCg0KTm93IHRob3NlIGFkamFjZW50IHJl
cXVlc3QgZ2V0IG1lcmdlZC4NCg0KLS0tLS0tLS0tLS0tLS0tLS0tIE9yaWdpbmFsIC0tLS0t
LS0tLS0tLS0tLS0tLQ0KRnJvbTogICJaaGVuZ3l1YW4gTGl1IjxsaXV6aGVuZ3l1YW5Aa3ls
aW5vcy5jbj47DQpEYXRlOiAgRnJpLCBBcHIgMTMsIDIwMTggMDQ6MTYgUE0NClRvOiAgInNo
bGkiPHNobGlAZmIuY29tPjsNClN1YmplY3Q6ICBxdWVzdGlvbiBhYm91dCByZXF1ZXN0IG1l
cmdlDQogDQpIaSwgU2hhb2h1YQ0KDQpUaGVyZSBpcyBhIHF1ZXN0aW9uIGFyb3VuZCBtZSB3
aGlsZSB2aWV3aW5nIGJsb2NrIGxheWVyIGNvZGUsIHNvIEknbSB3cml0aW5nIHRvIHlvdSB0
byBnZXQgaGVscC4NCg0KV2hlbiBhIHJlcXVlc3QgZnJvbSBwbHVnIGxpc3QgZ2V0IGZsdXNo
ZWQgdG8gcXVldWUsIGl0IHRyeSB0byBtZXJnZSBpbnRvIGEgZXhpc3RpbmcgcmVxdWVzdCBi
eQ0KY2FsbGluZyBmdW5jdGlvbiBlbHZfYXR0ZW1wdF9pbnNlcnRfbWVyZ2UgYmVmb3JlIGFk
ZGVkIGRpcmVjdGx5IHRvIHRoZSBxdWV1ZSwgc2VlaW5nIGJlbGxvdzoNCg0KICAgICAgICAg
IC8qDQogICAgICAgICAqIEF0dGVtcHQgdG8gZG8gYW4gaW5zZXJ0aW9uIGJhY2sgbWVyZ2Uu
IE9ubHkgY2hlY2sgZm9yIHRoZSBjYXNlIHdoZXJlDQogICAgICAgICAqIHdlIGNhbiBhcHBl
bmQgJ3JxJyB0byBhbiBleGlzdGluZyByZXF1ZXN0LCBzbyB3ZSBjYW4gdGhyb3cgJ3JxJyBh
d2F5DQogICAgICAgICAqIGFmdGVyd2FyZHMuDQogICAgICAgICAqDQogICAgICAgICAqIFJl
dHVybnMgdHJ1ZSBpZiB3ZSBtZXJnZWQsIGZhbHNlIG90aGVyd2lzZQ0KICAgICAgICAgKi8N
CiAgICAgICAgYm9vbCBlbHZfYXR0ZW1wdF9pbnNlcnRfbWVyZ2Uoc3RydWN0IHJlcXVlc3Rf
cXVldWUgKnEsIHN0cnVjdCByZXF1ZXN0ICpycSkNCiAgICAgICAgew0KICAgICAgICAgICAg
ICAgIHN0cnVjdCByZXF1ZXN0ICpfX3JxOw0KICAgICAgICAgICAgICAgIGJvb2wgcmV0Ow0K
DQogICAgICAgICAgICAgICAgaWYgKGJsa19xdWV1ZV9ub21lcmdlcyhxKSkNCiAgICAgICAg
ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsNCg0KICAgICAgICAgICAgICAgIC8qDQog
ICAgICAgICAgICAgICAgICogRmlyc3QgdHJ5IG9uZS1oaXQgY2FjaGUuDQogICAgICAgICAg
ICAgICAgICovDQogICAgICAgICAgICAgICAgaWYgKHEtPmxhc3RfbWVyZ2UgJiYgYmxrX2F0
dGVtcHRfcmVxX21lcmdlKHEsIHEtPmxhc3RfbWVyZ2UsIHJxKSkNCiAgICAgICAgICAgICAg
ICAgICAgICAgIHJldHVybiB0cnVlOw0KDQogICAgICAgICAgICAgICAgaWYgKGJsa19xdWV1
ZV9ub3htZXJnZXMocSkpDQogICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7
DQoNCiAgICAgICAgICAgICAgICByZXQgPSBmYWxzZTsNCiAgICAgICAgICAgICAgICAvKg0K
ICAgICAgICAgICAgICAgICAqIFNlZSBpZiBvdXIgaGFzaCBsb29rdXAgY2FuIGZpbmQgYSBw
b3RlbnRpYWwgYmFja21lcmdlLg0KICAgICAgICAgICAgICAgICAqLw0KICAgICAgICAgICAg
ICAgIHdoaWxlICgxKSB7DQogICAgICAgICAgICAgICAgICAgICAgICBfX3JxID0gZWx2X3Jx
aGFzaF9maW5kKHEsIGJsa19ycV9wb3MocnEpKTsNCiAgICAgICAgICAgICAgICAgICAgICAg
IGlmICghX19ycSB8fCAhYmxrX2F0dGVtcHRfcmVxX21lcmdlKHEsIF9fcnEsIHJxKSkNCiAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7DQoNCiAgICAgICAgICAgICAg
ICAgICAgICAgIC8qIFRoZSBtZXJnZWQgcmVxdWVzdCBjb3VsZCBiZSBtZXJnZWQgd2l0aCBv
dGhlcnMsIHRyeSBhZ2FpbiAqLw0KICAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gdHJ1
ZTsNCiAgICAgICAgICAgICAgICAgICAgICAgIHJxID0gX19ycTsNCiAgICAgICAgICAgICAg
ICB9DQoNCiAgICAgICAgICAgICAgICByZXR1cm4gcmV0Ow0KICAgICAgICB9DQoNCkZyb20g
dGhlIGNvbW1lbnQgYW5kIGNvZGUgd2UgY2FuIHNlZSBpdCBvbmx5IGRvIGJhY2ttZXJnZSwg
SSB0aGluayBpdHMgZW5vdWdoIHdoZW4gdGhlcmUgaXMgb25seQ0Kb25lIHRocmVhZCBkb2lu
ZyBJTyBvcGVyYXRpb24gc2luY2Ugd2UgaGF2ZSBzb3J0ZWQgdGhlIHJlcXVlc3RzIGluIHBs
dWcgbGlzdCBiZWZvcmUgdW5wbHVnLCBzZWVpbmcgdGhlIA0KcGF0Y2ggZnJvbSBKaWFucGVu
ZyBNYSA0MjI3NjVjKCJibG9jazogUmVtb3ZlIHNob3VsZF9zb3J0IGp1ZGdlbWVudCB3aGVu
IGZsdXNoIGJsa19wbHVnIikgYW5kDQo5NzU5MjdiKCJibG9jazogQWRkIGJsa19ycV9wb3Mo
cnEpIHRvIHNvcnQgcnEgd2hlbiBwbHVzaGluZyIpLiBIb3dldmVyIHdoZW4gY29tZXMgdG8g
bXVsdGlwbGUNCnRocmVhZHMsIGxldHMgaW1hZ2UgYmVsbG93IElPIHNjZW5hcmlvLCB0aHJl
YWQgQSBhbmQgQiBib3RoIGhvbGQgdGhyZWUgcmVxdWVzdHMgaW4gcGx1ZyBsaXN0Lg0KDQog
ICAgdGhyZWFkQTogYSsxLCBhKzQsIGErNw0KICAgIHRocmVhZEI6IGErMiwgYSs1LCBhKzgN
Cg0KaWYgdGhyZWFkQSBoYXMgZmx1c2hlZCBhbGwgaXRzIHJlcXVlc3QgdG8gcXVldWUgYmVm
b3JlIHRocmVhZEIgZG9lcywgdGhlbiByZXF1ZXN0IGErMSBhbmQgYSsyICBhbmQNCm90aGVy
IGFkamFjZW50IHBhaXJzIGhhdmUgdGhlIGNoYW5jZSB0byBnZXQgbWVyZ2VkIHRocm91Z2gg
YmFja21lcmdlLCBidXQgaWYgIHRocmVhZEIgZmx1c2hzIGFsbCBpdHMNCnJlcXVlc3RzIHRv
IHF1ZXVlIGJlZm9yZSB0aHJlYWRBIGhvdyBjb3VsZCB0aG9zZSBhZGphY2VudCByZXF1ZXN0
cyBnZXQgbWVyZ2VkPyBvciBpdCBkb2Vzbid0IG1hdHRlcg0KYXQgYWxsPyAgSSBrbm93IHlv
dXIgcGF0Y2ggYmVlMDM5MygiYmxvY2s6IHJlY3Vyc2l2ZSBtZXJnZSByZXF1ZXN0cyIpIGhh
cyBzb2x2ZWQgYSBtdWx0aS10aHJlYWQgbWVyZ2UNCnByb2JsZW0gYnV0IG5vdCBtaW5lcy4N
Ckl0cyBoYXJkIHRvIHNpbXVsYXRlIHN1Y2ggYSBJTyBzY2VuYXJpbyBmcm9tIHVzZXJzcGFj
ZSBhbmQgSSBjYW5uJ3QgZmluZ3VyZSBvdXQgb3RoZXIgdXNlZnVsIG1ldGhvZHMNCnRvIHZl
cmlmeSB3aGV0aGVyICB0aGUgcmVxdWVzdHMgaW4gc3VjaCBJTyBzY2VuYXJpbyByZWFsbHkg
Y2Fubid0IGdldCBtZXJnZWQuIEFsbCBteSB0aG91Z2h0cyBhcmUgZnJvbQ0Kc3BlY3VsYXRp
b24sIHNvIEkgaG9wZSB5b3UgY291bGQgZ2l2ZSBtZSBzb21lIGFuc3dlcnMuIEFueSByZXBs
eSB3b3VsZCBiZSB0aGFua2Z1bC4NCg0KWmhlbmd5dWFu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: question about request merge
2018-04-20 3:51 ` Re:question about request merge Zhengyuan Liu
@ 2018-04-20 14:34 ` Jens Axboe
0 siblings, 0 replies; 5+ messages in thread
From: Jens Axboe @ 2018-04-20 14:34 UTC (permalink / raw)
To: Zhengyuan Liu, shli; +Cc: linux-block
On 4/19/18 9:51 PM, Zhengyuan Liu wrote:
> Hi, Shaohua
>
> I found it indeed doesn't do front merge when two threads flush plug list concurrently. To
> reappear , I prepared two IO threads , named a0.io and a1.io .
> Thread a1.io uses libaio to write 5 requests :
> sectors: 16 + 8, 40 + 8, 64 + 8, 88 + 8, 112 + 8
> Thread a0.io uses libaio to write other 5 requests :
> sectors: 8+ 8, 32 + 8, 56 + 8, 80 + 8, 104 + 8
I'm cutting some of the below.
Thanks for the detailed email. It's mostly on purpose that we don't
spend cycles and memory on maintaining a separate front merge hash,
since it's generally not something that happens very often. If you have
a thread pool doing IO and split sequential IO such that you would
benefit a lot from front merging, then I would generally claim that
you're not writing your app in the most optimal manner.
So I'm curious, what's the big interest in front merging?
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: question about request merge
2018-04-21 16:23 ` Jens Axboe
@ 2018-04-23 3:13 ` Zhengyuan Liu
0 siblings, 0 replies; 5+ messages in thread
From: Zhengyuan Liu @ 2018-04-23 3:13 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, shli
MjAxOC0wNC0yMiAwOjIzIEdNVCswODowMCBKZW5zIEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+
Og0KPiBPbiA0LzIxLzE4IDg6MDcgQU0sIFpoZW5neXVhbiBMaXUgd3JvdGU6DQo+PiAyMDE4
LTA0LTIwIDIyOjM0IEdNVCswODowMCBKZW5zIEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+Og0K
Pj4+IE9uIDQvMTkvMTggOTo1MSBQTSwgWmhlbmd5dWFuIExpdSB3cm90ZToNCj4+Pj4gSGks
IFNoYW9odWENCj4+Pj4NCj4+Pj4gSSBmb3VuZCBpdCBpbmRlZWQgZG9lc24ndCBkbyBmcm9u
dCBtZXJnZSB3aGVuIHR3byB0aHJlYWRzIGZsdXNoIHBsdWcgbGlzdCAgY29uY3VycmVudGx5
LiAgIFRvDQo+Pj4+IHJlYXBwZWFyICwgSSBwcmVwYXJlZCB0d28gSU8gdGhyZWFkcyAsIG5h
bWVkIGEwLmlvIGFuZCBhMS5pbyAuDQo+Pj4+IFRocmVhZCBhMS5pbyAgdXNlcyBsaWJhaW8g
dG8gd3JpdGUgNSByZXF1ZXN0cyA6DQo+Pj4+ICAgICBzZWN0b3JzOiAxNiArIDgsIDQwICsg
OCwgNjQgKyA4LCA4OCArIDgsIDExMiArIDgNCj4+Pj4gVGhyZWFkIGEwLmlvICB1c2VzIGxp
YmFpbyB0byB3cml0ZSBvdGhlciA1IHJlcXVlc3RzIDoNCj4+Pj4gICAgIHNlY3RvcnM6IDgr
IDgsIDMyICsgOCwgNTYgKyA4LCA4MCArIDgsIDEwNCArIDgNCj4+Pg0KPj4+IEknbSBjdXR0
aW5nIHNvbWUgb2YgdGhlIGJlbG93Lg0KPj4+DQo+Pj4gVGhhbmtzIGZvciB0aGUgZGV0YWls
ZWQgZW1haWwuIEl0J3MgbW9zdGx5IG9uIHB1cnBvc2UgdGhhdCB3ZSBkb24ndA0KPj4+IHNw
ZW5kIGN5Y2xlcyBhbmQgbWVtb3J5IG9uIG1haW50YWluaW5nIGEgc2VwYXJhdGUgZnJvbnQg
bWVyZ2UgaGFzaCwNCj4+PiBzaW5jZSBpdCdzIGdlbmVyYWxseSBub3Qgc29tZXRoaW5nIHRo
YXQgaGFwcGVucyB2ZXJ5IG9mdGVuLiBJZiB5b3UgaGF2ZQ0KPj4+IGEgdGhyZWFkIHBvb2wg
ZG9pbmcgSU8gYW5kIHNwbGl0IHNlcXVlbnRpYWwgSU8gc3VjaCB0aGF0IHlvdSB3b3VsZA0K
Pj4+IGJlbmVmaXQgYSBsb3QgZnJvbSBmcm9udCBtZXJnaW5nLCB0aGVuIEkgd291bGQgZ2Vu
ZXJhbGx5IGNsYWltIHRoYXQNCj4+PiB5b3UncmUgbm90IHdyaXRpbmcgeW91ciBhcHAgaW4g
dGhlIG1vc3Qgb3B0aW1hbCBtYW5uZXIuDQo+Pj4NCj4+DQo+PiBUaGFua3MgZm9yIGV4cGxh
bmF0aW9uLCBJIG9ubHkgY29uc2lkZXIgdGhlIHByb2JsZW0gdGhyb3VnaCB0aGUgY29kZSdz
DQo+PiBwZXJzcGVjdGl2ZSBhbmQgaWdub3JlIHRoZSByZWFsaXR5IHNpdHVhdGlvbiBvZiBh
cHAuDQo+DQo+IFRoYXQncyBxdWl0ZSBieSBkZXNpZ24gYW5kIG5vdCBhY2NpZGVudGFsLg0K
Pg0KPj4+IFNvIEknbSBjdXJpb3VzLCB3aGF0J3MgdGhlIGJpZyBpbnRlcmVzdCBpbiBmcm9u
dCBtZXJnaW5nPw0KPj4NCj4+IElmIGl0J3Mgbm90IHNvbWV0aGluZyB0aGF0IGhhcHBlbnMg
c28gbXVjaCBvZnRlbiwgSSB0aGluayBpdCdzIG5vdCB3b3J0aCB0bw0KPj4gc3VwcG9ydCBm
cm9udCBtZXJnaW5nIHRvby4NCj4+DQo+PiBCeSB0aGUgd2F5LCBJIGdvdCBhbm90aGVyIHF1
ZXN0aW9uIHRoYXQgd2h5IG5vdCAgYmxrdHJhY2UgdHJhY2luZyB0aGUgYmFjaw0KPj4gbWVy
Z2luZyBvZiByZXF1ZXN0cyB3aGlsZSBmbHVzaGluZyBwbHVnZ2VkIHJlcXVlc3RzIHRvIHF1
ZXVlLCAgaWYgaXQgZG9lcw0KPj4gd2UgbWF5IGdldCBhIG1vcmUgY2xlYXIgdmlldyBhYm91
dCBJTyBtZXJnaW5nLg0KPg0KPiBOb3Qgc3VyZSBJIGZvbGxvdywgZXhhY3RseSB3aGVyZSBp
cyBhIGJhY2sgbWVyZ2UgdHJhY2UgbWlzc2luZz8NCj4NCg0KSSBtZWFuIGJsa3RyYWNlIG9u
bHkgdHJhY2VzIGJpbyBtZXJnaW5nICwgbm90IHRyYWNlcyByZXF1ZXN0IG1lcmdpbmc7IExl
dA0KbWUgZ2l2ZSBhIGV4YW1wbGUsIEkgdXNlIHRocmVhZCBhLm91dCB0byB3cml0ZSB0aHJl
ZSBiaW9zLCBzZWVpbmcgYmVsbG93Og0KDQogICAgYS5vdXQ6ICAwICsgOCwgMTYgKyA4LCA4
ICsgOA0KDQpUaGUgcmVzdWx0IG9mIGJsa3RyYWNlIHdhcyBzaG93ZWQgYXMgYmVsbG93Og0K
DQogICAgICA4LDE2ICAgMSAgICAgICAgNyAgICAgMC4yOTIwNjkxODAgIDEyMjIgIFEgIFdT
IDAgKyA4IFthLm91dF0NCiAgICAgIDgsMTYgICAxICAgICAgICA4ICAgICAwLjI5MjA3Mzk2
MCAgMTIyMiAgRyAgV1MgMCArIDggW2Eub3V0XQ0KICAgICAgOCwxNiAgIDEgICAgICAgIDkg
ICAgIDAuMjkyMDc0NDQwICAxMjIyICBQICAgTiBbYS5vdXRdDQogICAgICA4LDE2ICAgMSAg
ICAgICAxMCAgICAgMC4yOTIwNzkzODAgIDEyMjIgIFEgIFdTIDE2ICsgOCBbYS5vdXRdDQog
ICAgICA4LDE2ICAgMSAgICAgICAxMSAgICAgMC4yOTIwODE4NDAgIDEyMjIgIEcgIFdTIDE2
ICsgOCBbYS5vdXRdDQogICAgICA4LDE2ICAgMSAgICAgICAxMiAgICAgMC4yOTIwODU4NjAg
IDEyMjIgIFEgIFdTIDggKyA4IFthLm91dF0NCiAgICAgIDgsMTYgICAxICAgICAgIDEzICAg
ICAwLjI5MjA4NzI0MCAgMTIyMiAgRiAgV1MgOCArIDggW2Eub3V0XQ0KICAgICAgOCwxNiAg
IDEgICAgICAgMTQgICAgIDAuMjkyMDg5MTAwICAxMjIyICBJICBXUyAwICsgOCBbYS5vdXRd
DQogICAgICA4LDE2ICAgMSAgICAgICAxNSAgICAgMC4yOTIwOTUyMDAgIDEyMjIgIEkgIFdT
IDggKyAxNiBbYS5vdXRdDQogICAgICA4LDE2ICAgMSAgICAgICAxNiAgICAgMC4yOTU5MzE5
MjAgIDEyMjIgIFUgICBOIFthLm91dF0gMg0KICAgICAgOCwxNiAgIDEgICAgICAgMTcgICAg
IDAuMjk4NTI4OTgwICAxMjIyICBEICBXUyAwICsgMjQgW2Eub3V0XQ0KICAgICAgOCwxNiAg
IDAgICAgICAgIDMgICAgIDAuMzAyNjE3MzYwICAgICAzICBDICBXUyAwICsgMjQgWzBdDQog
ICAgICANCiAgICAgIFRvdGFsICg4LDE2KToNCiAgICAgUmVhZHMgUXVldWVkOiAgICAgICAg
ICAgMCwgICAgICAgIDBLaUIJICAgICAgICAgV3JpdGVzIFF1ZXVlZDogICAgICAgICAgIDMs
ICAgICAgIDEyS2lCDQogICAgIFJlYWQgRGlzcGF0Y2hlczogICAgICAgIDAsICAgICAgICAw
S2lCCSAgICAgICAgV3JpdGUgRGlzcGF0Y2hlczogICAgICAgIDEsICAgICAgIDEyS2lCDQog
ICAgIFJlYWRzIFJlcXVldWVkOiAgICAgICAgIDAJCSAgICAgICAgICAgICAgIFdyaXRlcyBS
ZXF1ZXVlZDogICAgICAgICAwDQogICAgIFJlYWRzIENvbXBsZXRlZDogICAgICAgIDAsICAg
ICAgICAwS2lCICAgICAgV3JpdGVzIENvbXBsZXRlZDogICAgICAgIDEsICAgICAgIDEyS2lC
DQogICAgIFJlYWQgTWVyZ2VzOiAgICAgICAgICAgIDAsICAgICAgICAwS2lCCSAgICAgICAg
ICAgICBXcml0ZSBNZXJnZXM6ICAgICAgICAgICAgMSwgICAgICAgIDRLaUINCiAgICAgUEMg
UmVhZHMgUXVldWVkOiAgICAgICAgMCwgICAgICAgIDBLaUIgICAgICBQQyBXcml0ZXMgUXVl
dWVkOiAgICAgICAgMCwgICAgICAgIDBLaUINCiAgICAgUEMgUmVhZCBEaXNwLjogICAgICAg
ICAgMywgICAgICAgIDBLaUIJICAgICAgICAgICAgIFBDIFdyaXRlIERpc3AuOiAgICAgICAg
ICAwLCAgICAgICAgMEtpQg0KICAgICBQQyBSZWFkcyBSZXEuOiAgICAgICAgICAwCQkgUEMg
V3JpdGVzIFJlcS46ICAgICAgICAgIDANCiAgICAgUEMgUmVhZHMgQ29tcGwuOiAgICAgICAg
MwkJIFBDIFdyaXRlcyBDb21wbC46ICAgICAgICAwDQogICAgIElPIHVucGx1Z3M6ICAgICAg
ICAgICAgIDEgICAgICAgIAkgVGltZXIgdW5wbHVnczogICAgICAgICAgIDANCg0Kd2UgbWVy
Z2UgYmlvKDggKyA4KSBpbnRvIHJlcXVlc3QoMTYgKyA4KSBhdCBwbHVnIHN0YWdlIGFuZCB0
aGF0J3Mgd2VsbCB0cmFjZWQNCmFzIEYsIHdoZW4gY29tZXMgdG8gdW5wbHVnIHN0YWdlIHJl
cXVlc3QoMCArIDgpIGFuZCByZXF1ZXN0KDggKyAxNikgbWVyZ2UNCmludG8gb25seSBvbmUg
cmVxdWVzdCgwICsgMjQpLCAgYnV0IHRoZXJlIGlzbid0IHRyYWNpbmcgaW5mb3JtYXRpb24g
YWJvdXQgdGhhdA0Kb3BlcmF0aW9uLg0KDQogU28gSSdtIGp1c3QgYSBiaXQgY3VyaW91cyBh
bmQgcGxlYXNlIGZvcmdpdmUgbXkgaWdub3JhbmNlLg0KDQpUaGFua3MuDQo+IC0tDQo+IEpl
bnMgQXhib2UNCj4=
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: question about request merge
2018-04-21 14:07 Zhengyuan Liu
@ 2018-04-21 16:23 ` Jens Axboe
2018-04-23 3:13 ` Zhengyuan Liu
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2018-04-21 16:23 UTC (permalink / raw)
To: Zhengyuan Liu; +Cc: linux-block, shli
On 4/21/18 8:07 AM, Zhengyuan Liu wrote:
> 2018-04-20 22:34 GMT+08:00 Jens Axboe <axboe@kernel.dk>:
>> On 4/19/18 9:51 PM, Zhengyuan Liu wrote:
>>> Hi, Shaohua
>>>
>>> I found it indeed doesn't do front merge when two threads flush plug list concurrently. To
>>> reappear , I prepared two IO threads , named a0.io and a1.io .
>>> Thread a1.io uses libaio to write 5 requests :
>>> sectors: 16 + 8, 40 + 8, 64 + 8, 88 + 8, 112 + 8
>>> Thread a0.io uses libaio to write other 5 requests :
>>> sectors: 8+ 8, 32 + 8, 56 + 8, 80 + 8, 104 + 8
>>
>> I'm cutting some of the below.
>>
>> Thanks for the detailed email. It's mostly on purpose that we don't
>> spend cycles and memory on maintaining a separate front merge hash,
>> since it's generally not something that happens very often. If you have
>> a thread pool doing IO and split sequential IO such that you would
>> benefit a lot from front merging, then I would generally claim that
>> you're not writing your app in the most optimal manner.
>>
>
> Thanks for explanation, I only consider the problem through the code's
> perspective and ignore the reality situation of app.
That's quite by design and not accidental.
>> So I'm curious, what's the big interest in front merging?
>
> If it's not something that happens so much often, I think it's not worth to
> support front merging too.
>
> By the way, I got another question that why not blktrace tracing the back
> merging of requests while flushing plugged requests to queue, if it does
> we may get a more clear view about IO merging.
Not sure I follow, exactly where is a back merge trace missing?
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: question about request merge
@ 2018-04-21 14:07 Zhengyuan Liu
2018-04-21 16:23 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Zhengyuan Liu @ 2018-04-21 14:07 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, shli
MjAxOC0wNC0yMCAyMjozNCBHTVQrMDg6MDAgSmVucyBBeGJvZSA8YXhib2VAa2VybmVsLmRr
PjoNCj4gT24gNC8xOS8xOCA5OjUxIFBNLCBaaGVuZ3l1YW4gTGl1IHdyb3RlOg0KPj4gSGks
IFNoYW9odWENCj4+DQo+PiBJIGZvdW5kIGl0IGluZGVlZCBkb2Vzbid0IGRvIGZyb250IG1l
cmdlIHdoZW4gdHdvIHRocmVhZHMgZmx1c2ggcGx1ZyBsaXN0ICBjb25jdXJyZW50bHkuICAg
VG8NCj4+IHJlYXBwZWFyICwgSSBwcmVwYXJlZCB0d28gSU8gdGhyZWFkcyAsIG5hbWVkIGEw
LmlvIGFuZCBhMS5pbyAuDQo+PiBUaHJlYWQgYTEuaW8gIHVzZXMgbGliYWlvIHRvIHdyaXRl
IDUgcmVxdWVzdHMgOg0KPj4gICAgIHNlY3RvcnM6IDE2ICsgOCwgNDAgKyA4LCA2NCArIDgs
IDg4ICsgOCwgMTEyICsgOA0KPj4gVGhyZWFkIGEwLmlvICB1c2VzIGxpYmFpbyB0byB3cml0
ZSBvdGhlciA1IHJlcXVlc3RzIDoNCj4+ICAgICBzZWN0b3JzOiA4KyA4LCAzMiArIDgsIDU2
ICsgOCwgODAgKyA4LCAxMDQgKyA4DQo+DQo+IEknbSBjdXR0aW5nIHNvbWUgb2YgdGhlIGJl
bG93Lg0KPg0KPiBUaGFua3MgZm9yIHRoZSBkZXRhaWxlZCBlbWFpbC4gSXQncyBtb3N0bHkg
b24gcHVycG9zZSB0aGF0IHdlIGRvbid0DQo+IHNwZW5kIGN5Y2xlcyBhbmQgbWVtb3J5IG9u
IG1haW50YWluaW5nIGEgc2VwYXJhdGUgZnJvbnQgbWVyZ2UgaGFzaCwNCj4gc2luY2UgaXQn
cyBnZW5lcmFsbHkgbm90IHNvbWV0aGluZyB0aGF0IGhhcHBlbnMgdmVyeSBvZnRlbi4gSWYg
eW91IGhhdmUNCj4gYSB0aHJlYWQgcG9vbCBkb2luZyBJTyBhbmQgc3BsaXQgc2VxdWVudGlh
bCBJTyBzdWNoIHRoYXQgeW91IHdvdWxkDQo+IGJlbmVmaXQgYSBsb3QgZnJvbSBmcm9udCBt
ZXJnaW5nLCB0aGVuIEkgd291bGQgZ2VuZXJhbGx5IGNsYWltIHRoYXQNCj4geW91J3JlIG5v
dCB3cml0aW5nIHlvdXIgYXBwIGluIHRoZSBtb3N0IG9wdGltYWwgbWFubmVyLg0KPg0KDQpU
aGFua3MgZm9yIGV4cGxhbmF0aW9uLCBJIG9ubHkgY29uc2lkZXIgdGhlIHByb2JsZW0gdGhy
b3VnaCB0aGUgY29kZSdzIA0KcGVyc3BlY3RpdmUgYW5kIGlnbm9yZSB0aGUgcmVhbGl0eSBz
aXR1YXRpb24gb2YgYXBwLiANCg0KPiBTbyBJJ20gY3VyaW91cywgd2hhdCdzIHRoZSBiaWcg
aW50ZXJlc3QgaW4gZnJvbnQgbWVyZ2luZz8NCg0KSWYgaXQncyBub3Qgc29tZXRoaW5nIHRo
YXQgaGFwcGVucyBzbyBtdWNoIG9mdGVuLCBJIHRoaW5rIGl0J3Mgbm90IHdvcnRoIHRvIA0K
c3VwcG9ydCBmcm9udCBtZXJnaW5nIHRvby4NCg0KQnkgdGhlIHdheSwgSSBnb3QgYW5vdGhl
ciBxdWVzdGlvbiB0aGF0IHdoeSBub3QgIGJsa3RyYWNlIHRyYWNpbmcgdGhlIGJhY2sNCm1l
cmdpbmcgb2YgcmVxdWVzdHMgd2hpbGUgZmx1c2hpbmcgcGx1Z2dlZCByZXF1ZXN0cyB0byBx
dWV1ZSwgIGlmIGl0IGRvZXMNCndlIG1heSBnZXQgYSBtb3JlIGNsZWFyIHZpZXcgYWJvdXQg
SU8gbWVyZ2luZy4NCg0KPg0KPiAtLQ0KPiBKZW5zIEF4Ym9lDQo+
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-23 3:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_2DB1C4E822C7BE2363B8A451@qq.com>
2018-04-20 3:51 ` Re:question about request merge Zhengyuan Liu
2018-04-20 14:34 ` question " Jens Axboe
2018-04-21 14:07 Zhengyuan Liu
2018-04-21 16:23 ` Jens Axboe
2018-04-23 3:13 ` Zhengyuan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).