* [PATCH] blk-mq-pci: Remove unneeded includes
@ 2017-04-06 10:33 Sagi Grimberg
2017-04-06 11:51 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Sagi Grimberg @ 2017-04-06 10:33 UTC (permalink / raw)
To: Jens Axboe, linux-block; +Cc: Christoph Hellwig
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
---
block/blk-mq-pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c
index 0c3354cf3552..70b8a6765cc7 100644
--- a/block/blk-mq-pci.c
+++ b/block/blk-mq-pci.c
@@ -10,12 +10,9 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*/
-#include <linux/kobject.h>
-#include <linux/blkdev.h>
#include <linux/blk-mq.h>
#include <linux/blk-mq-pci.h>
#include <linux/pci.h>
-#include <linux/module.h>
/**
* blk_mq_pci_map_queues - provide a default queue mapping for PCI device
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq-pci: Remove unneeded includes
2017-04-06 10:33 [PATCH] blk-mq-pci: Remove unneeded includes Sagi Grimberg
@ 2017-04-06 11:51 ` Christoph Hellwig
2017-04-06 11:58 ` Sagi Grimberg
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2017-04-06 11:51 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: Jens Axboe, linux-block, Stephen Rothwell
Stephen added the first two includes after a linux-next build
failure. Did this go through a long buildbot cycle to verify
it's really not needed anymore?
On Thu, Apr 06, 2017 at 01:33:36PM +0300, Sagi Grimberg wrote:
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> block/blk-mq-pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c
> index 0c3354cf3552..70b8a6765cc7 100644
> --- a/block/blk-mq-pci.c
> +++ b/block/blk-mq-pci.c
> @@ -10,12 +10,9 @@
> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> * more details.
> */
> -#include <linux/kobject.h>
> -#include <linux/blkdev.h>
> #include <linux/blk-mq.h>
> #include <linux/blk-mq-pci.h>
> #include <linux/pci.h>
> -#include <linux/module.h>
>
> /**
> * blk_mq_pci_map_queues - provide a default queue mapping for PCI device
> --
> 2.7.4
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-mq-pci: Remove unneeded includes
2017-04-06 11:51 ` Christoph Hellwig
@ 2017-04-06 11:58 ` Sagi Grimberg
0 siblings, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2017-04-06 11:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Jens Axboe, linux-block, Stephen Rothwell
> Stephen added the first two includes after a linux-next build
> failure. Did this go through a long buildbot cycle to verify
> it's really not needed anymore?
Umm no. I just compiled it and ran and it worked...
If these are actually needed then we can safely discard
this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 10:33 [PATCH] blk-mq-pci: Remove unneeded includes Sagi Grimberg
2017-04-06 11:51 ` Christoph Hellwig
2017-04-06 11:58 ` Sagi Grimberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).