[PATCH for-next] blk-mq: fix redundant check of !e expression

[PATCH for-next] blk-mq: fix redundant check of !e expression

[Jεan Sacren]

From: Jean Sacren <sakiwit@gmail.com>

In the if branch, e is checked.  In the else branch, ->dispatch_busy is
merely a number and has no effect on !e.  We should remove the check of
!e since it is always true.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
---
 block/blk-mq-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index 0f006cabfd91..a38d4dd32516 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -502,7 +502,7 @@ void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx,
 		 * busy in case of 'none' scheduler, and this way may save
 		 * us one extra enqueue & dequeue to sw queue.
 		 */
-		if (!hctx->dispatch_busy && !e && !run_queue_async) {
+		if (!hctx->dispatch_busy && !run_queue_async) {
 			blk_mq_try_issue_list_directly(hctx, list);
 			if (list_empty(list))
 				goto out;

Re: [PATCH for-next] blk-mq: fix redundant check of !e expression

[Jens Axboe]

On 10/29/21 2:29 PM, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> In the if branch, e is checked.  In the else branch, ->dispatch_busy is
> merely a number and has no effect on !e.  We should remove the check of
> !e since it is always true.

Applied, thanks.

-- 
Jens Axboe