From: Bart Van Assche <bvanassche@acm.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2] loop: avoid EAGAIN, if offset or block_size are changed
Date: Mon, 25 Nov 2019 11:41:49 -0800 [thread overview]
Message-ID: <baaf9725-09b4-3f2d-1408-ead415f5c20d@acm.org> (raw)
In-Reply-To: <20191125192251.GA76721@jaegeuk-macbookpro.roam.corp.google.com>
On 11/25/19 11:22 AM, Jaegeuk Kim wrote:
> On 11/25, Bart Van Assche wrote:
>> Thank you for the additional and very helpful clarification. Can you have a look at the (totally untested) patch below? I prefer that version because it prevents concurrent processing of requests and syncing/killing the bdev.
>
> Yeah, I thought this was much cleaner way, but wasn't sure it could be doable
> to sync|kill block device after freezing the queue. Is it okay?
Hi Jaegeuk,
That patch was based on an incorrect interpretation of the meaning of
lo_device. After having taken another loop at the block driver, I don't
think that calling sync after freezing the queue is OK. How about using
the following call sequence:
* sync_blockdev()
* blk_mq_freeze_queue()
* kill_bdev()
Thanks,
Bart.
next prev parent reply other threads:[~2019-11-25 19:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 0:47 [PATCH] loop: avoid EAGAIN, if offset or block_size are changed Jaegeuk Kim
2019-05-18 0:53 ` [PATCH v2] " Jaegeuk Kim
2019-06-17 21:08 ` [f2fs-dev] " Jaegeuk Kim
2019-11-18 18:36 ` Andrew Norrie
2019-11-19 4:00 ` Greg KH
2019-11-19 23:40 ` [PATCH v2] " Bart Van Assche
2019-11-25 17:59 ` Jaegeuk Kim
2019-11-25 18:35 ` Bart Van Assche
2019-11-25 19:22 ` Jaegeuk Kim
2019-11-25 19:41 ` Bart Van Assche [this message]
2019-11-25 22:27 ` Bart Van Assche
2019-11-26 18:29 ` Jaegeuk Kim
2019-11-26 18:59 ` Bart Van Assche
2019-11-26 22:32 ` Jaegeuk Kim
2019-11-26 22:54 ` Bart Van Assche
2019-11-27 0:04 ` Jaegeuk Kim
2019-11-27 0:26 ` Bart Van Assche
2019-11-27 1:09 ` Jaegeuk Kim
2019-11-27 16:35 ` Bart Van Assche
2019-11-27 18:17 ` Jaegeuk Kim
2019-11-27 18:18 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2019-11-27 18:54 ` Bart Van Assche
2020-02-19 19:58 ` Andrew Norrie
2020-03-05 21:04 ` [PATCH] " Jan Kara
2019-06-10 21:49 [PATCH v2] loop: avoid EAGAIN, if offset or block size " Francesco Ruggeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baaf9725-09b4-3f2d-1408-ead415f5c20d@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).