* [PATCH] io_uring: fix compilation warning
@ 2019-11-11 19:02 Chaitanya Kulkarni
2019-11-11 21:42 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Kulkarni @ 2019-11-11 19:02 UTC (permalink / raw)
To: linux-block; +Cc: axboe, Chaitanya Kulkarni
This patch fixes following compilation warning :-
fs/io_uring.c: In function ‘io_uring_cancel_files’:
fs/io_uring.c:4280:25: warning: unused variable ‘cancel_req’
[-Wunused-variable]
struct io_kiocb *req, *cancel_req;
^~~~~~~~~~
Fixes: 93ef402a2272 ("io_uring: don't do flush cancel under inflight_lock")
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 283c1ba..55f3dfe 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -4277,7 +4277,7 @@ static int io_uring_release(struct inode *inode, struct file *file)
static void io_uring_cancel_files(struct io_ring_ctx *ctx,
struct files_struct *files)
{
- struct io_kiocb *req, *cancel_req;
+ struct io_kiocb *req;
DEFINE_WAIT(wait);
while (!list_empty_careful(&ctx->inflight_list)) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring: fix compilation warning
2019-11-11 19:02 [PATCH] io_uring: fix compilation warning Chaitanya Kulkarni
@ 2019-11-11 21:42 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-11-11 21:42 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block
On 11/11/19 11:02 AM, Chaitanya Kulkarni wrote:
> This patch fixes following compilation warning :-
>
> fs/io_uring.c: In function ‘io_uring_cancel_files’:
> fs/io_uring.c:4280:25: warning: unused variable ‘cancel_req’
> [-Wunused-variable]
> struct io_kiocb *req, *cancel_req;
> ^~~~~~~~~~
Thanks, I folded in a similar fix last night though.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-11 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-11 19:02 [PATCH] io_uring: fix compilation warning Chaitanya Kulkarni
2019-11-11 21:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).