* [PATCH] blkparse: Print PID information for TN_MESSAGE events
@ 2020-05-13 16:04 Jan Kara
2020-05-19 15:53 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kara @ 2020-05-13 16:04 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Paolo Valente, Jan Kara
The kernel now provides PID information for TN_MESSAGE events. Print it.
Old kernels fill 0 there so the behavior is unaffected for them.
Signed-off-by: Jan Kara <jack@suse.cz>
---
blkparse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blkparse.c b/blkparse.c
index ae4cb4433944..911309e26a15 100644
--- a/blkparse.c
+++ b/blkparse.c
@@ -643,7 +643,7 @@ static void handle_notify(struct blk_io_trace *bit)
MAJOR(bit->device), MINOR(bit->device),
bit->cpu, "0", (int)SECONDS(bit->time),
(unsigned long)NANO_SECONDS(bit->time),
- 0, cgidstr, "m", "N", msg);
+ bit->pid, cgidstr, "m", "N", msg);
}
break;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] blkparse: Print PID information for TN_MESSAGE events
2020-05-13 16:04 [PATCH] blkparse: Print PID information for TN_MESSAGE events Jan Kara
@ 2020-05-19 15:53 ` Jens Axboe
2020-05-20 13:20 ` Jan Kara
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2020-05-19 15:53 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-block, Paolo Valente
On 5/13/20 10:04 AM, Jan Kara wrote:
> The kernel now provides PID information for TN_MESSAGE events. Print it.
> Old kernels fill 0 there so the behavior is unaffected for them.
Doesn't apply to the current repo, can you resend?
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blkparse: Print PID information for TN_MESSAGE events
2020-05-19 15:53 ` Jens Axboe
@ 2020-05-20 13:20 ` Jan Kara
2020-05-20 13:38 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kara @ 2020-05-20 13:20 UTC (permalink / raw)
To: Jens Axboe; +Cc: Jan Kara, linux-block, Paolo Valente
On Tue 19-05-20 09:53:23, Jens Axboe wrote:
> On 5/13/20 10:04 AM, Jan Kara wrote:
> > The kernel now provides PID information for TN_MESSAGE events. Print it.
> > Old kernels fill 0 there so the behavior is unaffected for them.
>
> Doesn't apply to the current repo, can you resend?
Likely because it is based on top of my blkparse fixes to deal with cgroup
information in blktrace events. Did you pick up those? Rebasing this
on-liner is simple enough but I'm just wondering...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blkparse: Print PID information for TN_MESSAGE events
2020-05-20 13:20 ` Jan Kara
@ 2020-05-20 13:38 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-05-20 13:38 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-block, Paolo Valente
On 5/20/20 7:20 AM, Jan Kara wrote:
> On Tue 19-05-20 09:53:23, Jens Axboe wrote:
>> On 5/13/20 10:04 AM, Jan Kara wrote:
>>> The kernel now provides PID information for TN_MESSAGE events. Print it.
>>> Old kernels fill 0 there so the behavior is unaffected for them.
>>
>> Doesn't apply to the current repo, can you resend?
>
> Likely because it is based on top of my blkparse fixes to deal with cgroup
> information in blktrace events. Did you pick up those? Rebasing this
> on-liner is simple enough but I'm just wondering...
Indeed, applied this one too. Thanks!
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-20 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 16:04 [PATCH] blkparse: Print PID information for TN_MESSAGE events Jan Kara
2020-05-19 15:53 ` Jens Axboe
2020-05-20 13:20 ` Jan Kara
2020-05-20 13:38 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).