From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <keith.busch@intel.com>, Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Martin Petersen <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCHv4 0/3] scsi timeout handling updates
Date: Wed, 28 Nov 2018 08:58:00 -0700 [thread overview]
Message-ID: <ddc31c4c-5d5f-c5ca-67bf-33acdd03ed54@kernel.dk> (raw)
In-Reply-To: <20181128154927.GE6401@localhost.localdomain>
On 11/28/18 8:49 AM, Keith Busch wrote:
> On Wed, Nov 28, 2018 at 11:08:48AM +0100, Christoph Hellwig wrote:
>> On Wed, Nov 28, 2018 at 06:07:01PM +0800, Ming Lei wrote:
>>>> Is this the nvme target on top of null_blk?
>>>
>>> Yes.
>>
>> And it goes away if you revert just the last patch?
>
> It looks like a problem existed before that last patch. Reverting it
> helps only if the request happened to have not been reallocated. If it
> had been reallocated, the NULL_IRQ_TIMER would have completed the wrong
> request out-of-order. If this were a real device, that'd probably result
> in data corruption.
null_blk just needs updating for this.
--
Jens Axboe
next prev parent reply other threads:[~2018-11-28 15:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:54 [PATCHv4 0/3] scsi timeout handling updates Keith Busch
2018-11-26 16:54 ` [PATCHv4 1/3] blk-mq: Return true if request was completed Keith Busch
2018-11-26 17:00 ` Christoph Hellwig
2018-11-26 16:54 ` [PATCHv4 2/3] scsi: Do not rely on blk-mq for double completions Keith Busch
2018-11-26 17:01 ` Christoph Hellwig
2018-11-26 16:54 ` [PATCHv4 3/3] blk-mq: Simplify request completion state Keith Busch
2018-11-26 17:01 ` Christoph Hellwig
2018-11-26 17:33 ` [PATCHv4 0/3] scsi timeout handling updates Jens Axboe
2018-11-28 2:20 ` Ming Lei
2018-11-28 7:00 ` Christoph Hellwig
2018-11-28 10:07 ` Ming Lei
2018-11-28 10:08 ` Christoph Hellwig
2018-11-28 15:49 ` Keith Busch
2018-11-28 15:58 ` Jens Axboe [this message]
2018-11-28 16:26 ` Keith Busch
2018-11-28 16:31 ` Jens Axboe
2018-11-28 17:56 ` Keith Busch
2018-11-29 1:18 ` Ming Lei
2018-11-28 22:31 ` Keith Busch
2018-11-28 23:36 ` Keith Busch
2018-11-29 17:11 ` Christoph Hellwig
2018-11-29 17:20 ` Keith Busch
2018-12-28 12:47 ` Hannes Reinecke
2018-11-29 2:15 ` Ming Lei
2018-11-29 2:39 ` Martin K. Petersen
2018-11-29 8:12 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc31c4c-5d5f-c5ca-67bf-33acdd03ed54@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).