linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kashyap Desai <kashyap.desai@broadcom.com>
To: John Garry <john.garry@huawei.com>,
	Hannes Reinecke <hare@suse.de>,
	linux-scsi@vger.kernel.org
Cc: Sumit Saxena <sumit.saxena@broadcom.com>,
	Chandrakanth Patil <chandrakanth.patil@broadcom.com>,
	linux-block@vger.kernel.org
Subject: RE: [PATCH v1 2/3] megaraid_sas: iouring iopoll support
Date: Mon, 30 Nov 2020 14:47:47 +0530	[thread overview]
Message-ID: <ed32d15fb0b00ff255ffa4284710456b@mail.gmail.com> (raw)
In-Reply-To: <2dae79b3-2083-75e0-73fc-ab52c5546bc8@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

> -----Original Message-----
> From: John Garry [mailto:john.garry@huawei.com]
> Sent: Friday, November 20, 2020 2:03 PM
> To: Hannes Reinecke <hare@suse.de>; Kashyap Desai
> <kashyap.desai@broadcom.com>; linux-scsi@vger.kernel.org
> Cc: sumit.saxena@broadcom.com; chandrakanth.patil@broadcom.com;
> linux-block@vger.kernel.org
> Subject: Re: [PATCH v1 2/3] megaraid_sas: iouring iopoll support
>
> On 20/11/2020 07:14, Hannes Reinecke wrote:
> >>
> >>       struct rdpq_alloc_detail rdpq_tracker[RDPQ_MAX_CHUNK_COUNT];
> >>
> > The usage of atomic_add_unless() is a bit unusual; one might consider
> > using atomic_test_and_set(). Also it seems to be a bit of a waste
> > using an atomic counter here, seeing that the only values ever used
> > are 0 and 1. But this is largely cosmetic, so:
>
> atomic_add_unless() is generally implemented with a cmpxchg(), which can
> be inefficient also.


John -

Noted. I was able to get expected performance on multiple host using
atomic_add_() API.
We can improve based on any real time issue.  Is it fine ?

@Hannes - I will add Reviewed-by Tag in V2 series.

>
> John

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4169 bytes --]

  reply	other threads:[~2020-11-30  9:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 13:37 [PATCH v1 2/3] megaraid_sas: iouring iopoll support Kashyap Desai
2020-10-15 20:44 ` kernel test robot
2020-11-13 10:48 ` Kashyap Desai
2020-11-13 11:56 ` chenxiang (M)
2020-11-20  7:14 ` Hannes Reinecke
2020-11-20  8:32   ` John Garry
2020-11-30  9:17     ` Kashyap Desai [this message]
2020-11-30  9:40       ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed32d15fb0b00ff255ffa4284710456b@mail.gmail.com \
    --to=kashyap.desai@broadcom.com \
    --cc=chandrakanth.patil@broadcom.com \
    --cc=hare@suse.de \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).