From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH] dm: fix request-based dm's use of dm_wait_for_completion
Date: Tue, 11 Dec 2018 07:40:22 -0700 [thread overview]
Message-ID: <f005f3db-a281-1de8-08c1-89464e28b375@kernel.dk> (raw)
In-Reply-To: <20181211141026.30174-1-snitzer@redhat.com>
On 12/11/18 7:10 AM, Mike Snitzer wrote:
> The md->wait waitqueue is used by both bio-based and request-based DM.
> Commit dbd3bbd291 ("dm rq: leverage blk_mq_queue_busy() to check for
> outstanding IO") lost sight of the requirement that
> dm_wait_for_completion() must work with all types of DM devices.
>
> Fix md_in_flight() to call the blk-mq or bio-based method accordingly.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2018-12-11 14:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 14:10 [PATCH] dm: fix request-based dm's use of dm_wait_for_completion Mike Snitzer
2018-12-11 14:40 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f005f3db-a281-1de8-08c1-89464e28b375@kernel.dk \
--to=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).