* [PATCH] dm: fix request-based dm's use of dm_wait_for_completion
@ 2018-12-11 14:10 Mike Snitzer
2018-12-11 14:40 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Mike Snitzer @ 2018-12-11 14:10 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, dm-devel
The md->wait waitqueue is used by both bio-based and request-based DM.
Commit dbd3bbd291 ("dm rq: leverage blk_mq_queue_busy() to check for
outstanding IO") lost sight of the requirement that
dm_wait_for_completion() must work with all types of DM devices.
Fix md_in_flight() to call the blk-mq or bio-based method accordingly.
Fixes: dbd3bbd291 ("dm rq: leverage blk_mq_queue_busy() to check for outstanding IO")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-rq.c | 6 ++----
drivers/md/dm.c | 10 +++++++++-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c
index 5af22e165fb7..202e9be5aea7 100644
--- a/drivers/md/dm-rq.c
+++ b/drivers/md/dm-rq.c
@@ -131,10 +131,8 @@ static void rq_end_stats(struct mapped_device *md, struct request *orig)
static void rq_completed(struct mapped_device *md)
{
/* nudge anyone waiting on suspend queue */
- if (unlikely(waitqueue_active(&md->wait))) {
- if (!blk_mq_queue_busy(md->queue))
- wake_up(&md->wait);
- }
+ if (unlikely(waitqueue_active(&md->wait)))
+ wake_up(&md->wait);
/*
* dm_put() must be at the end of this function. See the comment above
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index d80c34a34a2d..3a50675cfc1a 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -646,7 +646,7 @@ static void free_tio(struct dm_target_io *tio)
bio_put(&tio->clone);
}
-static bool md_in_flight(struct mapped_device *md)
+static bool md_in_flight_bios(struct mapped_device *md)
{
int cpu;
struct hd_struct *part = &dm_disk(md)->part0;
@@ -660,6 +660,14 @@ static bool md_in_flight(struct mapped_device *md)
return sum != 0;
}
+static bool md_in_flight(struct mapped_device *md)
+{
+ if (queue_is_mq(md->queue))
+ return blk_mq_queue_busy(md->queue);
+ else
+ return md_in_flight_bios(md);
+}
+
static void start_io_acct(struct dm_io *io)
{
struct mapped_device *md = io->md;
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dm: fix request-based dm's use of dm_wait_for_completion
2018-12-11 14:10 [PATCH] dm: fix request-based dm's use of dm_wait_for_completion Mike Snitzer
@ 2018-12-11 14:40 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-12-11 14:40 UTC (permalink / raw)
To: Mike Snitzer; +Cc: linux-block, dm-devel
On 12/11/18 7:10 AM, Mike Snitzer wrote:
> The md->wait waitqueue is used by both bio-based and request-based DM.
> Commit dbd3bbd291 ("dm rq: leverage blk_mq_queue_busy() to check for
> outstanding IO") lost sight of the requirement that
> dm_wait_for_completion() must work with all types of DM devices.
>
> Fix md_in_flight() to call the blk-mq or bio-based method accordingly.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-11 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-11 14:10 [PATCH] dm: fix request-based dm's use of dm_wait_for_completion Mike Snitzer
2018-12-11 14:40 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).