Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
@ 2019-10-03  2:23 Randy Dunlap
  2019-10-03 15:42 ` Scott Bauer
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Randy Dunlap @ 2019-10-03  2:23 UTC (permalink / raw)
  To: linux-block, LKML; +Cc: axboe, Jonas Rabenstein, David Kozub

From: Randy Dunlap <rdunlap@infradead.org>

Fix sparse warning: (missing '=')
../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax

Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Cc: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
Cc: David Kozub <zub@linux.fjfi.cvut.cz>
---
 block/sed-opal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-54-rc1.orig/block/sed-opal.c
+++ lnx-54-rc1/block/sed-opal.c
@@ -129,7 +129,7 @@ static const u8 opaluid[][OPAL_UID_LENGT
 		{ 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x84, 0x01 },
 
 	/* tables */
-	[OPAL_TABLE_TABLE]
+	[OPAL_TABLE_TABLE] =
 		{ 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01 },
 	[OPAL_LOCKINGRANGE_GLOBAL] =
 		{ 0x00, 0x00, 0x08, 0x02, 0x00, 0x00, 0x00, 0x01 },


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
  2019-10-03  2:23 [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init Randy Dunlap
@ 2019-10-03 15:42 ` Scott Bauer
  2019-10-03 15:57   ` Rajashekar, Revanth
  2019-10-03 16:01   ` Rajashekar, Revanth
  2019-10-03 16:51 ` Derrick, Jonathan
  2019-10-03 20:22 ` Jens Axboe
  2 siblings, 2 replies; 6+ messages in thread
From: Scott Bauer @ 2019-10-03 15:42 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-block, LKML, axboe, Scott Bauer, jonathan.derrick,
	revanth.rajashekar

On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
> 
> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Cc: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> Cc: David Kozub <zub@linux.fjfi.cvut.cz>
> ---

Un cc'd David and Jonas, +CC'd Jon and Revanth.

This looks fine to me too.

Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
  2019-10-03 15:42 ` Scott Bauer
@ 2019-10-03 15:57   ` Rajashekar, Revanth
  2019-10-03 16:01   ` Rajashekar, Revanth
  1 sibling, 0 replies; 6+ messages in thread
From: Rajashekar, Revanth @ 2019-10-03 15:57 UTC (permalink / raw)
  To: Scott Bauer, Randy Dunlap; +Cc: linux-block, LKML, axboe, jonathan.derrick


On 10/3/2019 9:42 AM, Scott Bauer wrote:
> On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix sparse warning: (missing '=')
>> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>>
>> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-block@vger.kernel.org
>> Cc: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>> Cc: David Kozub <zub@linux.fjfi.cvut.cz>
>> ---
> Un cc'd David and Jonas, +CC'd Jon and Revanth.
>
> This looks fine to me too.
>
> Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>

Looks fine to me as well

Reviewed-by:  Revanth Rajashekar <revanth.rajashekar@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
  2019-10-03 15:42 ` Scott Bauer
  2019-10-03 15:57   ` Rajashekar, Revanth
@ 2019-10-03 16:01   ` Rajashekar, Revanth
  1 sibling, 0 replies; 6+ messages in thread
From: Rajashekar, Revanth @ 2019-10-03 16:01 UTC (permalink / raw)
  To: Scott Bauer, Randy Dunlap; +Cc: linux-block, LKML, axboe, jonathan.derrick


On 10/3/2019 9:42 AM, Scott Bauer wrote:
> On Wed, Oct 02, 2019 at 07:23:05PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix sparse warning: (missing '=')
>> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
>>
>> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Jens Axboe <axboe@kernel.dk>
>> Cc: linux-block@vger.kernel.org
>> Cc: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
>> Cc: David Kozub <zub@linux.fjfi.cvut.cz>
>> ---
> Un cc'd David and Jonas, +CC'd Jon and Revanth.
>
> This looks fine to me too.
>
> Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>

the patch set looks fine for me

Reviewed-by:  Revanth Rajashekar <revanth.rajashekar@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
  2019-10-03  2:23 [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init Randy Dunlap
  2019-10-03 15:42 ` Scott Bauer
@ 2019-10-03 16:51 ` Derrick, Jonathan
  2019-10-03 20:22 ` Jens Axboe
  2 siblings, 0 replies; 6+ messages in thread
From: Derrick, Jonathan @ 2019-10-03 16:51 UTC (permalink / raw)
  To: rdunlap, linux-kernel, linux-block; +Cc: zub, jonas.rabenstein, axboe

On Wed, 2019-10-02 at 19:23 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax
> 
> Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Cc: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de>
> Cc: David Kozub <zub@linux.fjfi.cvut.cz>
> ---
>  block/sed-opal.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-54-rc1.orig/block/sed-opal.c
> +++ lnx-54-rc1/block/sed-opal.c
> @@ -129,7 +129,7 @@ static const u8 opaluid[][OPAL_UID_LENGT
>  		{ 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x84, 0x01 },
>  
>  	/* tables */
> -	[OPAL_TABLE_TABLE]
> +	[OPAL_TABLE_TABLE] =
>  		{ 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01 },
>  	[OPAL_LOCKINGRANGE_GLOBAL] =
>  		{ 0x00, 0x00, 0x08, 0x02, 0x00, 0x00, 0x00, 0x01 },
> 

Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init.
  2019-10-03  2:23 [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init Randy Dunlap
  2019-10-03 15:42 ` Scott Bauer
  2019-10-03 16:51 ` Derrick, Jonathan
@ 2019-10-03 20:22 ` Jens Axboe
  2 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2019-10-03 20:22 UTC (permalink / raw)
  To: Randy Dunlap, linux-block, LKML; +Cc: Jonas Rabenstein, David Kozub

On 10/2/19 8:23 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix sparse warning: (missing '=')
> ../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax

Applied this (and 2/2, no cover letter...), thanks Randy.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-03  2:23 [PATCH 1/2] block: sed-opal: fix sparse warning: obsolete array init Randy Dunlap
2019-10-03 15:42 ` Scott Bauer
2019-10-03 15:57   ` Rajashekar, Revanth
2019-10-03 16:01   ` Rajashekar, Revanth
2019-10-03 16:51 ` Derrick, Jonathan
2019-10-03 20:22 ` Jens Axboe

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git