linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Ming Lei <ming.lei@redhat.com>,
	"chenxiang (M)" <chenxiang66@hisilicon.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>,
	Steffen Maier <maier@linux.ibm.com>
Subject: Re: DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT
Date: Wed, 5 Dec 2018 15:27:09 +0000	[thread overview]
Message-ID: <fe72aef6-d313-5f02-7c0e-0eea28e86582@huawei.com> (raw)
In-Reply-To: <yq1ftvcsoes.fsf@oracle.com>

On 05/12/2018 02:22, Martin K. Petersen wrote:
>

Hi Martin,

> John,
>
>> OK, great. Happy to help. So far we have hisi_sas fio issue to go on
>> plus knowledge that this issue seems to be exposed/triggered by
>> enabling SCSI MQ.
>
> I'll have to go revisit the archives for your exact fio bits.
>
> But I successfully ran our DIX/T10 PI qualification tooling without any
> errors on the latest SCSI tree. On both scsi_debug and FC hardware.

I'm not fimilar with this tooling. Is it internal to your company?

Unfortunately it seems that no other SAS HBA kernel driver supports DIX, 
so we have nothing to test against for this transport.

>
>> My colleague chenxiang also tried DIF on 3008 with our same platform,
>> and we are seeing an issue there also; here's a snippet:
>
> Reproduced this. Turns out to be a recently introduced bug that
> exclusively affects DIF-only setups (so primarily mpt3sas due to lack of
> DIX support). It's a regression caused by a commit that went in through
> block a few months ago. I'll send a patch...
>

ok, great.

thanks,
John


  reply	other threads:[~2018-12-05 15:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  9:55 DIF/DIX issue related to config CONFIG_SCSI_MQ_DEFAULT chenxiang (M)
2018-11-27 13:08 ` Ming Lei
2018-11-28  3:37   ` chenxiang (M)
2018-11-29 18:17     ` Ming Lei
     [not found]   ` <6c573f36-60d8-0631-e9ac-dacd72f6c8ad@hisilicon.com>
2018-11-29  0:54     ` Ming Lei
2018-11-30  1:19     ` Ming Lei
2018-11-30 11:26       ` John Garry
2018-12-04  3:55         ` Martin K. Petersen
     [not found]           ` <45193ec6-6398-3953-4833-88ca2057971a@huawei.com>
2018-12-05  2:22             ` Martin K. Petersen
2018-12-05 15:27               ` John Garry [this message]
2018-12-06  4:22                 ` Martin K. Petersen
2018-12-06 17:33                   ` John Garry
2018-12-07  3:20                     ` Martin K. Petersen
2018-12-05  2:56       ` Martin K. Petersen
2018-11-27 20:22 ` Ewan D. Milne
2018-11-28  3:11   ` chenxiang (M)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe72aef6-d313-5f02-7c0e-0eea28e86582@huawei.com \
    --to=john.garry@huawei.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=maier@linux.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).