* [PATCH] Bluetooth: SMP: Fix SALT value in some comments
@ 2020-01-27 22:36 Christophe JAILLET
2020-01-28 7:03 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-01-27 22:36 UTC (permalink / raw)
To: marcel, johan.hedberg, kuba, davem
Cc: linux-bluetooth, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
Salts are 16 bytes long.
Remove some extra and erroneous '0' in the human readable format used
in comments.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/bluetooth/smp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c
index 4ece170c518e..a2e9492391fe 100644
--- a/net/bluetooth/smp.c
+++ b/net/bluetooth/smp.c
@@ -1145,7 +1145,7 @@ static void sc_generate_link_key(struct smp_chan *smp)
return;
if (test_bit(SMP_FLAG_CT2, &smp->flags)) {
- /* SALT = 0x00000000000000000000000000000000746D7031 */
+ /* SALT = 0x000000000000000000000000746D7031 */
const u8 salt[16] = { 0x31, 0x70, 0x6d, 0x74 };
if (smp_h7(smp->tfm_cmac, smp->tk, salt, smp->link_key)) {
@@ -1203,7 +1203,7 @@ static void sc_generate_ltk(struct smp_chan *smp)
set_bit(SMP_FLAG_DEBUG_KEY, &smp->flags);
if (test_bit(SMP_FLAG_CT2, &smp->flags)) {
- /* SALT = 0x00000000000000000000000000000000746D7032 */
+ /* SALT = 0x000000000000000000000000746D7032 */
const u8 salt[16] = { 0x32, 0x70, 0x6d, 0x74 };
if (smp_h7(smp->tfm_cmac, key->val, salt, smp->tk))
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: SMP: Fix SALT value in some comments
2020-01-27 22:36 [PATCH] Bluetooth: SMP: Fix SALT value in some comments Christophe JAILLET
@ 2020-01-28 7:03 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-01-28 7:03 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Johan Hedberg, kuba, David S. Miller, linux-bluetooth, netdev,
linux-kernel, kernel-janitors
Hi Christophe,
> Salts are 16 bytes long.
> Remove some extra and erroneous '0' in the human readable format used
> in comments.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> net/bluetooth/smp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-28 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-27 22:36 [PATCH] Bluetooth: SMP: Fix SALT value in some comments Christophe JAILLET
2020-01-28 7:03 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).