* [PATCH v2] Bluetooth: refactor malicious adv data check
@ 2021-11-24 20:16 Brian Gix
2021-11-24 20:46 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Brian Gix @ 2021-11-24 20:16 UTC (permalink / raw)
To: linux-bluetooth; +Cc: marcel, paskripkin, Brian Gix
Check for out-of-bound read was being performed at the end of while
num_reports loop, and would fill journal with false positives. Added
check to beginning of loop processing so that it doesn't get checked
after ptr has been advanced.
Signed-off-by: Brian Gix <brian.gix@intel.com>
---
net/bluetooth/hci_event.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index efc5458b1345..dee4ef22fc88 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -5920,6 +5920,11 @@ static void hci_le_adv_report_evt(struct hci_dev *hdev, struct sk_buff *skb)
struct hci_ev_le_advertising_info *ev = ptr;
s8 rssi;
+ if (ptr > (void *)skb_tail_pointer(skb) - sizeof(*ev)) {
+ bt_dev_err(hdev, "Malicious advertising data.");
+ break;
+ }
+
if (ev->length <= HCI_MAX_AD_LENGTH &&
ev->data + ev->length <= skb_tail_pointer(skb)) {
rssi = ev->data[ev->length];
@@ -5931,11 +5936,6 @@ static void hci_le_adv_report_evt(struct hci_dev *hdev, struct sk_buff *skb)
}
ptr += sizeof(*ev) + ev->length + 1;
-
- if (ptr > (void *) skb_tail_pointer(skb) - sizeof(*ev)) {
- bt_dev_err(hdev, "Malicious advertising data. Stopping processing");
- break;
- }
}
hci_dev_unlock(hdev);
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Bluetooth: refactor malicious adv data check
2021-11-24 20:16 [PATCH v2] Bluetooth: refactor malicious adv data check Brian Gix
@ 2021-11-24 20:46 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-11-24 20:46 UTC (permalink / raw)
To: Brian Gix; +Cc: linux-bluetooth, paskripkin
Hi Brian,
> Check for out-of-bound read was being performed at the end of while
> num_reports loop, and would fill journal with false positives. Added
> check to beginning of loop processing so that it doesn't get checked
> after ptr has been advanced.
>
> Signed-off-by: Brian Gix <brian.gix@intel.com>
> ---
> net/bluetooth/hci_event.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-24 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 20:16 [PATCH v2] Bluetooth: refactor malicious adv data check Brian Gix
2021-11-24 20:46 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).