* [PATCH] Bluetooth: btusb: print FW version after FW download
@ 2019-09-27 2:51 Amit K Bag
2019-09-27 2:51 ` [PATCH v2] " Amit K Bag
0 siblings, 1 reply; 6+ messages in thread
From: Amit K Bag @ 2019-09-27 2:51 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ravishankar.srivatsa, chethan.tumkur.narayan, Amit K Bag
After FW download there is no print to confirm the current
FW version. Add print to check FW version incase of FW download.
Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
---
drivers/bluetooth/btusb.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9c35ebb30f8..f6c033b5042c 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
*/
btintel_set_event_mask(hdev, false);
+ /* Read the Intel version information after loading the FW */
+ err = btintel_read_version(hdev, &ver);
+ if (err)
+ return err;
+
+ btintel_version_info(hdev, &ver);
+ bt_dev_info(hdev, "Setup complete");
+
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] Bluetooth: btusb: print FW version after FW download
2019-09-27 2:51 [PATCH] Bluetooth: btusb: print FW version after FW download Amit K Bag
@ 2019-09-27 2:51 ` Amit K Bag
2019-09-27 6:26 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: Amit K Bag @ 2019-09-27 2:51 UTC (permalink / raw)
To: linux-bluetooth
Cc: ravishankar.srivatsa, chethan.tumkur.narayan, Amit K Bag, Yoni Shavit
After FW download there is no print to confirm the current
FW version. Add print to check FW version incase of FW download.
Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
Signed-off-by: Yoni Shavit <yshavit@chromium.org>
Signed-off-by: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
---
drivers/bluetooth/btusb.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9c35ebb30f8..270e892c7c8f 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2432,6 +2432,13 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
*/
btintel_set_event_mask(hdev, false);
+ /* Read the Intel version information after loading the FW */
+ err = btintel_read_version(hdev, &ver);
+ if (err)
+ return err;
+
+ btintel_version_info(hdev, &ver);
+
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] Bluetooth: btusb: print FW version after FW download
2019-09-27 2:51 ` [PATCH v2] " Amit K Bag
@ 2019-09-27 6:26 ` Marcel Holtmann
0 siblings, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2019-09-27 6:26 UTC (permalink / raw)
To: Amit K Bag
Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan,
Yoni Shavit
Hi Amit,
> After FW download there is no print to confirm the current
> FW version. Add print to check FW version incase of FW download.
>
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> Signed-off-by: Yoni Shavit <yshavit@chromium.org>
> Signed-off-by: Chethan Tumkur Narayan <chethan.tumkur.narayan@intel.com>
> ---
> drivers/bluetooth/btusb.c | 7 +++++++
> 1 file changed, 7 insertions(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Bluetooth: btusb: print FW version after FW download
2019-09-26 6:25 ` Marcel Holtmann
@ 2019-09-27 2:49 ` Bag, Amit K
0 siblings, 0 replies; 6+ messages in thread
From: Bag, Amit K @ 2019-09-27 2:49 UTC (permalink / raw)
To: Marcel Holtmann
Cc: linux-bluetooth, Srivatsa, Ravishankar, Tumkur Narayan, Chethan
>Hi Amit,
>
>> After FW download there is no print to confirm the current FW version.
>> Add print to check FW version incase of FW download.
>>
>> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
>> ---
>> drivers/bluetooth/btusb.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index a9c35ebb30f8..f6c033b5042c 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
>> */
>> btintel_set_event_mask(hdev, false);
>>
>> + /* Read the Intel version information after loading the FW */
>> + err = btintel_read_version(hdev, &ver);
>> + if (err)
>> + return err;
>> +
>> + btintel_version_info(hdev, &ver);
>> + bt_dev_info(hdev, "Setup complete");
>> +
>
>I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.
>
I will remove this message and post the revised patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Bluetooth: btusb: print FW version after FW download
2019-09-25 10:03 [PATCH] " Amit K Bag
@ 2019-09-26 6:25 ` Marcel Holtmann
2019-09-27 2:49 ` Bag, Amit K
0 siblings, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2019-09-26 6:25 UTC (permalink / raw)
To: Amit K Bag; +Cc: linux-bluetooth, ravishankar.srivatsa, chethan.tumkur.narayan
Hi Amit,
> After FW download there is no print to confirm the current
> FW version. Add print to check FW version incase of FW download.
>
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> ---
> drivers/bluetooth/btusb.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index a9c35ebb30f8..f6c033b5042c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
> */
> btintel_set_event_mask(hdev, false);
>
> + /* Read the Intel version information after loading the FW */
> + err = btintel_read_version(hdev, &ver);
> + if (err)
> + return err;
> +
> + btintel_version_info(hdev, &ver);
> + bt_dev_info(hdev, "Setup complete");
> +
I rather not add an extra Setup complete since that is rather noisy. We can add the extra version information if that adds value.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Bluetooth: btusb: print FW version after FW download
@ 2019-09-25 10:03 Amit K Bag
2019-09-26 6:25 ` Marcel Holtmann
0 siblings, 1 reply; 6+ messages in thread
From: Amit K Bag @ 2019-09-25 10:03 UTC (permalink / raw)
To: linux-bluetooth; +Cc: ravishankar.srivatsa, chethan.tumkur.narayan, Amit K Bag
After FW download there is no print to confirm the current
FW version. Add print to check FW version incase of FW download.
Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
---
drivers/bluetooth/btusb.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a9c35ebb30f8..f6c033b5042c 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2432,6 +2432,14 @@ static int btusb_setup_intel_new(struct hci_dev *hdev)
*/
btintel_set_event_mask(hdev, false);
+ /* Read the Intel version information after loading the FW */
+ err = btintel_read_version(hdev, &ver);
+ if (err)
+ return err;
+
+ btintel_version_info(hdev, &ver);
+ bt_dev_info(hdev, "Setup complete");
+
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-27 6:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 2:51 [PATCH] Bluetooth: btusb: print FW version after FW download Amit K Bag
2019-09-27 2:51 ` [PATCH v2] " Amit K Bag
2019-09-27 6:26 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 10:03 [PATCH] " Amit K Bag
2019-09-26 6:25 ` Marcel Holtmann
2019-09-27 2:49 ` Bag, Amit K
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).