linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] Bluetooth: use memset avoid memory leaks
@ 2022-06-07 15:30 Xiaohui Zhang
  2022-06-07 16:08 ` [1/1] " bluez.test.bot
  2022-06-08 17:00 ` [PATCH 1/1] " patchwork-bot+bluetooth
  0 siblings, 2 replies; 3+ messages in thread
From: Xiaohui Zhang @ 2022-06-07 15:30 UTC (permalink / raw)
  To: Xiaohui Zhang, Marcel Holtmann, Johan Hedberg,
	Luiz Augusto von Dentz, David S . Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, linux-bluetooth, netdev,
	linux-kernel
  Cc: Xiaohui Zhang

From: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>

Similar to the handling of l2cap_ecred_connect in commit d3715b2333e9
("Bluetooth: use memset avoid memory leaks"), we thought a patch
might be needed here as well.

Use memset to initialize structs to prevent memory leaks
in l2cap_le_connect

Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
---
 net/bluetooth/l2cap_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index ae78490ecd3d..09ecaf556de5 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -1369,6 +1369,7 @@ static void l2cap_le_connect(struct l2cap_chan *chan)
 
 	l2cap_le_flowctl_init(chan, 0);
 
+	memset(&req, 0, sizeof(req));
 	req.psm     = chan->psm;
 	req.scid    = cpu_to_le16(chan->scid);
 	req.mtu     = cpu_to_le16(chan->imtu);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [1/1] Bluetooth: use memset avoid memory leaks
  2022-06-07 15:30 [PATCH 1/1] Bluetooth: use memset avoid memory leaks Xiaohui Zhang
@ 2022-06-07 16:08 ` bluez.test.bot
  2022-06-08 17:00 ` [PATCH 1/1] " patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-06-07 16:08 UTC (permalink / raw)
  To: linux-bluetooth, ruc_zhangxiaohui

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=648077

---Test result---

Test Summary:
CheckPatch                    PASS      1.70 seconds
GitLint                       PASS      1.05 seconds
SubjectPrefix                 PASS      0.96 seconds
BuildKernel                   PASS      37.83 seconds
BuildKernel32                 PASS      33.95 seconds
Incremental Build with patchesPASS      47.39 seconds
TestRunner: Setup             PASS      565.52 seconds
TestRunner: l2cap-tester      PASS      19.79 seconds
TestRunner: bnep-tester       PASS      7.36 seconds
TestRunner: mgmt-tester       PASS      114.34 seconds
TestRunner: rfcomm-tester     PASS      10.98 seconds
TestRunner: sco-tester        PASS      10.72 seconds
TestRunner: smp-tester        PASS      10.86 seconds
TestRunner: userchan-tester   PASS      7.54 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Bluetooth: use memset avoid memory leaks
  2022-06-07 15:30 [PATCH 1/1] Bluetooth: use memset avoid memory leaks Xiaohui Zhang
  2022-06-07 16:08 ` [1/1] " bluez.test.bot
@ 2022-06-08 17:00 ` patchwork-bot+bluetooth
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2022-06-08 17:00 UTC (permalink / raw)
  To: Xiaohui Zhang
  Cc: marcel, johan.hedberg, luiz.dentz, davem, edumazet, kuba, pabeni,
	linux-bluetooth, netdev, linux-kernel, xiaohuizhang

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <marcel@holtmann.org>:

On Tue,  7 Jun 2022 23:30:20 +0800 you wrote:
> From: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
> 
> Similar to the handling of l2cap_ecred_connect in commit d3715b2333e9
> ("Bluetooth: use memset avoid memory leaks"), we thought a patch
> might be needed here as well.
> 
> Use memset to initialize structs to prevent memory leaks
> in l2cap_le_connect
> 
> [...]

Here is the summary with links:
  - [1/1] Bluetooth: use memset avoid memory leaks
    https://git.kernel.org/bluetooth/bluetooth-next/c/0b537674e072

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-08 17:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-07 15:30 [PATCH 1/1] Bluetooth: use memset avoid memory leaks Xiaohui Zhang
2022-06-07 16:08 ` [1/1] " bluez.test.bot
2022-06-08 17:00 ` [PATCH 1/1] " patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).