* [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set
@ 2023-06-01 23:33 Luiz Augusto von Dentz
2023-06-01 23:33 ` [PATCH BlueZ 2/2] shared/bap: Don't overwrite attribute declaration Luiz Augusto von Dentz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2023-06-01 23:33 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If PID is not set don't print anything since this is likely a packet
originated by the kernel itself.
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/packet.c b/monitor/packet.c
index 946ceb2c640d..6d73e5abfcbc 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -438,7 +438,7 @@ static void print_packet(struct timeval *tv, struct ucred *cred, char ident,
pos += n;
}
- if (cred) {
+ if (cred && cred->pid) {
cred_pid(cred, pid_str, sizeof(pid_str));
n = sprintf(line + pos, "%s: %c %s", pid_str, ident,
label ? label : "");
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH BlueZ 2/2] shared/bap: Don't overwrite attribute declaration
2023-06-01 23:33 [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set Luiz Augusto von Dentz
@ 2023-06-01 23:33 ` Luiz Augusto von Dentz
2023-06-02 0:48 ` [BlueZ,1/2] monitor: Only print credentials if PID is set bluez.test.bot
2023-06-02 19:50 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2023-06-01 23:33 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
The attribute declaration (e.g. characteristic properties) shall not be
overwritten as they are part of the information that is part of the
cache beside the same information is already stored as part of the
bt_bap instance.
---
src/shared/bap.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/src/shared/bap.c b/src/shared/bap.c
index 26f41be768e9..86c2634472fb 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -3077,9 +3077,6 @@ static void read_source_pac_loc(bool success, uint8_t att_ecode,
pacs->source_loc_value = get_le32(value);
- gatt_db_attribute_write(pacs->source_loc, 0, value, length, 0, NULL,
- NULL, NULL);
-
/* Resume reading sinks if supported but for some reason is empty */
if (pacs->source && queue_isempty(bap->rdb->sources)) {
uint16_t value_handle;
@@ -3113,9 +3110,6 @@ static void read_sink_pac_loc(bool success, uint8_t att_ecode,
pacs->sink_loc_value = get_le32(value);
- gatt_db_attribute_write(pacs->sink_loc, 0, value, length, 0, NULL,
- NULL, NULL);
-
/* Resume reading sinks if supported but for some reason is empty */
if (pacs->sink && queue_isempty(bap->rdb->sinks)) {
uint16_t value_handle;
@@ -3149,9 +3143,6 @@ static void read_pac_context(bool success, uint8_t att_ecode,
pacs->sink_context_value = le16_to_cpu(ctx->snk);
pacs->source_context_value = le16_to_cpu(ctx->src);
-
- gatt_db_attribute_write(pacs->context, 0, value, length, 0, NULL,
- NULL, NULL);
}
static void read_pac_supported_context(bool success, uint8_t att_ecode,
@@ -3175,9 +3166,6 @@ static void read_pac_supported_context(bool success, uint8_t att_ecode,
pacs->supported_sink_context_value = le16_to_cpu(ctx->snk);
pacs->supported_source_context_value = le16_to_cpu(ctx->src);
-
- gatt_db_attribute_write(pacs->supported_context, 0, value, length, 0,
- NULL, NULL, NULL);
}
static void foreach_pacs_char(struct gatt_db_attribute *attr, void *user_data)
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [BlueZ,1/2] monitor: Only print credentials if PID is set
2023-06-01 23:33 [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set Luiz Augusto von Dentz
2023-06-01 23:33 ` [PATCH BlueZ 2/2] shared/bap: Don't overwrite attribute declaration Luiz Augusto von Dentz
@ 2023-06-02 0:48 ` bluez.test.bot
2023-06-02 19:50 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2023-06-02 0:48 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=753319
---Test result---
Test Summary:
CheckPatch PASS 1.05 seconds
GitLint PASS 0.74 seconds
BuildEll PASS 27.23 seconds
BluezMake PASS 889.25 seconds
MakeCheck PASS 12.26 seconds
MakeDistcheck PASS 155.68 seconds
CheckValgrind PASS 252.09 seconds
CheckSmatch WARNING 341.89 seconds
bluezmakeextell PASS 103.28 seconds
IncrementalBuild PASS 1456.56 seconds
ScanBuild PASS 1036.99 seconds
Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
monitor/packet.c: note: in included file:monitor/display.h:82:26: warning: Variable length array is used.monitor/packet.c:1832:26: warning: Variable length array is used.monitor/packet.c: note: in included file:monitor/bt.h:3552:52: warning: array of flexible structuresmonitor/bt.h:3540:40: warning: array of flexible structures
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set
2023-06-01 23:33 [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set Luiz Augusto von Dentz
2023-06-01 23:33 ` [PATCH BlueZ 2/2] shared/bap: Don't overwrite attribute declaration Luiz Augusto von Dentz
2023-06-02 0:48 ` [BlueZ,1/2] monitor: Only print credentials if PID is set bluez.test.bot
@ 2023-06-02 19:50 ` patchwork-bot+bluetooth
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2023-06-02 19:50 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hello:
This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 1 Jun 2023 16:33:16 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If PID is not set don't print anything since this is likely a packet
> originated by the kernel itself.
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [BlueZ,1/2] monitor: Only print credentials if PID is set
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f84979c1591f
- [BlueZ,2/2] shared/bap: Don't overwrite attribute declaration
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=52477e80fc89
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-02 19:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-01 23:33 [PATCH BlueZ 1/2] monitor: Only print credentials if PID is set Luiz Augusto von Dentz
2023-06-01 23:33 ` [PATCH BlueZ 2/2] shared/bap: Don't overwrite attribute declaration Luiz Augusto von Dentz
2023-06-02 0:48 ` [BlueZ,1/2] monitor: Only print credentials if PID is set bluez.test.bot
2023-06-02 19:50 ` [PATCH BlueZ 1/2] " patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).