From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, linux-sunxi@googlegroups.com,
Loic Poulain <loic.poulain@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 06/15] Bluetooth: hci_bcm: Simplify clk_get error handling
Date: Wed, 7 Nov 2018 10:51:19 +0000 [thread overview]
Message-ID: <20181107105119.GT30658@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181107101308.7626-7-wens@csie.org>
On Wed, Nov 07, 2018 at 06:12:59PM +0800, Chen-Yu Tsai wrote:
> @@ -911,6 +911,10 @@ static int bcm_get_resources(struct bcm_device *dev)
> if (IS_ERR(dev->clk) && PTR_ERR(dev->clk) == -EPROBE_DEFER)
You can also simplify the above test to:
if (dev->clk == ERR_PTR(-EPROBE_DEFER))
as error pointers are uniquely different from normal pointers.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2018-11-07 10:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:12 [PATCH 00/15] ARM: sunxi: Enable Broadcom-based Bluetooth controllers Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 01/15] dt-bindings: net: broadcom-bluetooth: Fix external clock names Chen-Yu Tsai
[not found] ` <5bea0ebe.1c69fb81.e15d7.98e1@mx.google.com>
2018-11-14 3:15 ` Chen-Yu Tsai
2018-11-14 15:51 ` Rob Herring
2018-11-14 16:13 ` Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 02/15] dt-bindings: net: broadcom-bluetooth: Add VBAT and VDDIO supplies Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 03/15] dt-bindings: net: broadcom-bluetooth: Add BCM20702A1 compatible string Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 04/15] dt-bindings: net: broadcom-bluetooth: Add BCM4330 " Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 05/15] Bluetooth: hci_bcm: Handle deferred probing for the clock supply Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 06/15] Bluetooth: hci_bcm: Simplify clk_get error handling Chen-Yu Tsai
2018-11-07 10:51 ` Russell King - ARM Linux [this message]
2018-11-07 10:13 ` [PATCH 07/15] Bluetooth: hci_bcm: Use "txco" and "extclk" to get clock reference Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 08/15] Bluetooth: hci_bcm: Add support for LPO clock Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 09/15] Bluetooth: hci_bcm: Add support for regulator supplies Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 10/15] Bluetooth: hci_bcm: Wait for device to come out of reset after power on Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 11/15] Bluetooth: hci_bcm: Add BCM20702A1 variant Chen-Yu Tsai
2018-11-07 20:36 ` Maxime Ripard
2018-11-08 6:53 ` Chen-Yu Tsai
2018-11-08 8:21 ` Maxime Ripard
2018-11-07 10:13 ` [PATCH 12/15] Bluetooth: hci_bcm: Add compatible string for BCM4330 Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 13/15] Bluetooth: btbcm: Add default address for BCM43430A0 Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 14/15] ARM: dts: sunxi: Enable Broadcom-based Bluetooth for multiple boards Chen-Yu Tsai
2018-11-08 8:24 ` Maxime Ripard
2018-11-14 5:06 ` Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 15/15] arm64: dts: allwinner: a64: bananapi-m64: Add Bluetooth device node Chen-Yu Tsai
2018-11-08 8:25 ` Maxime Ripard
2018-11-08 8:35 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107105119.GT30658@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=loic.poulain@gmail.com \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).