From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-sunxi@googlegroups.com,
Loic Poulain <loic.poulain@gmail.com>,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/15] ARM: dts: sunxi: Enable Broadcom-based Bluetooth for multiple boards
Date: Thu, 8 Nov 2018 09:24:47 +0100 [thread overview]
Message-ID: <20181108082447.5og6sz7ump7ccjnq@flea> (raw)
In-Reply-To: <20181107101308.7626-15-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 3020 bytes --]
On Wed, Nov 07, 2018 at 06:13:07PM +0800, Chen-Yu Tsai wrote:
> This patch adds the Bluetooth node, and the underlying UART node if it's
> missing, to the board device tree file for several boards. The LPO clock
> is also added to the WiFi side's power sequencing node if it's missing,
> to correctly represent the shared connections. There is also a PCM
> connection for Bluetooth, but this is not covered in this patch.
>
> These boards all have a WiFi+BT module from AMPAK, which contains one or
> two Broadcom chips, depending on the model. The older AP6210 contains
> two, while the newer AP6212 and AP6330 contain just one, as they use
> two-in-one combo chips.
>
> The Bluetooth side of the module is always connected to a UART on the
> same pingroup as the SDIO pins for the WiFi side, in a 4 wire
> configuration. Power to the VBAT and VDDIO pins are provided either by
> the PMIC, using one or several of its regulator outputs, or other fixed
> regulators on the board. The VBAT and VDDIO pins are shared with the
> WiFi side, which would correspond to vmmc-supply and vqmmc-supply in the
> mmc host node. A clock output from the SoC or the external X-Powers RTC
> provides the LPO low power clock at 32.768 kHz.
>
> All the boards covered in this patch are ones that do not require extra
> changes to the SoC's dtsi file. For the remaining boards that I have
> worked on, properties or device nodes for the LPO clock's source are
> missing.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 22 +++++++++++++++++++
> arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 18 +++++++++++++++
> .../boot/dts/sun8i-a83t-cubietruck-plus.dts | 18 +++++++++++++++
> arch/arm/boot/dts/sun8i-r16-bananapi-m2m.dts | 14 ++++++++++++
> 4 files changed, 72 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> index 5649161de1d7..ccbf3b7a062b 100644
> --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts
> @@ -103,6 +103,8 @@
> pinctrl-names = "default";
> pinctrl-0 = <&mmc3_pwrseq_pin_cubietruck>;
> reset-gpios = <&pio 7 9 GPIO_ACTIVE_LOW>; /* PH9 WIFI_EN */
> + clocks = <&ccu CLK_OUT_A>;
> + clock-names = "ext_clock";
> };
>
> sound {
> @@ -246,6 +248,10 @@
> };
>
> &pio {
> + /* Pin outputs low power clock for WiFi and BT */
> + pinctrl-0 = <&clk_out_a_pins_a>;
> + pinctrl-names = "default";
> +
I guess we should make it clear in the comment why it cannot be tied
to both devices.
> ahci_pwr_pin_cubietruck: ahci_pwr_pin@1 {
> pins = "PH12";
> function = "gpio_out";
> @@ -350,6 +356,22 @@
> status = "okay";
> };
>
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins_a>;
> + status = "okay";
No RTS/CTS?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-08 8:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 10:12 [PATCH 00/15] ARM: sunxi: Enable Broadcom-based Bluetooth controllers Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 01/15] dt-bindings: net: broadcom-bluetooth: Fix external clock names Chen-Yu Tsai
[not found] ` <5bea0ebe.1c69fb81.e15d7.98e1@mx.google.com>
2018-11-14 3:15 ` Chen-Yu Tsai
2018-11-14 15:51 ` Rob Herring
2018-11-14 16:13 ` Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 02/15] dt-bindings: net: broadcom-bluetooth: Add VBAT and VDDIO supplies Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 03/15] dt-bindings: net: broadcom-bluetooth: Add BCM20702A1 compatible string Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 04/15] dt-bindings: net: broadcom-bluetooth: Add BCM4330 " Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 05/15] Bluetooth: hci_bcm: Handle deferred probing for the clock supply Chen-Yu Tsai
2018-11-07 10:12 ` [PATCH 06/15] Bluetooth: hci_bcm: Simplify clk_get error handling Chen-Yu Tsai
2018-11-07 10:51 ` Russell King - ARM Linux
2018-11-07 10:13 ` [PATCH 07/15] Bluetooth: hci_bcm: Use "txco" and "extclk" to get clock reference Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 08/15] Bluetooth: hci_bcm: Add support for LPO clock Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 09/15] Bluetooth: hci_bcm: Add support for regulator supplies Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 10/15] Bluetooth: hci_bcm: Wait for device to come out of reset after power on Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 11/15] Bluetooth: hci_bcm: Add BCM20702A1 variant Chen-Yu Tsai
2018-11-07 20:36 ` Maxime Ripard
2018-11-08 6:53 ` Chen-Yu Tsai
2018-11-08 8:21 ` Maxime Ripard
2018-11-07 10:13 ` [PATCH 12/15] Bluetooth: hci_bcm: Add compatible string for BCM4330 Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 13/15] Bluetooth: btbcm: Add default address for BCM43430A0 Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 14/15] ARM: dts: sunxi: Enable Broadcom-based Bluetooth for multiple boards Chen-Yu Tsai
2018-11-08 8:24 ` Maxime Ripard [this message]
2018-11-14 5:06 ` Chen-Yu Tsai
2018-11-07 10:13 ` [PATCH 15/15] arm64: dts: allwinner: a64: bananapi-m64: Add Bluetooth device node Chen-Yu Tsai
2018-11-08 8:25 ` Maxime Ripard
2018-11-08 8:35 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108082447.5og6sz7ump7ccjnq@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=loic.poulain@gmail.com \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).