[PATCH] bluetooth: hci_bcm: Check for driver_register failure

[PATCH] bluetooth: hci_bcm: Check for driver_register failure

[Aditya Pakki]

While initializing the driver, the function platform_driver_register can
fail and return an error. Consistent with other invocations, this patch
returns the error upstream.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
 drivers/bluetooth/hci_bcm.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index ddbe518c3e5b..f5ddb0f19c31 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1442,7 +1442,12 @@ int __init bcm_init(void)
 	/* For now, we need to keep both platform device
 	 * driver (ACPI generated) and serdev driver (DT).
 	 */
-	platform_driver_register(&bcm_driver);
+	int rc;
+
+	rc = platform_driver_register(&bcm_driver);
+	if (rc)
+		return rc;
+
 	serdev_device_driver_register(&bcm_serdev_driver);
 
 	return hci_uart_register_proto(&bcm_proto);
-- 
2.17.1

Re: [PATCH] bluetooth: hci_bcm: Check for driver_register failure

[Marcel Holtmann]

Hi Aditya,

> While initializing the driver, the function platform_driver_register can
> fail and return an error. Consistent with other invocations, this patch
> returns the error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/bluetooth/hci_bcm.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index ddbe518c3e5b..f5ddb0f19c31 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1442,7 +1442,12 @@ int __init bcm_init(void)
> 	/* For now, we need to keep both platform device
> 	 * driver (ACPI generated) and serdev driver (DT).
> 	 */
> -	platform_driver_register(&bcm_driver);
> +	int rc;
> +
> +	rc = platform_driver_register(&bcm_driver);
> +	if (rc)
> +		return rc;
> +

actually I am fine with ignoring the error here since the usage of a platform device should be removed at some point. It was sort of a hack before we had proper ACPI integration and serdev support.

Regards

Marcel