linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Myungho Jung <mhjungk@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset()
Date: Thu, 31 Jan 2019 16:40:00 +0100	[thread overview]
Message-ID: <20190131154000.GU3691@localhost> (raw)
In-Reply-To: <20190130053925.GA26699@myunghoj-Precision-5530>

On Tue, Jan 29, 2019 at 09:39:28PM -0800, Myungho Jung wrote:
> tiocmget() and tiocmset() operations are optional and some tty drivers
> like pty miss the operations. We need NULL check to prevent from
> dereference.
> 
> Signed-off-by: Myungho Jung <mhjungk@gmail.com>
> ---
>  drivers/bluetooth/hci_ath.c   | 6 ++++++
>  drivers/bluetooth/hci_ldisc.c | 4 ++++
>  2 files changed, 10 insertions(+)

Ah, you had already submitted a v2.

I still suggest splitting this one in two patches and that you add a
Fixes and stable tag to each so that they both get backported to stable.

Also, when resubmitting, make sure to include a short changelog here
below the cut-off line (---).

> 
> diff --git a/drivers/bluetooth/hci_ath.c b/drivers/bluetooth/hci_ath.c
> index d568fbd94d6c..fb9f6323a911 100644
> --- a/drivers/bluetooth/hci_ath.c
> +++ b/drivers/bluetooth/hci_ath.c
> @@ -185,8 +185,14 @@ static int ath_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
>  
>  static int ath_setup(struct hci_uart *hu)
>  {
> +	struct tty_struct *tty = hu->tty;
> +
>  	BT_DBG("hu %p", hu);
>  
> +	/* tty driver should support operations to set RTS */
> +	if (!tty->driver->ops->tiocmget || !tty->driver->ops->tiocmset)
> +		return -EOPNOTSUPP;

-ENODEV might be more appropriate.

Johan

  reply	other threads:[~2019-01-31 15:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  5:39 [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset() Myungho Jung
2019-01-31 15:40 ` Johan Hovold [this message]
2019-02-03  6:38   ` Myungho Jung
2019-02-03 10:53     ` Johan Hovold
2019-02-04  7:29       ` Myungho Jung
2019-02-04  9:04         ` Myungho Jung
2019-02-04  9:22           ` Johan Hovold
2019-02-04  9:29             ` Myungho Jung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190131154000.GU3691@localhost \
    --to=johan@kernel.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mhjungk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).