From: Johan Hovold <johan@kernel.org>
To: Myungho Jung <mhjungk@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset()
Date: Mon, 4 Feb 2019 10:22:16 +0100 [thread overview]
Message-ID: <20190204092216.GC4686@localhost> (raw)
In-Reply-To: <20190204090436.GA3711@myunghoj-Precision-5530>
On Mon, Feb 04, 2019 at 01:04:37AM -0800, Myungho Jung wrote:
> On Sun, Feb 03, 2019 at 11:29:00PM -0800, Myungho Jung wrote:
> > On Sun, Feb 03, 2019 at 11:53:23AM +0100, Johan Hovold wrote:
> > > You should add a Fixes tag identifying the commit which introduced each
> > > bug and a stable-cc tag. If you want you can indicate the version after
> > > a # sign, but that can also be inferred from the fixes tag.
> > >
> > > For the hci_ldisc fix I think the tags would be:
> > >
> > > Fixes: 2a973dfada2b ("Bluetooth: hci_uart: Add new line discipline enhancements")
> > > Cc: stable <stable@vger.kernel.org> # 4.2
> > >
> > > You can use git blame to track down the offending commits.
> > >
> > > This should all be explained here:
> > >
> > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> I have one more question. The title of new patches should be version 3 like
> this?
> [PATCH v3] Bluetooth: hci_ath: ...
> [PATCH v3] Bluetooth: hci_ldisc: ...
>
> Or newly start with [PATCH]?
You should keep and increment the revision number even if you split a
patch (so use v3 for the resend).
I suggest you send both patches in a series (as they are related); take
a look at git-send-email for a convenient way to do that.
And always include a brief changelog (below the cut-off line, "---")
when revising patches.
Johan
next prev parent reply other threads:[~2019-02-04 9:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 5:39 [PATCH v2] Bluetooth: Add NULL check for tiocmget() and tiocmset() Myungho Jung
2019-01-31 15:40 ` Johan Hovold
2019-02-03 6:38 ` Myungho Jung
2019-02-03 10:53 ` Johan Hovold
2019-02-04 7:29 ` Myungho Jung
2019-02-04 9:04 ` Myungho Jung
2019-02-04 9:22 ` Johan Hovold [this message]
2019-02-04 9:29 ` Myungho Jung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204092216.GC4686@localhost \
--to=johan@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mhjungk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).