* [PATCH] monitor: Fix LE Set Extended Advertising Parameters TX power decoding
@ 2019-02-26 12:56 Szymon Janc
2019-03-08 15:20 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Szymon Janc @ 2019-02-26 12:56 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Szymon Janc
TX power of 127 has special meaning for this command.
---
monitor/packet.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/monitor/packet.c b/monitor/packet.c
index 96cacddd5..7f4d6b1ea 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -1115,7 +1115,7 @@ static void print_power_level(int8_t level, const char *type)
{
print_field("TX power%s%s%s: %d dbm (0x%2.2x)",
type ? " (" : "", type ? type : "", type ? ")" : "",
- level, level);
+ level, (uint8_t) level);
}
static void print_host_flow_control(uint8_t enable)
@@ -6944,7 +6944,10 @@ static void le_set_ext_adv_params_cmd(const void *data, uint8_t size)
print_peer_addr_type("Peer address type", cmd->peer_addr_type);
print_addr("Peer address", cmd->peer_addr, cmd->peer_addr_type);
print_adv_filter_policy("Filter policy", cmd->filter_policy);
- print_power_level(cmd->tx_power, NULL);
+ if (cmd->tx_power == 0xff)
+ print_field("TX power: Host has no preference (0xff)");
+ else
+ print_power_level(cmd->tx_power, NULL);
switch (cmd->primary_phy) {
case 0x01:
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] monitor: Fix LE Set Extended Advertising Parameters TX power decoding
2019-02-26 12:56 [PATCH] monitor: Fix LE Set Extended Advertising Parameters TX power decoding Szymon Janc
@ 2019-03-08 15:20 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2019-03-08 15:20 UTC (permalink / raw)
To: linux-bluetooth
On Tuesday, 26 February 2019 13:56:29 CET Szymon Janc wrote:
> TX power of 127 has special meaning for this command.
> ---
> monitor/packet.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 96cacddd5..7f4d6b1ea 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -1115,7 +1115,7 @@ static void print_power_level(int8_t level, const char
> *type) {
> print_field("TX power%s%s%s: %d dbm (0x%2.2x)",
> type ? " (" : "", type ? type : "", type ? ")" : "",
> -
level, level);
> + level,
(uint8_t) level);
> }
>
> static void print_host_flow_control(uint8_t enable)
> @@ -6944,7 +6944,10 @@ static void le_set_ext_adv_params_cmd(const void
> *data, uint8_t size) print_peer_addr_type("Peer address type",
> cmd->peer_addr_type);
> print_addr("Peer address", cmd->peer_addr, cmd->peer_addr_type);
> print_adv_filter_policy("Filter policy", cmd->filter_policy);
> - print_power_level(cmd->tx_power, NULL);
> + if (cmd->tx_power == 0xff)
> + print_field("TX power: Host has no preference (0xff)");
> + else
> + print_power_level(cmd->tx_power, NULL);
>
> switch (cmd->primary_phy) {
> case 0x01:
Applied.
--
pozdrawiam
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-08 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 12:56 [PATCH] monitor: Fix LE Set Extended Advertising Parameters TX power decoding Szymon Janc
2019-03-08 15:20 ` Szymon Janc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).