From: Rob Herring <robh@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, nsaenzjulienne@suse.de,
linux-kernel@vger.kernel.org, khilman@baylibre.com
Subject: Re: [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts properties
Date: Wed, 18 Dec 2019 14:38:18 -0600 [thread overview]
Message-ID: <20191218203818.GA8009@bogus> (raw)
In-Reply-To: <20191213161901.GZ10631@localhost>
On Fri, Dec 13, 2019 at 05:19:01PM +0100, Johan Hovold wrote:
> On Fri, Dec 13, 2019 at 04:06:21PM +0100, Guillaume La Roque wrote:
> > add interrupts and interrupt-names as optional properties
> > to support host-wakeup by interrupt properties instead of
> > host-wakeup-gpios.
> >
> > Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> > ---
> > Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > index b5eadee4a9a7..95912d979239 100644
> > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> > @@ -36,7 +36,9 @@ Optional properties:
> > - pcm-frame-type: short, long
> > - pcm-sync-mode: slave, master
> > - pcm-clock-mode: slave, master
> > -
> > + - interrupts: must be one, used to wakeup the host processor if
> > + gpiod_to_irq function not supported
>
> This is a Linux implementation detail which therefore doesn't belong in
> the binding.
>
> I think the general rule is to prefer interrupts over gpios where we
> have a choice, but here the current binding already has a
> host-wakeup-gpios.
>
> Not sure how best to handle that, maybe Rob knows.
Use gpiod_to_irqd().
You can also deprecate the gpio prop, but you have to keep driver
support for it. And updating dts files would break old kernels with new
dtbs.
Rob
next prev parent reply other threads:[~2019-12-18 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:06 [PATCH v5 0/2] add support of interrupt for host wakeup from devicetree in BCM HCI driver Guillaume La Roque
2019-12-13 15:06 ` [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts properties Guillaume La Roque
2019-12-13 16:19 ` Johan Hovold
2019-12-18 20:38 ` Rob Herring [this message]
2019-12-13 15:06 ` [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree Guillaume La Roque
2019-12-13 17:14 ` Kevin Hilman
2019-12-17 7:43 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218203818.GA8009@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=glaroque@baylibre.com \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).