Linux-Bluetooth Archive on
 help / color / Atom feed
From: Kevin Hilman <>
To: Guillaume La Roque <>,,,,
Subject: Re: [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree
Date: Fri, 13 Dec 2019 09:14:57 -0800
Message-ID: <> (raw)
In-Reply-To: <>

Guillaume La Roque <> writes:

> Actually IRQ can be found from GPIO but all platforms don't support
> gpiod_to_irq, it's the case on amlogic chip.
> so to have possibility to use interrupt mode we need to add interrupts
> property in devicetree and support it in driver.

I would reword this slightly (leaving out the amlogic specifics):

Add support for getting IRQ directly from DT instead of relying on
converting a GPIO to IRQ. This is needed for platforms with GPIO
controllers that that do not support gpiod_to_irq().

Other than that, this looks good to me and now it's clear that it only
affects the DT path.

Reviewed-by: Kevin Hilman <>


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 15:06 [PATCH v5 0/2] add support of interrupt for host wakeup from devicetree in BCM HCI driver Guillaume La Roque
2019-12-13 15:06 ` [PATCH v5 1/2] dt-bindings: net: bluetooth: add interrupts properties Guillaume La Roque
2019-12-13 16:19   ` Johan Hovold
2019-12-18 20:38     ` Rob Herring
2019-12-13 15:06 ` [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree Guillaume La Roque
2019-12-13 17:14   ` Kevin Hilman [this message]
2019-12-17  7:43     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Bluetooth Archive on

Archives are clonable:
	git clone --mirror linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ \
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone