[PATCH 1/3] Test patch #1: LONG_LINE_COMMENT

[PATCH 1/3] Test patch #1: LONG_LINE_COMMENT

[Tedd Ho-Jeong An]

DO NOT MERGE

Test patch #1
---
 tools/btpclient.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/btpclient.c b/tools/btpclient.c
index f9c693056..aa8a2bae4 100644
--- a/tools/btpclient.c
+++ b/tools/btpclient.c
@@ -3160,6 +3160,8 @@ int main(int argc, char *argv[])
 
 	l_log_set_stderr();
 
+	/* This is a test comment to test checkpatch.pl for long line over 80 column line */
+
 	while ((opt = getopt_long(argc, argv, "+hs:vq", options, NULL)) != -1) {
 		switch (opt) {
 		case 's':
-- 
2.25.3

[PATCH 2/3] Test patch #2: CODE_INDENT, LEADING_SPACE

[Tedd Ho-Jeong An]

DO NOT MERGE

Test patch #2
---
 tools/btpclient.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/btpclient.c b/tools/btpclient.c
index aa8a2bae4..7248acc2a 100644
--- a/tools/btpclient.c
+++ b/tools/btpclient.c
@@ -62,7 +62,7 @@ struct btp_adapter {
 	uint32_t supported_settings;
 	uint32_t current_settings;
 	uint32_t default_settings;
-	struct l_queue *devices;
+        struct l_queue *devices;
 };
 
 struct btp_device {
-- 
2.25.3

[PATCH 3/3] Test patch #3: OPEN_BRACE

[Tedd Ho-Jeong An]

DO NOT MERGE

Test patch #3
---
 tools/btpclient.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/btpclient.c b/tools/btpclient.c
index 7248acc2a..e2eff9575 100644
--- a/tools/btpclient.c
+++ b/tools/btpclient.c
@@ -228,7 +228,8 @@ static struct btp_device *find_device_by_path(const char *path)
 	struct btp_device *device;
 
 	for (entry = l_queue_get_entries(adapters); entry;
-							entry = entry->next) {
+							entry = entry->next)
+	{
 		struct btp_adapter *adapter = entry->data;
 
 		device = l_queue_find(adapter->devices, match_device_paths,
-- 
2.25.3

RE: [1/3] Test patch #1: LONG_LINE_COMMENT

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]


This is automated email and please do not replay to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkpatch Failed

Patch Title:
[1/3] Test patch #1: LONG_LINE_COMMENT

Output:
WARNING:LONG_LINE_COMMENT: line over 80 characters
#18: FILE: tools/btpclient.c:3163:
+	/* This is a test comment to test checkpatch.pl for long line over 80 column line */

- total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



For more details about BlueZ coding style guide, please find it
in doc/coding-style.txt

---
Regards,
Linux Bluetooth

RE: [2/3] Test patch #2: CODE_INDENT, LEADING_SPACE

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]


This is automated email and please do not replay to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkpatch Failed

Patch Title:
[2/3] Test patch #2: CODE_INDENT, LEADING_SPACE

Output:
ERROR:CODE_INDENT: code indent should use tabs where possible
#19: FILE: tools/btpclient.c:65:
+        struct l_queue *devices;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#19: FILE: tools/btpclient.c:65:
+        struct l_queue *devices;$

- total: 1 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



For more details about BlueZ coding style guide, please find it
in doc/coding-style.txt

---
Regards,
Linux Bluetooth

RE: [3/3] Test patch #3: OPEN_BRACE

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]


This is automated email and please do not replay to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.


Test Result:
Checkpatch Failed

Patch Title:
[3/3] Test patch #3: OPEN_BRACE

Output:
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#17: FILE: tools/btpclient.c:230:
 	for (entry = l_queue_get_entries(adapters); entry;
+							entry = entry->next)
+	{

- total: 1 errors, 0 warnings, 9 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.



For more details about BlueZ coding style guide, please find it
in doc/coding-style.txt

---
Regards,
Linux Bluetooth