* [PATCH BlueZ v2 2/3] tool/mgmt-tester: Add test cases for Read Clock Information API
2021-07-16 19:39 [PATCH BlueZ v2 1/3] emulator/btdev: Add support HCI_READ_CLOCK command Brian Gix
@ 2021-07-16 19:39 ` Brian Gix
2021-07-16 19:39 ` [PATCH BlueZ v2 3/3] tool/mgmt-tester: Add fail_tolerant exception Brian Gix
2021-07-16 20:37 ` [BlueZ,v2,1/3] emulator/btdev: Add support HCI_READ_CLOCK command bluez.test.bot
2 siblings, 0 replies; 4+ messages in thread
From: Brian Gix @ 2021-07-16 19:39 UTC (permalink / raw)
To: linux-bluetooth, hj.tedd.an, brian.gix
This patch adds test cases for Read Clock Information management API.
---
tools/mgmt-tester.c | 71 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 70 insertions(+), 1 deletion(-)
diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index d2ded574e..bd581874e 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -3917,6 +3917,53 @@ static const struct generic_data set_privacy_nval_param_test = {
.expect_status = MGMT_STATUS_INVALID_PARAMS,
};
+static const void *get_clock_info_send_param_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[7];
+
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ *len = sizeof(param);
+
+ return param;
+}
+
+static const void *get_clock_info_expect_param_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[17];
+ struct mgmt_rp_get_clock_info *rp;
+
+ rp = (struct mgmt_rp_get_clock_info *)param;
+ memset(param, 0, sizeof(param));
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ rp->local_clock = 0x11223344;
+ rp->piconet_clock = 0x11223344;
+ rp->accuracy = 0x5566;
+
+ *len = sizeof(param);
+
+ return param;
+}
+
+static const void *get_clock_info_expect_param_not_powered_func(uint16_t *len)
+{
+ struct test_data *data = tester_get_data();
+ static uint8_t param[17];
+
+ memset(param, 0, sizeof(param));
+ memcpy(param, hciemu_get_client_bdaddr(data->hciemu), 6);
+ param[6] = 0x00; /* Address type */
+
+ *len = sizeof(param);
+
+ return param;
+}
+
static const void *get_conn_info_send_param_func(uint16_t *len)
{
struct test_data *data = tester_get_data();
@@ -3962,6 +4009,21 @@ static const void *get_conn_info_error_expect_param_func(uint16_t *len)
return param;
}
+static const struct generic_data get_clock_info_succes1_test = {
+ .setup_settings = settings_powered_connectable_bondable_ssp,
+ .send_opcode = MGMT_OP_GET_CLOCK_INFO,
+ .send_func = get_clock_info_send_param_func,
+ .expect_status = MGMT_STATUS_SUCCESS,
+ .expect_func = get_clock_info_expect_param_func,
+};
+
+static const struct generic_data get_clock_info_fail1_test = {
+ .send_opcode = MGMT_OP_GET_CLOCK_INFO,
+ .send_func = get_clock_info_send_param_func,
+ .expect_status = MGMT_STATUS_NOT_POWERED,
+ .expect_func = get_clock_info_expect_param_not_powered_func,
+};
+
static const struct generic_data get_conn_info_succes1_test = {
.setup_settings = settings_powered_connectable_bondable_ssp,
.send_opcode = MGMT_OP_GET_CONN_INFO,
@@ -9780,7 +9842,7 @@ static void test_command_generic_connect(const void *test_data)
addr_type = data->hciemu_type == HCIEMU_TYPE_BREDRLE ? BDADDR_BREDR :
BDADDR_LE_PUBLIC;
-
+ tester_print("ADDR TYPE: %d", addr_type);
bthost = hciemu_client_get_host(data->hciemu);
bthost_hci_connect(bthost, master_bdaddr, addr_type);
}
@@ -10755,6 +10817,13 @@ int main(int argc, char *argv[])
&set_privacy_nval_param_test,
NULL, test_command_generic);
+ test_bredrle("Get Clock Info - Success",
+ &get_clock_info_succes1_test, NULL,
+ test_command_generic_connect);
+ test_bredrle("Get Clock Info - Fail (Power Off)",
+ &get_clock_info_fail1_test, NULL,
+ test_command_generic);
+
test_bredrle("Get Conn Info - Success",
&get_conn_info_succes1_test, NULL,
test_command_generic_connect);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH BlueZ v2 3/3] tool/mgmt-tester: Add fail_tolerant exception
2021-07-16 19:39 [PATCH BlueZ v2 1/3] emulator/btdev: Add support HCI_READ_CLOCK command Brian Gix
2021-07-16 19:39 ` [PATCH BlueZ v2 2/3] tool/mgmt-tester: Add test cases for Read Clock Information API Brian Gix
@ 2021-07-16 19:39 ` Brian Gix
2021-07-16 20:37 ` [BlueZ,v2,1/3] emulator/btdev: Add support HCI_READ_CLOCK command bluez.test.bot
2 siblings, 0 replies; 4+ messages in thread
From: Brian Gix @ 2021-07-16 19:39 UTC (permalink / raw)
To: linux-bluetooth, hj.tedd.an, brian.gix
Race conditions with the cmd-sync changes can cause fail status codes to
be different than originally expected. New test parameter fail_tolerant
allows a trivial fail-code mismatches to "Pass" while also warning that
the status wasn't exactly as expected.
---
tools/mgmt-tester.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index bd581874e..e369d7488 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -302,6 +302,7 @@ struct generic_data {
bool expect_sc_key;
bool force_power_off;
bool addr_type_avail;
+ bool fail_tolerant;
uint8_t addr_type;
bool set_adv;
const uint8_t *adv_data;
@@ -4063,6 +4064,7 @@ static const struct generic_data get_conn_info_power_off_test = {
.force_power_off = true,
.expect_status = MGMT_STATUS_NOT_POWERED,
.expect_func = get_conn_info_expect_param_power_off_func,
+ .fail_tolerant = true,
};
static const uint8_t load_conn_param_nval_1[16] = { 0x12, 0x11 };
@@ -7038,8 +7040,13 @@ static void command_generic_callback(uint8_t status, uint16_t length,
test->send_opcode, mgmt_errstr(status), status);
if (status != test->expect_status) {
- tester_test_abort();
- return;
+ if (!test->fail_tolerant || !!status != !!test->expect_status) {
+ tester_test_abort();
+ return;
+ }
+
+ tester_warn("Unexpected status got %d expected %d",
+ status, test->expect_status);
}
if (!test->expect_ignore_param) {
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread