linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Howard Chung <howardchung@google.com>
To: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com
Cc: Yun-Hao Chung <howardchung@chromium.org>,
	Miao-chen Chou <mcchou@chromium.org>
Subject: [Bluez PATCH v4 07/13] plugins/admin: add admin_policy adapter driver
Date: Thu, 29 Jul 2021 11:12:53 +0800	[thread overview]
Message-ID: <20210729110956.Bluez.v4.7.I29607be7ac91b0a494ab51713ba14f583eb858ed@changeid> (raw)
In-Reply-To: <20210729031258.3391756-1-howardchung@google.com>

From: Yun-Hao Chung <howardchung@chromium.org>

This adds code to register admin_policy driver to adapter when
admin plugin is enabled.

The following test steps were performed:
1. restart bluetoothd
2. check if "Admin Policy is enabled" in system log

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
---

(no changes since v1)

 plugins/admin.c | 67 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/plugins/admin.c b/plugins/admin.c
index 42866bcf7be2..923e08cb836b 100644
--- a/plugins/admin.c
+++ b/plugins/admin.c
@@ -12,17 +12,84 @@
 #include <config.h>
 #endif
 
+#include "lib/bluetooth.h"
+
+#include "src/adapter.h"
+#include "src/error.h"
 #include "src/log.h"
 #include "src/plugin.h"
 
+#include "src/shared/queue.h"
+
+/* |policy_data| has the same life cycle as btd_adapter */
+static struct btd_admin_policy {
+	struct btd_adapter *adapter;
+	uint16_t adapter_id;
+} *policy_data = NULL;
+
+static struct btd_admin_policy *admin_policy_new(struct btd_adapter *adapter)
+{
+	struct btd_admin_policy *admin_policy = NULL;
+
+	admin_policy = g_try_malloc(sizeof(*admin_policy));
+	if (!admin_policy) {
+		btd_error(btd_adapter_get_index(adapter),
+				"Failed to allocate memory for admin_policy");
+		return NULL;
+	}
+
+	admin_policy->adapter = adapter;
+	admin_policy->adapter_id = btd_adapter_get_index(adapter);
+
+	return admin_policy;
+}
+
+static void admin_policy_free(void *data)
+{
+	struct btd_admin_policy *admin_policy = data;
+
+	g_free(admin_policy);
+}
+
+static int admin_policy_adapter_probe(struct btd_adapter *adapter)
+{
+	if (policy_data) {
+		btd_warn(policy_data->adapter_id,
+						"Policy data already exists");
+		admin_policy_free(policy_data);
+		policy_data = NULL;
+	}
+
+	policy_data = admin_policy_new(adapter);
+	if (!policy_data)
+		return -ENOMEM;
+
+	btd_info(policy_data->adapter_id, "Admin Policy has been enabled");
+
+	return 0;
+}
+
+static struct btd_adapter_driver admin_policy_driver = {
+	.name	= "admin_policy",
+	.probe	= admin_policy_adapter_probe,
+	.resume = NULL,
+};
+
 static int admin_init(void)
 {
 	DBG("");
+
+	return btd_register_adapter_driver(&admin_policy_driver);
 }
 
 static void admin_exit(void)
 {
 	DBG("");
+
+	btd_unregister_adapter_driver(&admin_policy_driver);
+
+	if (policy_data)
+		admin_policy_free(policy_data);
 }
 
 BLUETOOTH_PLUGIN_DEFINE(admin, VERSION,
-- 
2.32.0.554.ge1b32706d8-goog


  parent reply	other threads:[~2021-07-29  3:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  3:12 [Bluez PATCH v4 00/13] Admin policy series Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 01/13] core: add is_allowed property in btd_service Howard Chung
2021-07-29  3:39   ` Admin policy series bluez.test.bot
2021-07-29  3:12 ` [Bluez PATCH v4 02/13] core: add adapter and device allowed_uuid functions Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 03/13] mcap: add adapter authorization Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 04/13] core: block not allowed UUID connect in auth Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 05/13] core: add device_added and device_removed to adapter driver Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 06/13] plugins: new plugin Howard Chung
2021-07-29  3:12 ` Howard Chung [this message]
2021-07-29  3:12 ` [Bluez PATCH v4 08/13] plugins/admin: add ServiceAllowList method Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 09/13] plugins/admin: add ServiceAllowList property Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 10/13] plugins/admin: add device callbacks Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 11/13] plugins/admin: add AffectedByPolicy property Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 12/13] plugins/admin: persist policy settings Howard Chung
2021-07-29  3:12 ` [Bluez PATCH v4 13/13] doc: add description of admin policy Howard Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729110956.Bluez.v4.7.I29607be7ac91b0a494ab51713ba14f583eb858ed@changeid \
    --to=howardchung@google.com \
    --cc=howardchung@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=mcchou@chromium.org \
    --subject='Re: [Bluez PATCH v4 07/13] plugins/admin: add admin_policy adapter driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).