From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, howardchung@google.com
Subject: RE: Admin policy series
Date: Wed, 28 Jul 2021 20:39:35 -0700 (PDT) [thread overview]
Message-ID: <610222f7.1c69fb81.b43b1.6924@mx.google.com> (raw)
In-Reply-To: <20210729110956.Bluez.v4.1.Ic71b1ed97538a06d02425ba502690bdab1c5d836@changeid>
[-- Attachment #1: Type: text/plain, Size: 11639 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=523089
---Test result---
Test Summary:
CheckPatch FAIL 4.21 seconds
GitLint PASS 1.59 seconds
Prep - Setup ELL PASS 47.01 seconds
Build - Prep PASS 0.11 seconds
Build - Configure PASS 8.40 seconds
Build - Make FAIL 152.72 seconds
Make Check FAIL 0.52 seconds
Make Distcheck PASS 242.04 seconds
Build w/ext ELL - Configure PASS 8.44 seconds
Build w/ext ELL - Make FAIL 140.34 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
mcap: add adapter authorization
WARNING:NEW_TYPEDEFS: do not add new typedefs
#152: FILE: profiles/health/mcap.h:253:
+typedef guint (* mcap_authorize_cb) (const bdaddr_t *src, const bdaddr_t *dst,
WARNING:LONG_LINE_COMMENT: line length of 93 exceeds 80 columns
#163: FILE: profiles/health/mcap.h:279:
+ mcap_authorize_cb authorize_cb; /* Method to request authorization */
- total: 0 errors, 2 warnings, 141 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] mcap: add adapter authorization" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
core: add device_added and device_removed to adapter driver
WARNING:SPACING: Unnecessary space before function pointer arguments
#130: FILE: src/adapter.h:114:
+ void (*device_added) (struct btd_adapter *adapter,
WARNING:SPACING: Unnecessary space before function pointer arguments
#132: FILE: src/adapter.h:116:
+ void (*device_removed) (struct btd_adapter *adapter,
- total: 0 errors, 2 warnings, 112 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] core: add device_added and device_removed to adapter driver" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
plugins/admin: add ServiceAllowList property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#63: FILE: plugins/admin.c:186:
+ const GDBusPropertyTable *property,
^
- total: 1 errors, 0 warnings, 82 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] plugins/admin: add ServiceAllowList property" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
plugins/admin: add AffectedByPolicy property
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#65: FILE: plugins/admin.c:254:
+ const GDBusPropertyTable *property,
^
- total: 1 errors, 0 warnings, 121 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] plugins/admin: add AffectedByPolicy property" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
plugins/admin: persist policy settings
WARNING:LINE_SPACING: Missing a blank line after declarations
#151: FILE: plugins/admin.c:336:
+ struct queue *uuid_list = NULL;
+ gchar **uuids = NULL;
- total: 0 errors, 1 warnings, 204 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] plugins/admin: persist policy settings" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations]
211 | void append_service_uuid(void *data, void *user_data)
| ^~~~~~~~~~~~~~~~~~~
plugins/admin.c: In function ‘free_uuid_strings’:
plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
252 | for (i = 0; i < num; i++)
| ^
plugins/admin.c: In function ‘store_policy_settings’:
plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function)
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
31 | #include "src/shared/queue.h"
+++ |+#include <errno.h>
32 |
plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c: In function ‘property_get_affected_by_policy’:
plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable]
418 | dbus_bool_t affected;
| ^~~~~~~~
plugins/admin.c: In function ‘admin_policy_adapter_probe’:
plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function)
467 | return -ENOMEM;
| ^~~~~~
plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function)
479 | return -EINVAL;
| ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1
make: *** [Makefile:4147: all] Error 2
##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations]
211 | void append_service_uuid(void *data, void *user_data)
| ^~~~~~~~~~~~~~~~~~~
plugins/admin.c: In function ‘free_uuid_strings’:
plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
252 | for (i = 0; i < num; i++)
| ^
plugins/admin.c: In function ‘store_policy_settings’:
plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function)
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
31 | #include "src/shared/queue.h"
+++ |+#include <errno.h>
32 |
plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c: In function ‘property_get_affected_by_policy’:
plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable]
418 | dbus_bool_t affected;
| ^~~~~~~~
plugins/admin.c: In function ‘admin_policy_adapter_probe’:
plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function)
467 | return -ENOMEM;
| ^~~~~~
plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function)
479 | return -EINVAL;
| ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1
make: *** [Makefile:10436: check] Error 2
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
plugins/admin.c:211:6: error: no previous declaration for ‘append_service_uuid’ [-Werror=missing-declarations]
211 | void append_service_uuid(void *data, void *user_data)
| ^~~~~~~~~~~~~~~~~~~
plugins/admin.c: In function ‘free_uuid_strings’:
plugins/admin.c:252:16: error: comparison of integer expressions of different signedness: ‘gsize’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
252 | for (i = 0; i < num; i++)
| ^
plugins/admin.c: In function ‘store_policy_settings’:
plugins/admin.c:317:26: error: ‘errno’ undeclared (first use in this function)
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c:32:1: note: ‘errno’ is defined in header ‘<errno.h>’; did you forget to ‘#include <errno.h>’?
31 | #include "src/shared/queue.h"
+++ |+#include <errno.h>
32 |
plugins/admin.c:317:26: note: each undeclared identifier is reported only once for each function it appears in
317 | filename, strerror(errno));
| ^~~~~
plugins/admin.c: In function ‘property_get_affected_by_policy’:
plugins/admin.c:418:14: error: unused variable ‘affected’ [-Werror=unused-variable]
418 | dbus_bool_t affected;
| ^~~~~~~~
plugins/admin.c: In function ‘admin_policy_adapter_probe’:
plugins/admin.c:467:11: error: ‘ENOMEM’ undeclared (first use in this function)
467 | return -ENOMEM;
| ^~~~~~
plugins/admin.c:479:11: error: ‘EINVAL’ undeclared (first use in this function)
479 | return -EINVAL;
| ^~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:8449: plugins/bluetoothd-admin.o] Error 1
make: *** [Makefile:4147: all] Error 2
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2021-07-29 3:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 3:12 [Bluez PATCH v4 00/13] Admin policy series Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 01/13] core: add is_allowed property in btd_service Howard Chung
2021-07-29 3:39 ` bluez.test.bot [this message]
2021-07-29 3:12 ` [Bluez PATCH v4 02/13] core: add adapter and device allowed_uuid functions Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 03/13] mcap: add adapter authorization Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 04/13] core: block not allowed UUID connect in auth Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 05/13] core: add device_added and device_removed to adapter driver Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 06/13] plugins: new plugin Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 07/13] plugins/admin: add admin_policy adapter driver Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 08/13] plugins/admin: add ServiceAllowList method Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 09/13] plugins/admin: add ServiceAllowList property Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 10/13] plugins/admin: add device callbacks Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 11/13] plugins/admin: add AffectedByPolicy property Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 12/13] plugins/admin: persist policy settings Howard Chung
2021-07-29 3:12 ` [Bluez PATCH v4 13/13] doc: add description of admin policy Howard Chung
-- strict thread matches above, loose matches on Subject: below --
2021-08-03 11:43 [Bluez PATCH v9 01/13] core: add is_allowed property in btd_service Howard Chung
2021-08-03 12:51 ` Admin policy series bluez.test.bot
2021-08-03 8:22 [Bluez PATCH v8 01/13] core: add is_allowed property in btd_service Howard Chung
2021-08-03 8:42 ` Admin policy series bluez.test.bot
2021-08-02 6:12 [Bluez PATCH v7 01/13] core: add is_allowed property in btd_service Howard Chung
2021-08-02 6:50 ` Admin policy series bluez.test.bot
2021-07-29 12:27 [Bluez PATCH v6 01/13] core: add is_allowed property in btd_service Howard Chung
2021-07-29 12:50 ` Admin policy series bluez.test.bot
2021-07-29 8:56 [Bluez PATCH v5 01/13] core: add is_allowed property in btd_service Howard Chung
2021-07-29 9:36 ` Admin policy series bluez.test.bot
2021-07-28 13:15 [Bluez PATCH v3 01/13] core: add is_allowed property in btd_service Howard Chung
2021-07-28 13:39 ` Admin policy series bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=610222f7.1c69fb81.b43b1.6924@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=howardchung@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).