* [Bluez PATCH v3] gatt-db: remove redundant check in foreach range
@ 2021-07-29 3:36 Howard Chung
2021-07-29 3:59 ` [Bluez,v3] " bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Howard Chung @ 2021-07-29 3:36 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Yun-Hao Chung, Archie Pusaka
From: Yun-Hao Chung <howardchung@chromium.org>
svc_start < foreach_data->end has already been checked in a few lines
before.
Reviewed-by: Archie Pusaka <apusaka@chromium.org>
---
Changes in v3:
- resore check svc_start < foreach_data->start and update commit message
Changes in v2:
- remove the entire check
src/shared/gatt-db.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/shared/gatt-db.c b/src/shared/gatt-db.c
index 8bff4d37aaa2..3a02289ce435 100644
--- a/src/shared/gatt-db.c
+++ b/src/shared/gatt-db.c
@@ -1348,9 +1348,9 @@ static void foreach_in_range(void *data, void *user_data)
return;
if (!foreach_data->attr) {
- if (svc_start < foreach_data->start ||
- svc_start > foreach_data->end)
+ if (svc_start < foreach_data->start)
return;
+
return foreach_service_in_range(data, user_data);
}
--
2.32.0.554.ge1b32706d8-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [Bluez,v3] gatt-db: remove redundant check in foreach range
2021-07-29 3:36 [Bluez PATCH v3] gatt-db: remove redundant check in foreach range Howard Chung
@ 2021-07-29 3:59 ` bluez.test.bot
0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2021-07-29 3:59 UTC (permalink / raw)
To: linux-bluetooth, howardchung
[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=523097
---Test result---
Test Summary:
CheckPatch PASS 0.28 seconds
GitLint PASS 0.10 seconds
Prep - Setup ELL PASS 39.58 seconds
Build - Prep PASS 0.10 seconds
Build - Configure PASS 6.89 seconds
Build - Make PASS 171.30 seconds
Make Check PASS 8.78 seconds
Make Distcheck PASS 201.72 seconds
Build w/ext ELL - Configure PASS 6.94 seconds
Build w/ext ELL - Make PASS 161.29 seconds
Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-29 3:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 3:36 [Bluez PATCH v3] gatt-db: remove redundant check in foreach range Howard Chung
2021-07-29 3:59 ` [Bluez,v3] " bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).