* [PATCH] Bluetooth: btrtl: Set VsMsftOpCode based on device table
@ 2021-09-28 18:10 Marcel Holtmann
2021-09-28 19:10 ` bluez.test.bot
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2021-09-28 18:10 UTC (permalink / raw)
To: linux-bluetooth
The device table already has the option to hold device specific details
and thus include the support for Microsoft extensions there as well.
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
drivers/bluetooth/btrtl.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 5a1090b7c69a..22b84405c257 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -59,6 +59,7 @@ struct id_table {
__u8 hci_bus;
bool config_needed;
bool has_rom_version;
+ bool has_msft_ext;
char *fw_name;
char *cfg_name;
};
@@ -135,6 +136,7 @@ static const struct id_table ic_id_table[] = {
{ IC_INFO(RTL_ROM_LMP_8761A, 0xb, 0xa, HCI_UART),
.config_needed = false,
.has_rom_version = true,
+ .has_msft_ext = true,
.fw_name = "rtl_bt/rtl8761b_fw.bin",
.cfg_name = "rtl_bt/rtl8761b_config" },
@@ -149,6 +151,7 @@ static const struct id_table ic_id_table[] = {
{ IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_UART),
.config_needed = true,
.has_rom_version = true,
+ .has_msft_ext = true,
.fw_name = "rtl_bt/rtl8822cs_fw.bin",
.cfg_name = "rtl_bt/rtl8822cs_config" },
@@ -156,6 +159,7 @@ static const struct id_table ic_id_table[] = {
{ IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0xa, HCI_USB),
.config_needed = false,
.has_rom_version = true,
+ .has_msft_ext = true,
.fw_name = "rtl_bt/rtl8822cu_fw.bin",
.cfg_name = "rtl_bt/rtl8822cu_config" },
@@ -163,6 +167,7 @@ static const struct id_table ic_id_table[] = {
{ IC_INFO(RTL_ROM_LMP_8822B, 0xb, 0x7, HCI_USB),
.config_needed = true,
.has_rom_version = true,
+ .has_msft_ext = true,
.fw_name = "rtl_bt/rtl8822b_fw.bin",
.cfg_name = "rtl_bt/rtl8822b_config" },
@@ -170,6 +175,7 @@ static const struct id_table ic_id_table[] = {
{ IC_INFO(RTL_ROM_LMP_8852A, 0xa, 0xb, HCI_USB),
.config_needed = false,
.has_rom_version = true,
+ .has_msft_ext = true,
.fw_name = "rtl_bt/rtl8852au_fw.bin",
.cfg_name = "rtl_bt/rtl8852au_config" },
};
@@ -684,12 +690,8 @@ struct btrtl_device_info *btrtl_initialize(struct hci_dev *hdev,
/* The following chips supports the Microsoft vendor extension,
* therefore set the corresponding VsMsftOpCode.
*/
- switch (lmp_subver) {
- case RTL_ROM_LMP_8822B:
- case RTL_ROM_LMP_8852A:
+ if (btrtl_dev->ic_info->has_msft_ext)
hci_set_msft_opcode(hdev, 0xFCF0);
- break;
- }
return btrtl_dev;
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: Bluetooth: btrtl: Set VsMsftOpCode based on device table
2021-09-28 18:10 [PATCH] Bluetooth: btrtl: Set VsMsftOpCode based on device table Marcel Holtmann
@ 2021-09-28 19:10 ` bluez.test.bot
2021-09-28 21:44 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: bluez.test.bot @ 2021-09-28 19:10 UTC (permalink / raw)
To: linux-bluetooth, marcel
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554407
---Test result---
Test Summary:
CheckPatch PASS 1.55 seconds
GitLint PASS 0.91 seconds
BuildKernel PASS 544.18 seconds
TestRunner: Setup PASS 398.95 seconds
TestRunner: l2cap-tester PASS 8.93 seconds
TestRunner: bnep-tester PASS 4.83 seconds
TestRunner: mgmt-tester PASS 75.98 seconds
TestRunner: rfcomm-tester PASS 5.93 seconds
TestRunner: sco-tester PASS 6.15 seconds
TestRunner: smp-tester PASS 6.00 seconds
TestRunner: userchan-tester PASS 5.10 seconds
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 51539 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3906 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 626719 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 14762 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13924 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11830 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 7740 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Bluetooth: btrtl: Set VsMsftOpCode based on device table
2021-09-28 19:10 ` bluez.test.bot
@ 2021-09-28 21:44 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-09-28 21:44 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Marcel Holtmann
Hi Marcel,
On Tue, Sep 28, 2021 at 12:11 PM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554407
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 1.55 seconds
> GitLint PASS 0.91 seconds
> BuildKernel PASS 544.18 seconds
> TestRunner: Setup PASS 398.95 seconds
> TestRunner: l2cap-tester PASS 8.93 seconds
> TestRunner: bnep-tester PASS 4.83 seconds
> TestRunner: mgmt-tester PASS 75.98 seconds
> TestRunner: rfcomm-tester PASS 5.93 seconds
> TestRunner: sco-tester PASS 6.15 seconds
> TestRunner: smp-tester PASS 6.00 seconds
> TestRunner: userchan-tester PASS 5.10 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth
>
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 18:10 [PATCH] Bluetooth: btrtl: Set VsMsftOpCode based on device table Marcel Holtmann
2021-09-28 19:10 ` bluez.test.bot
2021-09-28 21:44 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).