linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c
@ 2021-09-28 19:56 Mianhan Liu
  2021-09-28 21:05 ` bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Mianhan Liu @ 2021-09-28 19:56 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Marcel Holtmann, Johan Hedberg,
	Luiz Augusto von Dentz
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, Mianhan Liu

btqcomsmd.c hasn't use any macro or function declared in btqca.h,
linux/of.h and linux/slab.h.
Thus, these files can be removed from btqcomsmd.c safely without
affecting the compilation of the ./drivers/bluetooth module
---
 drivers/bluetooth/btqcomsmd.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
index 2acb719e5..0fcb423c4 100644
--- a/drivers/bluetooth/btqcomsmd.c
+++ b/drivers/bluetooth/btqcomsmd.c
@@ -5,9 +5,7 @@
  */
 
 #include <linux/module.h>
-#include <linux/slab.h>
 #include <linux/rpmsg.h>
-#include <linux/of.h>
 
 #include <linux/soc/qcom/wcnss_ctrl.h>
 #include <linux/platform_device.h>
@@ -15,7 +13,6 @@
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
 
-#include "btqca.h"
 
 struct btqcomsmd {
 	struct hci_dev *hdev;
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c
  2021-09-28 19:56 [PATCH] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c Mianhan Liu
@ 2021-09-28 21:05 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2021-09-28 21:05 UTC (permalink / raw)
  To: linux-bluetooth, liumh1

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554479

---Test result---

Test Summary:
CheckPatch                    FAIL      1.60 seconds
GitLint                       FAIL      0.93 seconds
BuildKernel                   PASS      702.06 seconds
TestRunner: Setup             PASS      506.25 seconds
TestRunner: l2cap-tester      PASS      11.37 seconds
TestRunner: bnep-tester       PASS      6.01 seconds
TestRunner: mgmt-tester       PASS      94.00 seconds
TestRunner: rfcomm-tester     PASS      7.34 seconds
TestRunner: sco-tester        PASS      7.68 seconds
TestRunner: smp-tester        PASS      7.48 seconds
TestRunner: userchan-tester   PASS      6.30 seconds

Details
##############################
Test: CheckPatch - FAIL - 1.60 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c\ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 16 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12523691.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL - 0.93 seconds
Run gitlint with rule in .gitlint
./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c
1: T1 Title exceeds max length (81>80): "./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c"




---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 51539 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3906 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 626719 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 14762 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13921 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11830 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 7739 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-28 21:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 19:56 [PATCH] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c Mianhan Liu
2021-09-28 21:05 ` bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).