linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ] mgmt-tester: Fix Get Device Flags tests
@ 2021-11-19  1:11 Luiz Augusto von Dentz
  2021-11-19  1:30 ` [BlueZ] " bluez.test.bot
  0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2021-11-19  1:11 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

With series
https://patchwork.kernel.org/project/bluetooth/list/?series=582749 Wake
up flag is properly check so force_wakeup must be set in order to have
the wakeup flag as supported.
---
 tools/mgmt-tester.c | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index e5319d123..fbb6dd62d 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -10616,7 +10616,7 @@ static const struct hci_cmd_data ll_privacy_set_device_flags_1_hci_list[] = {
 static const uint8_t device_flags_changed_params_1[] = {
 	0x12, 0x34, 0x56, 0x78, 0x9a, 0xbc,	/* BDADDR */
 	0x01,					/* Type - LE Public */
-	0x03, 0x00, 0x00, 0x00,			/* Supported Flags */
+	0x02, 0x00, 0x00, 0x00,			/* Supported Flags */
 	0x02, 0x00, 0x00, 0x00			/* Current Flags */
 };
 
@@ -11295,6 +11295,23 @@ static void check_scan(void *user_data)
 	test_condition_complete(data);
 }
 
+static void test_device_flags(const void *test_data)
+{
+	struct test_data *data = tester_get_data();
+	struct vhci *vhci = hciemu_get_vhci(data->hciemu);
+	int err;
+
+	/* Set Force Wakeup */
+	err = vhci_set_force_wakeup(vhci, true);
+	if (err) {
+		tester_warn("Unable to enable the force_wakeup");
+		tester_test_failed();
+		return;
+	}
+
+	test_command_generic(test_data);
+}
+
 static void test_remove_device(const void *test_data)
 {
 	struct test_data *data = tester_get_data();
@@ -14038,7 +14055,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Get Device Flags - Success",
 				&get_dev_flags_success,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* MGMT_OP_GET_DEVICE_FLAGS
 	 * Fail - Invalid parameter
@@ -14046,7 +14063,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Get Device Flags - Invalid Parameter",
 				&get_dev_flags_fail_1,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* MGMT_OP_SET_DEVICE_FLAGS
 	 * Success
@@ -14054,7 +14071,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Set Device Flags - Success",
 				&set_dev_flags_success,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* MGMT_OP_SET_DEVICE_FLAGS
 	 * Invalid Parameter - Missing parameter
@@ -14062,7 +14079,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Set Device Flags - Invalid Parameter 1",
 				&set_dev_flags_fail_1,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* MGMT_OP_SET_DEVICE_FLAGS
 	 * Invalid Parameter - Not supported value
@@ -14070,7 +14087,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Set Device Flags - Invalid Parameter 2",
 				&set_dev_flags_fail_2,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* MGMT_OP_SET_DEVICE_FLAGS
 	 * Device not exist
@@ -14078,7 +14095,7 @@ int main(int argc, char *argv[])
 	test_bredrle50("Set Device Flags - Device not found",
 				&set_dev_flags_fail_3,
 				setup_get_dev_flags,
-				test_command_generic);
+				test_device_flags);
 
 	/* Suspend/Resume
 	 * Setup : Power on and register Suspend Event
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [BlueZ] mgmt-tester: Fix Get Device Flags tests
  2021-11-19  1:11 [PATCH BlueZ] mgmt-tester: Fix Get Device Flags tests Luiz Augusto von Dentz
@ 2021-11-19  1:30 ` bluez.test.bot
  0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2021-11-19  1:30 UTC (permalink / raw)
  To: linux-bluetooth, luiz.dentz

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=582777

---Test result---

Test Summary:
CheckPatch                    PASS      1.49 seconds
GitLint                       PASS      1.01 seconds
Prep - Setup ELL              PASS      57.18 seconds
Build - Prep                  PASS      0.58 seconds
Build - Configure             PASS      10.70 seconds
Build - Make                  PASS      246.86 seconds
Make Check                    PASS      9.67 seconds
Make Distcheck                PASS      289.81 seconds
Build w/ext ELL - Configure   PASS      10.10 seconds
Build w/ext ELL - Make        PASS      226.16 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-19  1:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19  1:11 [PATCH BlueZ] mgmt-tester: Fix Get Device Flags tests Luiz Augusto von Dentz
2021-11-19  1:30 ` [BlueZ] " bluez.test.bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).