From: Isak Westin <isak.westin@loytec.com>
To: linux-bluetooth@vger.kernel.org
Cc: Isak Westin <isak.westin@loytec.com>
Subject: [PATCH BlueZ 2/4] mesh: Ignore SNB with invalid IV Index values
Date: Thu, 29 Sep 2022 13:03:42 +0200 [thread overview]
Message-ID: <20220929110344.26130-3-isak.westin@loytec.com> (raw)
In-Reply-To: <20220929110344.26130-1-isak.westin@loytec.com>
If we are in IV update in progress state, and receive a Secure Network
beacon with an IV index equal to last known IV index + 1, and IV update
flag set to 1, it should be ignored. See MshPRFv1.0.1 section 3.10.5.
---
mesh/net.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mesh/net.c b/mesh/net.c
index dc3d1fd80..c225fdb9a 100644
--- a/mesh/net.c
+++ b/mesh/net.c
@@ -2671,6 +2671,10 @@ static bool update_iv_ivu_state(struct mesh_net *net, uint32_t iv_index,
if (iv_index == net->iv_index)
return false;
+ /* Ignore beacon with invalid IV index value */
+ if (net->iv_update && iv_index == net->iv_index + 1)
+ return false;
+
if (!net->iv_update) {
l_debug("iv_upd_state = IV_UPD_UPDATING");
net->iv_upd_state = IV_UPD_UPDATING;
--
2.20.1
next prev parent reply other threads:[~2022-09-29 11:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 11:03 [PATCH BlueZ 0/4] Mesh: Fix IV update and KeyRefresh procedures Isak Westin
2022-09-29 11:03 ` [PATCH BlueZ 1/4] mesh: Ignore Secure Network Beacon from subnet Isak Westin
2022-09-29 12:18 ` Mesh: Fix IV update and KeyRefresh procedures bluez.test.bot
2022-09-29 11:03 ` Isak Westin [this message]
2022-09-29 11:03 ` [PATCH BlueZ 3/4] mesh: Allow Key refresh to skip Phase 2 Isak Westin
2022-09-29 11:03 ` [PATCH BlueZ 4/4] mesh: Allow Key Refresh Phase 0 to 3 transition Isak Westin
2022-10-03 21:30 ` [PATCH BlueZ 0/4] Mesh: Fix IV update and KeyRefresh procedures patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929110344.26130-3-isak.westin@loytec.com \
--to=isak.westin@loytec.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).