linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Isak Westin <isak.westin@loytec.com>
To: linux-bluetooth@vger.kernel.org
Cc: Isak Westin <isak.westin@loytec.com>
Subject: [PATCH BlueZ 4/4] mesh: Allow Key Refresh Phase 0 to 3 transition
Date: Thu, 29 Sep 2022 13:03:44 +0200	[thread overview]
Message-ID: <20220929110344.26130-5-isak.westin@loytec.com> (raw)
In-Reply-To: <20220929110344.26130-1-isak.westin@loytec.com>

Transition to Phase 3 from Phase 0 does not cause any state change, but
is a valid transition. See MshPRFv1.0.1 section 4.2.14.
---
 mesh/cfgmod-server.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
index 7044b670d..be90ef8c5 100644
--- a/mesh/cfgmod-server.c
+++ b/mesh/cfgmod-server.c
@@ -436,6 +436,10 @@ static uint16_t cfg_key_refresh_phase(struct mesh_node *node,
 				return 0;
 		}
 
+		if (pkt[2] == KEY_REFRESH_TRANS_THREE &&
+						phase == KEY_REFRESH_PHASE_NONE)
+			goto done;
+
 		status = mesh_net_key_refresh_phase_set(net, idx, pkt[2]);
 		l_debug("Set KR Phase: net=%3.3x transition=%d", idx, pkt[2]);
 
-- 
2.20.1






  parent reply	other threads:[~2022-09-29 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 11:03 [PATCH BlueZ 0/4] Mesh: Fix IV update and KeyRefresh procedures Isak Westin
2022-09-29 11:03 ` [PATCH BlueZ 1/4] mesh: Ignore Secure Network Beacon from subnet Isak Westin
2022-09-29 12:18   ` Mesh: Fix IV update and KeyRefresh procedures bluez.test.bot
2022-09-29 11:03 ` [PATCH BlueZ 2/4] mesh: Ignore SNB with invalid IV Index values Isak Westin
2022-09-29 11:03 ` [PATCH BlueZ 3/4] mesh: Allow Key refresh to skip Phase 2 Isak Westin
2022-09-29 11:03 ` Isak Westin [this message]
2022-10-03 21:30 ` [PATCH BlueZ 0/4] Mesh: Fix IV update and KeyRefresh procedures patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220929110344.26130-5-isak.westin@loytec.com \
    --to=isak.westin@loytec.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).