From: Harish Bandi <c-hbandi@codeaurora.org>
To: Claire Chang <tientzu@chromium.org>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
rjliao@codeaurora.org, rongchi@codeaurora.org,
linux-bluetooth-owner@vger.kernel.org,
Balakrishna Godavarthi <bgodavar@codeaurora.org>
Subject: Re: [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement
Date: Fri, 11 Oct 2019 12:31:33 +0530 [thread overview]
Message-ID: <238f01ec4b49fee4c0d08a0b8da7e95f@codeaurora.org> (raw)
In-Reply-To: <20191009085116.199922-1-tientzu@chromium.org>
++ Balakrishna
On 2019-10-09 14:21, Claire Chang wrote:
> Enabling in-band sleep when there is no patch/nvm-config found and
> bluetooth is running with the original fw/config.
>
> Fixes: ba8f35979002 ("Bluetooth: hci_qca: Avoid setup failure on
> missing rampatch")
> Fixes: 7dc5fe0814c3 ("Bluetooth: hci_qca: Avoid missing rampatch
> failure with userspace fw loader")
> Signed-off-by: Claire Chang <tientzu@chromium.org>
> ---
> drivers/bluetooth/hci_qca.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index e3164c200eac..367eef893a11 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -1291,10 +1291,8 @@ static int qca_setup(struct hci_uart *hu)
> /* Setup patch / NVM configurations */
> ret = qca_uart_setup(hdev, qca_baudrate, soc_type, soc_ver,
> firmware_name);
> - if (!ret) {
> - set_bit(QCA_IBS_ENABLED, &qca->flags);
> - qca_debugfs_init(hdev);
> - } else if (ret == -ENOENT) {
> +
> + if (ret == -ENOENT) {
> /* No patch/nvm-config found, run with original fw/config */
> ret = 0;
> } else if (ret == -EAGAIN) {
> @@ -1305,6 +1303,11 @@ static int qca_setup(struct hci_uart *hu)
> ret = 0;
> }
>
> + if (!ret) {
> + set_bit(QCA_IBS_ENABLED, &qca->flags);
> + qca_debugfs_init(hdev);
> + }
> +
> /* Setup bdaddr */
> if (qca_is_wcn399x(soc_type))
> hu->hdev->set_bdaddr = qca_set_bdaddr;
next prev parent reply other threads:[~2019-10-11 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:51 [PATCH] Bluetooth: hci_qca: fix in-band sleep enablement Claire Chang
2019-10-11 7:01 ` Harish Bandi [this message]
2019-10-11 7:21 ` Balakrishna Godavarthi
2019-10-18 2:59 ` Claire Chang
-- strict thread matches above, loose matches on Subject: below --
2019-10-09 8:37 Claire Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238f01ec4b49fee4c0d08a0b8da7e95f@codeaurora.org \
--to=c-hbandi@codeaurora.org \
--cc=bgodavar@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth-owner@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=rjliao@codeaurora.org \
--cc=rongchi@codeaurora.org \
--cc=tientzu@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).