Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] Bluetooth: btqca: Reset download type to default
@ 2019-08-08  6:07 Balakrishna Godavarthi
  2019-08-08  6:21 ` Rocky Liao
  2019-08-08  6:22 ` Rocky Liao
  0 siblings, 2 replies; 5+ messages in thread
From: Balakrishna Godavarthi @ 2019-08-08  6:07 UTC (permalink / raw)
  To: marcel, johan.hedberg, mka
  Cc: linux-bluetooth, hemantg, linux-arm-msm, rjliao, c_hbandi,
	Balakrishna Godavarthi

This patch will reset the download flag to default value
before retrieving the download mode type.

Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
---
 drivers/bluetooth/btqca.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 2221935fac7e..9fb247c10855 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config *config,
 	BT_DBG("Length\t\t : %d bytes", length);
 
 	config->dnld_mode = ROME_SKIP_EVT_NONE;
+	config->dnld_type = ROME_SKIP_EVT_NONE;
 
 	switch (config->type) {
 	case TLV_TYPE_PATCH:
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] Bluetooth: btqca: Reset download type to default
  2019-08-08  6:07 [PATCH v1] Bluetooth: btqca: Reset download type to default Balakrishna Godavarthi
@ 2019-08-08  6:21 ` Rocky Liao
  2019-08-08  7:21   ` Claire Chang
  2019-08-08  6:22 ` Rocky Liao
  1 sibling, 1 reply; 5+ messages in thread
From: Rocky Liao @ 2019-08-08  6:21 UTC (permalink / raw)
  To: Balakrishna Godavarthi
  Cc: marcel, johan.hedberg, mka, linux-bluetooth, hemantg,
	linux-arm-msm, c_hbandi, tientzu

+Claire

On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
> 
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
>  drivers/bluetooth/btqca.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config 
> *config,
>  	BT_DBG("Length\t\t : %d bytes", length);
> 
>  	config->dnld_mode = ROME_SKIP_EVT_NONE;
> +	config->dnld_type = ROME_SKIP_EVT_NONE;
> 
>  	switch (config->type) {
>  	case TLV_TYPE_PATCH:

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] Bluetooth: btqca: Reset download type to default
  2019-08-08  6:07 [PATCH v1] Bluetooth: btqca: Reset download type to default Balakrishna Godavarthi
  2019-08-08  6:21 ` Rocky Liao
@ 2019-08-08  6:22 ` Rocky Liao
  1 sibling, 0 replies; 5+ messages in thread
From: Rocky Liao @ 2019-08-08  6:22 UTC (permalink / raw)
  To: Balakrishna Godavarthi
  Cc: marcel, johan.hedberg, mka, linux-bluetooth, hemantg,
	linux-arm-msm, c_hbandi

On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> This patch will reset the download flag to default value
> before retrieving the download mode type.
> 
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
>  drivers/bluetooth/btqca.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 2221935fac7e..9fb247c10855 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config 
> *config,
>  	BT_DBG("Length\t\t : %d bytes", length);
> 
>  	config->dnld_mode = ROME_SKIP_EVT_NONE;
> +	config->dnld_type = ROME_SKIP_EVT_NONE;
> 
>  	switch (config->type) {
>  	case TLV_TYPE_PATCH:

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project

Reviewed-by: Rocky Liao <rjliao@codeaurora.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] Bluetooth: btqca: Reset download type to default
  2019-08-08  6:21 ` Rocky Liao
@ 2019-08-08  7:21   ` Claire Chang
  2019-08-08  8:57     ` Balakrishna Godavarthi
  0 siblings, 1 reply; 5+ messages in thread
From: Claire Chang @ 2019-08-08  7:21 UTC (permalink / raw)
  To: Rocky Liao
  Cc: Balakrishna Godavarthi, marcel, johan.hedberg, Matthias Kaehlcke,
	linux-bluetooth, hemantg, linux-arm-msm, c_hbandi

Tested-by: Claire Chang <tientzu@chromium.org>

Hi,

Please add the Fixes: tag and I will add my Reviewed-by: tag.

Thanks,
Claire

On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <rjliao@codeaurora.org> wrote:
>
> +Claire
>
> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
> > This patch will reset the download flag to default value
> > before retrieving the download mode type.
> >
> > Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> > ---
> >  drivers/bluetooth/btqca.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index 2221935fac7e..9fb247c10855 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
> > *config,
> >       BT_DBG("Length\t\t : %d bytes", length);
> >
> >       config->dnld_mode = ROME_SKIP_EVT_NONE;
> > +     config->dnld_type = ROME_SKIP_EVT_NONE;
> >
> >       switch (config->type) {
> >       case TLV_TYPE_PATCH:
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1] Bluetooth: btqca: Reset download type to default
  2019-08-08  7:21   ` Claire Chang
@ 2019-08-08  8:57     ` Balakrishna Godavarthi
  0 siblings, 0 replies; 5+ messages in thread
From: Balakrishna Godavarthi @ 2019-08-08  8:57 UTC (permalink / raw)
  To: Claire Chang
  Cc: Rocky Liao, marcel, johan.hedberg, Matthias Kaehlcke,
	linux-bluetooth, hemantg, linux-arm-msm, c_hbandi

Hi,

On 2019-08-08 12:51, Claire Chang wrote:
> Tested-by: Claire Chang <tientzu@chromium.org>
> 
> Hi,
> 
> Please add the Fixes: tag and I will add my Reviewed-by: tag.
> 
> Thanks,
> Claire
> 
> On Thu, Aug 8, 2019 at 2:21 PM Rocky Liao <rjliao@codeaurora.org> 
> wrote:
>> 
>> +Claire
>> 
>> On 2019-08-08 14:07, Balakrishna Godavarthi wrote:
>> > This patch will reset the download flag to default value
>> > before retrieving the download mode type.
>> >
>> > Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> > ---
>> >  drivers/bluetooth/btqca.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> > index 2221935fac7e..9fb247c10855 100644
>> > --- a/drivers/bluetooth/btqca.c
>> > +++ b/drivers/bluetooth/btqca.c
>> > @@ -140,6 +140,7 @@ static void qca_tlv_check_data(struct rome_config
>> > *config,
>> >       BT_DBG("Length\t\t : %d bytes", length);
>> >
>> >       config->dnld_mode = ROME_SKIP_EVT_NONE;
>> > +     config->dnld_type = ROME_SKIP_EVT_NONE;
>> >
>> >       switch (config->type) {
>> >       case TLV_TYPE_PATCH:
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project

uploaded new patch set.

-- 
Regards
Balakrishna.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08  6:07 [PATCH v1] Bluetooth: btqca: Reset download type to default Balakrishna Godavarthi
2019-08-08  6:21 ` Rocky Liao
2019-08-08  7:21   ` Claire Chang
2019-08-08  8:57     ` Balakrishna Godavarthi
2019-08-08  6:22 ` Rocky Liao

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org linux-bluetooth@archiver.kernel.org
	public-inbox-index linux-bluetooth


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/ public-inbox