* [PATCH] Bluetooth: msft: Fix build when BT_MSFTEXT is not defined
@ 2021-09-27 22:00 Luiz Augusto von Dentz
2021-09-27 23:03 ` bluez.test.bot
2021-09-28 8:03 ` [PATCH] " Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2021-09-27 22:00 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
ld: net/bluetooth/hci_event.o: in function `msft_suspend':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
ld: net/bluetooth/hci_event.o: in function `msft_resume':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
ld: net/bluetooth/mgmt.o: in function `msft_suspend':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
ld: net/bluetooth/mgmt.o: in function `msft_resume':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
ld: net/bluetooth/hci_request.o: in function `msft_suspend':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
ld: net/bluetooth/hci_request.o: in function `msft_resume':
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
make: *** [Makefile:1176: vmlinux] Error 1
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
net/bluetooth/msft.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/msft.h b/net/bluetooth/msft.h
index 27d73f82b9de..59c6e081c789 100644
--- a/net/bluetooth/msft.h
+++ b/net/bluetooth/msft.h
@@ -61,8 +61,8 @@ static inline int msft_set_filter_enable(struct hci_dev *hdev, bool enable)
return -EOPNOTSUPP;
}
-void msft_suspend(struct hci_dev *hdev) {}
-void msft_resume(struct hci_dev *hdev) {}
+static inline void msft_suspend(struct hci_dev *hdev) {}
+static inline void msft_resume(struct hci_dev *hdev) {}
static inline bool msft_curve_validity(struct hci_dev *hdev)
{
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: Bluetooth: msft: Fix build when BT_MSFTEXT is not defined
2021-09-27 22:00 [PATCH] Bluetooth: msft: Fix build when BT_MSFTEXT is not defined Luiz Augusto von Dentz
@ 2021-09-27 23:03 ` bluez.test.bot
2021-09-28 8:03 ` [PATCH] " Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-09-27 23:03 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=553795
---Test result---
Test Summary:
CheckPatch FAIL 1.46 seconds
GitLint PASS 0.86 seconds
BuildKernel PASS 521.52 seconds
TestRunner: Setup PASS 385.03 seconds
TestRunner: l2cap-tester PASS 8.73 seconds
TestRunner: bnep-tester PASS 4.75 seconds
TestRunner: mgmt-tester PASS 74.53 seconds
TestRunner: rfcomm-tester PASS 5.82 seconds
TestRunner: sco-tester PASS 6.05 seconds
TestRunner: smp-tester PASS 5.90 seconds
TestRunner: userchan-tester PASS 5.01 seconds
Details
##############################
Test: CheckPatch - FAIL - 1.46 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
Bluetooth: msft: Fix build when BT_MSFTEXT is not defined\WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#84:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#87:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#90:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#93:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#96:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
WARNING:USE_RELATIVE_PATH: use relative pathname instead of absolute in changelog text
#99:
/linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
total: 0 errors, 6 warnings, 0 checks, 10 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12521075.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 51539 bytes --]
[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3906 bytes --]
[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 626719 bytes --]
[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 14762 bytes --]
[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 13924 bytes --]
[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11830 bytes --]
[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 7739 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Bluetooth: msft: Fix build when BT_MSFTEXT is not defined
2021-09-27 22:00 [PATCH] Bluetooth: msft: Fix build when BT_MSFTEXT is not defined Luiz Augusto von Dentz
2021-09-27 23:03 ` bluez.test.bot
@ 2021-09-28 8:03 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2021-09-28 8:03 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hi Luiz,
> ld: net/bluetooth/hci_event.o: in function `msft_suspend':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> ld: net/bluetooth/hci_event.o: in function `msft_resume':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> ld: net/bluetooth/mgmt.o: in function `msft_suspend':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> ld: net/bluetooth/mgmt.o: in function `msft_resume':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> ld: net/bluetooth/hci_request.o: in function `msft_suspend':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_suspend';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> ld: net/bluetooth/hci_request.o: in function `msft_resume':
> /linux/net/bluetooth/msft.h:64: multiple definition of `msft_resume';
> net/bluetooth/hci_core.o:/linux/net/bluetooth/msft.h:64: first defined here
> make: *** [Makefile:1176: vmlinux] Error 1
>
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/msft.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I decided to amend the commit at fault.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-28 8:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 22:00 [PATCH] Bluetooth: msft: Fix build when BT_MSFTEXT is not defined Luiz Augusto von Dentz
2021-09-27 23:03 ` bluez.test.bot
2021-09-28 8:03 ` [PATCH] " Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).