* [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
@ 2022-02-15 22:50 Fabrice Fontaine
2022-02-16 0:22 ` [BlueZ] " bluez.test.bot
2022-02-16 11:57 ` [PATCH BlueZ] " Michael Nosthoff
0 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-02-15 22:50 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Nosthoff, Michael Nosthoff
From: Michael Nosthoff <bluez@heine.tech>
mesh-cfgtest.c uses PATH_MAX so it should include limits.h.
fixes compilation error when enabling mesh support with musl-based
toolchains observed in buildroot autobuilders.
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/
Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
I'm sending back this patch as for an unknown reason, the patch sent by
Michael in July 2021 is set as superseded in patchwork:
https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
tools/mesh-cfgtest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
index fa0474faa..116ab7f16 100644
--- a/tools/mesh-cfgtest.c
+++ b/tools/mesh-cfgtest.c
@@ -21,6 +21,7 @@
#include <ftw.h>
#include <getopt.h>
#include <libgen.h>
+#include <limits.h>
#include <signal.h>
#include <stdio.h>
#include <time.h>
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [BlueZ] tools/mesh-cfgtest: include limits.h
2022-02-15 22:50 [PATCH BlueZ] tools/mesh-cfgtest: include limits.h Fabrice Fontaine
@ 2022-02-16 0:22 ` bluez.test.bot
2022-02-16 11:57 ` [PATCH BlueZ] " Michael Nosthoff
1 sibling, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2022-02-16 0:22 UTC (permalink / raw)
To: linux-bluetooth, fontaine.fabrice
[-- Attachment #1: Type: text/plain, Size: 2241 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=614720
---Test result---
Test Summary:
CheckPatch FAIL 1.40 seconds
GitLint FAIL 0.99 seconds
Prep - Setup ELL PASS 41.86 seconds
Build - Prep PASS 0.77 seconds
Build - Configure PASS 8.46 seconds
Build - Make PASS 1361.27 seconds
Make Check PASS 11.94 seconds
Make Check w/Valgrind PASS 437.89 seconds
Make Distcheck PASS 225.60 seconds
Build w/ext ELL - Configure PASS 8.57 seconds
Build w/ext ELL - Make PASS 1344.82 seconds
Incremental Build with patchesPASS 0.00 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] tools/mesh-cfgtest: include limits.h
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#87:
http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
/github/workspace/src/12747687.patch total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/12747687.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] tools/mesh-cfgtest: include limits.h
17: B1 Line exceeds max length (92>80): "https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech"
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
2022-02-15 22:50 [PATCH BlueZ] tools/mesh-cfgtest: include limits.h Fabrice Fontaine
2022-02-16 0:22 ` [BlueZ] " bluez.test.bot
@ 2022-02-16 11:57 ` Michael Nosthoff
2022-02-16 12:35 ` Fabrice Fontaine
2022-02-16 18:34 ` Gix, Brian
1 sibling, 2 replies; 6+ messages in thread
From: Michael Nosthoff @ 2022-02-16 11:57 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: linux-bluetooth, Michael Nosthoff, Michael Nosthoff
Hi Fabrice,
On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> ---
> I'm sending back this patch as for an unknown reason, the patch sent by
> Michael in July 2021 is set as superseded in patchwork:
> https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
>
I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/
Regards,
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
2022-02-16 11:57 ` [PATCH BlueZ] " Michael Nosthoff
@ 2022-02-16 12:35 ` Fabrice Fontaine
2022-02-16 18:34 ` Gix, Brian
1 sibling, 0 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-02-16 12:35 UTC (permalink / raw)
To: Michael Nosthoff; +Cc: linux-bluetooth, Michael Nosthoff
Hi Michael,
Le mer. 16 févr. 2022 à 12:57, Michael Nosthoff <bluez@heine.tech> a écrit :
>
> Hi Fabrice,
>
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
> >
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
>
> https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/
Thanks for pointing out v2, I missed it.
Would be great to merge one of the version of this patch so we can
drop it from buildroot.
>
> Regards,
> Michael
>
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
2022-02-16 11:57 ` [PATCH BlueZ] " Michael Nosthoff
2022-02-16 12:35 ` Fabrice Fontaine
@ 2022-02-16 18:34 ` Gix, Brian
1 sibling, 0 replies; 6+ messages in thread
From: Gix, Brian @ 2022-02-16 18:34 UTC (permalink / raw)
To: bluez, fontaine.fabrice; +Cc: buildroot, linux-bluetooth, Stotland, Inga
The clean applying version of this patch has been applied. This is *not* the one with the Notes attached which
broke length rules in the commit message.
On Wed, 2022-02-16 at 12:57 +0100, Michael Nosthoff wrote:
> Hi Fabrice,
>
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
> >
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
>
> https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/
>
> Regards,
> Michael
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
@ 2021-07-22 20:49 Michael Nosthoff
0 siblings, 0 replies; 6+ messages in thread
From: Michael Nosthoff @ 2021-07-22 20:49 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Michael Nosthoff
mesh-cfgtest.c uses MAX_PATH so it should include limits.h.
fixes compilation error with musl-based toolchains.
---
tools/mesh-cfgtest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
index fa0474faa..116ab7f16 100644
--- a/tools/mesh-cfgtest.c
+++ b/tools/mesh-cfgtest.c
@@ -21,6 +21,7 @@
#include <ftw.h>
#include <getopt.h>
#include <libgen.h>
+#include <limits.h>
#include <signal.h>
#include <stdio.h>
#include <time.h>
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-16 18:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 22:50 [PATCH BlueZ] tools/mesh-cfgtest: include limits.h Fabrice Fontaine
2022-02-16 0:22 ` [BlueZ] " bluez.test.bot
2022-02-16 11:57 ` [PATCH BlueZ] " Michael Nosthoff
2022-02-16 12:35 ` Fabrice Fontaine
2022-02-16 18:34 ` Gix, Brian
-- strict thread matches above, loose matches on Subject: below --
2021-07-22 20:49 Michael Nosthoff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).