* [PATCH] Bluetooth: 6lowpan: No need to clear memory twice
@ 2022-02-13 21:30 Christophe JAILLET
2022-02-13 22:00 ` bluez.test.bot
2022-02-14 14:18 ` [PATCH] " Marcel Holtmann
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-02-13 21:30 UTC (permalink / raw)
To: Marcel Holtmann, Johan Hedberg, Luiz Augusto von Dentz,
David S. Miller, Jakub Kicinski
Cc: linux-kernel, kernel-janitors, Christophe JAILLET,
linux-bluetooth, netdev
'peer_addr' is a structure embedded in 'struct lowpan_peer'. So there is no
need to explicitly call memset(0) on it. It is already zeroed by kzalloc()
when 'peer' is allocated.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/bluetooth/6lowpan.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
index 133d7ea063fb..8e8c07541153 100644
--- a/net/bluetooth/6lowpan.c
+++ b/net/bluetooth/6lowpan.c
@@ -641,7 +641,6 @@ static struct l2cap_chan *add_peer_chan(struct l2cap_chan *chan,
return NULL;
peer->chan = chan;
- memset(&peer->peer_addr, 0, sizeof(struct in6_addr));
baswap((void *)peer->lladdr, &chan->dst);
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: Bluetooth: 6lowpan: No need to clear memory twice
2022-02-13 21:30 [PATCH] Bluetooth: 6lowpan: No need to clear memory twice Christophe JAILLET
@ 2022-02-13 22:00 ` bluez.test.bot
2022-02-14 14:18 ` [PATCH] " Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-02-13 22:00 UTC (permalink / raw)
To: linux-bluetooth, christophe.jaillet
[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=613897
---Test result---
Test Summary:
CheckPatch PASS 1.64 seconds
GitLint PASS 1.05 seconds
SubjectPrefix PASS 0.83 seconds
BuildKernel PASS 34.58 seconds
BuildKernel32 PASS 30.57 seconds
Incremental Build with patchesPASS 41.25 seconds
TestRunner: Setup PASS 541.75 seconds
TestRunner: l2cap-tester PASS 15.24 seconds
TestRunner: bnep-tester PASS 7.02 seconds
TestRunner: mgmt-tester PASS 115.93 seconds
TestRunner: rfcomm-tester PASS 8.80 seconds
TestRunner: sco-tester PASS 8.81 seconds
TestRunner: smp-tester PASS 8.72 seconds
TestRunner: userchan-tester PASS 7.27 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Bluetooth: 6lowpan: No need to clear memory twice
2022-02-13 21:30 [PATCH] Bluetooth: 6lowpan: No need to clear memory twice Christophe JAILLET
2022-02-13 22:00 ` bluez.test.bot
@ 2022-02-14 14:18 ` Marcel Holtmann
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2022-02-14 14:18 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Johan Hedberg, Luiz Augusto von Dentz, David S. Miller,
Jakub Kicinski, LKML, kernel-janitors, BlueZ, netdev
Hi Christophe,
> 'peer_addr' is a structure embedded in 'struct lowpan_peer'. So there is no
> need to explicitly call memset(0) on it. It is already zeroed by kzalloc()
> when 'peer' is allocated.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> net/bluetooth/6lowpan.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-14 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13 21:30 [PATCH] Bluetooth: 6lowpan: No need to clear memory twice Christophe JAILLET
2022-02-13 22:00 ` bluez.test.bot
2022-02-14 14:18 ` [PATCH] " Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).