* [PATCH] avinfo: Print more A/V capabilities
@ 2020-05-12 16:51 Pali Rohár
2020-05-12 17:37 ` bluez.test.bot
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Pali Rohár @ 2020-05-12 16:51 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Luiz Augusto von Dentz
---
tools/avinfo.c | 27 ++++++++++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tools/avinfo.c b/tools/avinfo.c
index e45b50918..576981a5e 100644
--- a/tools/avinfo.c
+++ b/tools/avinfo.c
@@ -65,6 +65,7 @@
#define AVDTP_HEADER_COMPRESSION 0x05
#define AVDTP_MULTIPLEXING 0x06
#define AVDTP_MEDIA_CODEC 0x07
+#define AVDTP_DELAY_REPORTING 0x08
/* SEP types definitions */
#define AVDTP_SEP_TYPE_SOURCE 0x00
@@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
switch (cap->category) {
case AVDTP_MEDIA_TRANSPORT:
+ printf("\tMedia Transport: Supported\n");
+ break;
case AVDTP_REPORTING:
+ printf("\tReporting: Supported\n");
+ break;
+ case AVDTP_DELAY_REPORTING:
+ printf("\tDelay Reporting: Supported\n");
+ break;
case AVDTP_RECOVERY:
+ case AVDTP_HEADER_COMPRESSION:
case AVDTP_MULTIPLEXING:
- /* FIXME: Add proper functions */
- break;
default:
- printf("\tUnknown category: %d\n", cap->category);
+ switch (cap->category) {
+ case AVDTP_RECOVERY:
+ printf("\tRecovery:\n");
+ break;
+ case AVDTP_HEADER_COMPRESSION:
+ printf("\tHeader compression:\n");
+ break;
+ case AVDTP_MULTIPLEXING:
+ printf("\tMultiplexing:\n");
+ break;
+ default:
+ printf("\tUnknown category: %d\n", cap->category);
+ break;
+ }
+ /* FIXME: Add proper functions */
printf("\t\tData:");
for (i = 0; i < cap->length; ++i)
printf(" 0x%.02x",
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: avinfo: Print more A/V capabilities
2020-05-12 16:51 [PATCH] avinfo: Print more A/V capabilities Pali Rohár
@ 2020-05-12 17:37 ` bluez.test.bot
2020-05-12 17:37 ` bluez.test.bot
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2020-05-12 17:37 UTC (permalink / raw)
To: linux-bluetooth, pali
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkpatch Failed
Outputs:
WARNING:LONG_LINE: line over 80 characters
#49: FILE: tools/avinfo.c:723:
+ printf("\tUnknown category: %d\n", cap->category);
- total: 0 errors, 1 warnings, 43 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: avinfo: Print more A/V capabilities
2020-05-12 16:51 [PATCH] avinfo: Print more A/V capabilities Pali Rohár
2020-05-12 17:37 ` bluez.test.bot
@ 2020-05-12 17:37 ` bluez.test.bot
2020-07-01 8:35 ` [PATCH] " Pali Rohár
2020-08-08 13:23 ` Pali Rohár
3 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2020-05-12 17:37 UTC (permalink / raw)
To: linux-bluetooth, pali
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkgitlint Failed
Outputs:
3: B6 Body message is missing
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] avinfo: Print more A/V capabilities
2020-05-12 16:51 [PATCH] avinfo: Print more A/V capabilities Pali Rohár
2020-05-12 17:37 ` bluez.test.bot
2020-05-12 17:37 ` bluez.test.bot
@ 2020-07-01 8:35 ` Pali Rohár
2020-08-08 13:23 ` Pali Rohár
3 siblings, 0 replies; 6+ messages in thread
From: Pali Rohár @ 2020-07-01 8:35 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Luiz Augusto von Dentz
Hello! Could you look at following patch?
On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> ---
> tools/avinfo.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/tools/avinfo.c b/tools/avinfo.c
> index e45b50918..576981a5e 100644
> --- a/tools/avinfo.c
> +++ b/tools/avinfo.c
> @@ -65,6 +65,7 @@
> #define AVDTP_HEADER_COMPRESSION 0x05
> #define AVDTP_MULTIPLEXING 0x06
> #define AVDTP_MEDIA_CODEC 0x07
> +#define AVDTP_DELAY_REPORTING 0x08
>
> /* SEP types definitions */
> #define AVDTP_SEP_TYPE_SOURCE 0x00
> @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
>
> switch (cap->category) {
> case AVDTP_MEDIA_TRANSPORT:
> + printf("\tMedia Transport: Supported\n");
> + break;
> case AVDTP_REPORTING:
> + printf("\tReporting: Supported\n");
> + break;
> + case AVDTP_DELAY_REPORTING:
> + printf("\tDelay Reporting: Supported\n");
> + break;
> case AVDTP_RECOVERY:
> + case AVDTP_HEADER_COMPRESSION:
> case AVDTP_MULTIPLEXING:
> - /* FIXME: Add proper functions */
> - break;
> default:
> - printf("\tUnknown category: %d\n", cap->category);
> + switch (cap->category) {
> + case AVDTP_RECOVERY:
> + printf("\tRecovery:\n");
> + break;
> + case AVDTP_HEADER_COMPRESSION:
> + printf("\tHeader compression:\n");
> + break;
> + case AVDTP_MULTIPLEXING:
> + printf("\tMultiplexing:\n");
> + break;
> + default:
> + printf("\tUnknown category: %d\n", cap->category);
> + break;
> + }
> + /* FIXME: Add proper functions */
> printf("\t\tData:");
> for (i = 0; i < cap->length; ++i)
> printf(" 0x%.02x",
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] avinfo: Print more A/V capabilities
2020-05-12 16:51 [PATCH] avinfo: Print more A/V capabilities Pali Rohár
` (2 preceding siblings ...)
2020-07-01 8:35 ` [PATCH] " Pali Rohár
@ 2020-08-08 13:23 ` Pali Rohár
2020-09-29 21:34 ` Pali Rohár
3 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2020-08-08 13:23 UTC (permalink / raw)
To: linux-bluetooth
Hello! I would like to remind also this patch:
On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> ---
> tools/avinfo.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/tools/avinfo.c b/tools/avinfo.c
> index e45b50918..576981a5e 100644
> --- a/tools/avinfo.c
> +++ b/tools/avinfo.c
> @@ -65,6 +65,7 @@
> #define AVDTP_HEADER_COMPRESSION 0x05
> #define AVDTP_MULTIPLEXING 0x06
> #define AVDTP_MEDIA_CODEC 0x07
> +#define AVDTP_DELAY_REPORTING 0x08
>
> /* SEP types definitions */
> #define AVDTP_SEP_TYPE_SOURCE 0x00
> @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
>
> switch (cap->category) {
> case AVDTP_MEDIA_TRANSPORT:
> + printf("\tMedia Transport: Supported\n");
> + break;
> case AVDTP_REPORTING:
> + printf("\tReporting: Supported\n");
> + break;
> + case AVDTP_DELAY_REPORTING:
> + printf("\tDelay Reporting: Supported\n");
> + break;
> case AVDTP_RECOVERY:
> + case AVDTP_HEADER_COMPRESSION:
> case AVDTP_MULTIPLEXING:
> - /* FIXME: Add proper functions */
> - break;
> default:
> - printf("\tUnknown category: %d\n", cap->category);
> + switch (cap->category) {
> + case AVDTP_RECOVERY:
> + printf("\tRecovery:\n");
> + break;
> + case AVDTP_HEADER_COMPRESSION:
> + printf("\tHeader compression:\n");
> + break;
> + case AVDTP_MULTIPLEXING:
> + printf("\tMultiplexing:\n");
> + break;
> + default:
> + printf("\tUnknown category: %d\n", cap->category);
> + break;
> + }
> + /* FIXME: Add proper functions */
> printf("\t\tData:");
> for (i = 0; i < cap->length; ++i)
> printf(" 0x%.02x",
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] avinfo: Print more A/V capabilities
2020-08-08 13:23 ` Pali Rohár
@ 2020-09-29 21:34 ` Pali Rohár
0 siblings, 0 replies; 6+ messages in thread
From: Pali Rohár @ 2020-09-29 21:34 UTC (permalink / raw)
To: linux-bluetooth
On Saturday 08 August 2020 15:23:36 Pali Rohár wrote:
> Hello! I would like to remind also this patch:
PING
> On Tuesday 12 May 2020 18:51:12 Pali Rohár wrote:
> > ---
> > tools/avinfo.c | 27 ++++++++++++++++++++++++---
> > 1 file changed, 24 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/avinfo.c b/tools/avinfo.c
> > index e45b50918..576981a5e 100644
> > --- a/tools/avinfo.c
> > +++ b/tools/avinfo.c
> > @@ -65,6 +65,7 @@
> > #define AVDTP_HEADER_COMPRESSION 0x05
> > #define AVDTP_MULTIPLEXING 0x06
> > #define AVDTP_MEDIA_CODEC 0x07
> > +#define AVDTP_DELAY_REPORTING 0x08
> >
> > /* SEP types definitions */
> > #define AVDTP_SEP_TYPE_SOURCE 0x00
> > @@ -696,13 +697,33 @@ static void print_caps(void *data, int size)
> >
> > switch (cap->category) {
> > case AVDTP_MEDIA_TRANSPORT:
> > + printf("\tMedia Transport: Supported\n");
> > + break;
> > case AVDTP_REPORTING:
> > + printf("\tReporting: Supported\n");
> > + break;
> > + case AVDTP_DELAY_REPORTING:
> > + printf("\tDelay Reporting: Supported\n");
> > + break;
> > case AVDTP_RECOVERY:
> > + case AVDTP_HEADER_COMPRESSION:
> > case AVDTP_MULTIPLEXING:
> > - /* FIXME: Add proper functions */
> > - break;
> > default:
> > - printf("\tUnknown category: %d\n", cap->category);
> > + switch (cap->category) {
> > + case AVDTP_RECOVERY:
> > + printf("\tRecovery:\n");
> > + break;
> > + case AVDTP_HEADER_COMPRESSION:
> > + printf("\tHeader compression:\n");
> > + break;
> > + case AVDTP_MULTIPLEXING:
> > + printf("\tMultiplexing:\n");
> > + break;
> > + default:
> > + printf("\tUnknown category: %d\n", cap->category);
> > + break;
> > + }
> > + /* FIXME: Add proper functions */
> > printf("\t\tData:");
> > for (i = 0; i < cap->length; ++i)
> > printf(" 0x%.02x",
> > --
> > 2.20.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-29 21:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 16:51 [PATCH] avinfo: Print more A/V capabilities Pali Rohár
2020-05-12 17:37 ` bluez.test.bot
2020-05-12 17:37 ` bluez.test.bot
2020-07-01 8:35 ` [PATCH] " Pali Rohár
2020-08-08 13:23 ` Pali Rohár
2020-09-29 21:34 ` Pali Rohár
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).