linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS
@ 2021-05-13 10:18 hildawu
  2021-05-13 11:13 ` bluez.test.bot
  2021-05-13 15:12 ` [PATCH] " Marcel Holtmann
  0 siblings, 2 replies; 4+ messages in thread
From: hildawu @ 2021-05-13 10:18 UTC (permalink / raw)
  To: marcel
  Cc: johan.hedberg, luiz.dentz, linux-bluetooth, linux-kernel,
	max.chou, alex_lu, kidman

From: hildawu <hildawu@realtek.com>

Because mSBC frames do not need to be aligned to the SCO packet
boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC
data satisfy 60 Bytes avoid payload unaligned situation and fixed
some headset no voise issue.

USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes.

Signed-off-by: hildawu <hildawu@realtek.com>
---
 drivers/bluetooth/btusb.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 6f253378e893..872034e7a232 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work)
 			 * which work with WBS at all.
 			 */
 			new_alts = btusb_find_altsetting(data, 6) ? 6 : 1;
+			/* Because mSBC frames do not need to be aligned to the
+			 * SCO packet boundary. If support the Alt 3, use the
+			 * Alt 3 for HCI payload >= 60 Bytes let air packet
+			 * data satisfy 60 bytes.
+			 */
+			if ((new_alts == 1) && (btusb_find_altsetting(data, 3)))
+				new_alts = 3;
 		}
 
 		if (btusb_switch_alt_setting(hdev, new_alts) < 0)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: Bluetooth: btusb: Add support USB ALT 3 for WBS
  2021-05-13 10:18 [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS hildawu
@ 2021-05-13 11:13 ` bluez.test.bot
  2021-05-13 15:12 ` [PATCH] " Marcel Holtmann
  1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2021-05-13 11:13 UTC (permalink / raw)
  To: linux-bluetooth, hildawu

[-- Attachment #1: Type: text/plain, Size: 2630 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=481767

---Test result---

Test Summary:
CheckPatch                    PASS      0.55 seconds
GitLint                       PASS      0.12 seconds
BuildKernel                   PASS      586.21 seconds
TestRunner: Setup             PASS      384.10 seconds
TestRunner: l2cap-tester      PASS      2.74 seconds
TestRunner: bnep-tester       PASS      2.02 seconds
TestRunner: mgmt-tester       PASS      28.52 seconds
TestRunner: rfcomm-tester     PASS      2.23 seconds
TestRunner: sco-tester        PASS      2.13 seconds
TestRunner: smp-tester        PASS      2.35 seconds
TestRunner: userchan-tester   PASS      2.06 seconds

Details
##############################
Test: CheckPatch - PASS - 0.55 seconds
Run checkpatch.pl script with rule in .checkpatch.conf


##############################
Test: GitLint - PASS - 0.12 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 586.21 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 384.10 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.74 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.02 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 28.52 seconds
Run test-runner with mgmt-tester
Total: 416, Passed: 403 (96.9%), Failed: 0, Not Run: 13

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.23 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.13 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.35 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 2.06 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44230 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3557 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 546745 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11677 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9912 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11823 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5454 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS
  2021-05-13 10:18 [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS hildawu
  2021-05-13 11:13 ` bluez.test.bot
@ 2021-05-13 15:12 ` Marcel Holtmann
  2021-05-14  2:31   ` Hilda Wu
  1 sibling, 1 reply; 4+ messages in thread
From: Marcel Holtmann @ 2021-05-13 15:12 UTC (permalink / raw)
  To: Hilda Wu
  Cc: Johan Hedberg, Luiz Augusto von Dentz,
	Bluetooth Kernel Mailing List, open list, max.chou, alex_lu,
	kidman

Hi Hilda,

> Because mSBC frames do not need to be aligned to the SCO packet
> boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC
> data satisfy 60 Bytes avoid payload unaligned situation and fixed
> some headset no voise issue.
> 
> USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes.
> 
> Signed-off-by: hildawu <hildawu@realtek.com>

please use real name here.

> ---
> drivers/bluetooth/btusb.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 6f253378e893..872034e7a232 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work)
> 			 * which work with WBS at all.
> 			 */
> 			new_alts = btusb_find_altsetting(data, 6) ? 6 : 1;
> +			/* Because mSBC frames do not need to be aligned to the
> +			 * SCO packet boundary. If support the Alt 3, use the
> +			 * Alt 3 for HCI payload >= 60 Bytes let air packet
> +			 * data satisfy 60 bytes.
> +			 */
> +			if ((new_alts == 1) && (btusb_find_altsetting(data, 3)))
> +				new_alts = 3;

	if (new_alts == 1 && btusb_find_altsetting(..))
		..

Regards

Marcel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS
  2021-05-13 15:12 ` [PATCH] " Marcel Holtmann
@ 2021-05-14  2:31   ` Hilda Wu
  0 siblings, 0 replies; 4+ messages in thread
From: Hilda Wu @ 2021-05-14  2:31 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Johan Hedberg, Luiz Augusto von Dentz,
	Bluetooth Kernel Mailing List, open list, Max Chou, alex_lu,
	KidmanLee

Hi Marcel,

Thank you!
I will propose a patch v2.

Regards,
Hilda

-----Original Message-----
From: Marcel Holtmann <marcel@holtmann.org> 
Sent: Thursday, May 13, 2021 11:13 PM
To: Hilda Wu <hildawu@realtek.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>; Luiz Augusto von Dentz <luiz.dentz@gmail.com>; Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>; Max Chou <max.chou@realtek.com>; alex_lu@realsil.com.cn; KidmanLee <kidman@realtek.com>
Subject: Re: [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS

Hi Hilda,

> Because mSBC frames do not need to be aligned to the SCO packet 
> boundary. Using USB ALT 3 let HCI payload >= 60 bytes, let mSBC data 
> satisfy 60 Bytes avoid payload unaligned situation and fixed some 
> headset no voise issue.
> 
> USB Alt 3 supported also need HFP support transparent MTU in 72 Bytes.
> 
> Signed-off-by: hildawu <hildawu@realtek.com>

please use real name here.

> ---
> drivers/bluetooth/btusb.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c 
> index 6f253378e893..872034e7a232 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1752,6 +1752,13 @@ static void btusb_work(struct work_struct *work)
> 			 * which work with WBS at all.
> 			 */
> 			new_alts = btusb_find_altsetting(data, 6) ? 6 : 1;
> +			/* Because mSBC frames do not need to be aligned to the
> +			 * SCO packet boundary. If support the Alt 3, use the
> +			 * Alt 3 for HCI payload >= 60 Bytes let air packet
> +			 * data satisfy 60 bytes.
> +			 */
> +			if ((new_alts == 1) && (btusb_find_altsetting(data, 3)))
> +				new_alts = 3;

	if (new_alts == 1 && btusb_find_altsetting(..))
		..

Regards

Marcel

------Please consider the environment before printing this e-mail.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-05-14  2:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 10:18 [PATCH] Bluetooth: btusb: Add support USB ALT 3 for WBS hildawu
2021-05-13 11:13 ` bluez.test.bot
2021-05-13 15:12 ` [PATCH] " Marcel Holtmann
2021-05-14  2:31   ` Hilda Wu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).